From: Olaf Hering <olaf@aepfle.de>
To: Keir Fraser <keir.xen@gmail.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: Need help with fixing the Xen waitqueue feature
Date: Wed, 23 Nov 2011 18:00:17 +0100 [thread overview]
Message-ID: <20111123170017.GC6000@aepfle.de> (raw)
In-Reply-To: <CAF1CA5F.2560C%keir.xen@gmail.com>
On Tue, Nov 22, Keir Fraser wrote:
> We obviously can't have dom0 going to sleep on paging work. This, at least,
> isn't a wait-queue bug.
I had to rearrange some code in p2m_mem_paging_populate for my debug
stuff. This led to an uninitialized req, and as a result req.flags
sometimes had MEM_EVENT_FLAG_VCPU_PAUSED set. For some reason gcc did
not catch that..
Now waitqueues appear to work ok for me. Thanks!
What do you think about C99 initializers in p2m_mem_paging_populate,
just to avoid such mistakes?
mem_event_request_t req = { .type = MEM_EVENT_TYPE_PAGING };
Olaf
next prev parent reply other threads:[~2011-11-23 17:00 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111122150755.GA18727@aepfle.de>
2011-11-22 15:40 ` Need help with fixing the Xen waitqueue feature Keir Fraser
2011-11-22 15:54 ` Keir Fraser
2011-11-22 17:36 ` Olaf Hering
2011-11-22 17:42 ` Keir Fraser
2011-11-22 18:04 ` Olaf Hering
2011-11-22 21:15 ` Olaf Hering
2011-11-22 21:53 ` Keir Fraser
2011-11-23 17:00 ` Olaf Hering [this message]
2011-11-23 17:16 ` Keir Fraser
2011-11-23 18:06 ` Olaf Hering
2011-11-23 18:23 ` Keir Fraser
2011-11-23 18:18 ` Keir Fraser
2011-11-23 18:31 ` Olaf Hering
2011-11-23 19:21 ` Keir Fraser
2011-11-23 21:03 ` Keir Fraser
2011-11-23 22:30 ` Olaf Hering
2011-11-23 23:12 ` Keir Fraser
2011-11-24 10:00 ` Olaf Hering
2011-11-25 12:56 ` Olaf Hering
2011-11-25 18:26 ` Olaf Hering
2011-11-25 19:35 ` Keir Fraser
2011-11-24 9:15 ` Jan Beulich
2011-11-24 9:51 ` Keir Fraser
2011-11-24 9:58 ` Keir Fraser
[not found] <20111108224414.83985CF73A@homiemail-mx7.g.dreamhost.com>
2011-11-09 3:52 ` Andres Lagar-Cavilla
2011-11-09 7:09 ` Olaf Hering
2011-11-09 21:21 ` Andres Lagar-Cavilla
2011-11-22 14:34 ` George Dunlap
2011-11-09 21:30 ` Andres Lagar-Cavilla
2011-11-09 22:11 ` Olaf Hering
2011-11-10 4:29 ` Andres Lagar-Cavilla
2011-11-10 9:20 ` Jan Beulich
2011-11-10 9:26 ` Keir Fraser
2011-11-10 10:18 ` Olaf Hering
2011-11-10 12:05 ` Olaf Hering
[not found] <20111108214540.EAEBB72C4A1@homiemail-mx8.g.dreamhost.com>
2011-11-09 3:37 ` Andres Lagar-Cavilla
2011-11-09 7:02 ` Olaf Hering
2011-11-08 21:20 Olaf Hering
2011-11-08 22:05 ` Keir Fraser
2011-11-08 22:20 ` Olaf Hering
2011-11-08 22:54 ` Keir Fraser
2011-11-11 22:56 ` Olaf Hering
2011-11-12 7:00 ` Keir Fraser
2011-11-22 11:40 ` Olaf Hering
2011-11-22 13:04 ` Keir Fraser
2011-11-22 13:54 ` Olaf Hering
2011-11-22 14:24 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123170017.GC6000@aepfle.de \
--to=olaf@aepfle.de \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.