All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xen.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xensource.com
Subject: Re: Need help with fixing the Xen waitqueue feature
Date: Tue, 22 Nov 2011 15:54:44 +0000	[thread overview]
Message-ID: <CAF17644.34841%keir@xen.org> (raw)
In-Reply-To: <CAF172FF.34839%keir@xen.org>

On 22/11/2011 15:40, "Keir Fraser" <keir@xen.org> wrote:

> I have a new theory, which is that if we go round the for-loop in
> wait_event() more than once, the vcpu's pause counter gets messed up and
> goes negative, condemning it to sleep forever.

Further to this, can you please try moving the call to __prepare_to_wait()
from just after the spinlock region to just before (i.e., immediately after
the ASSERT), in prepare_to_wait(). That could well makes things work better.
On UP at least -- for SMP systems I will also need to fix the broken usage
of wqv->esp...

 -- Keir

  reply	other threads:[~2011-11-22 15:54 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111122150755.GA18727@aepfle.de>
2011-11-22 15:40 ` Need help with fixing the Xen waitqueue feature Keir Fraser
2011-11-22 15:54   ` Keir Fraser [this message]
2011-11-22 17:36   ` Olaf Hering
2011-11-22 17:42     ` Keir Fraser
2011-11-22 18:04       ` Olaf Hering
2011-11-22 21:15         ` Olaf Hering
2011-11-22 21:53           ` Keir Fraser
2011-11-23 17:00             ` Olaf Hering
2011-11-23 17:16               ` Keir Fraser
2011-11-23 18:06                 ` Olaf Hering
2011-11-23 18:23                   ` Keir Fraser
2011-11-23 18:18                 ` Keir Fraser
2011-11-23 18:31                   ` Olaf Hering
2011-11-23 19:21                     ` Keir Fraser
2011-11-23 21:03                       ` Keir Fraser
2011-11-23 22:30                         ` Olaf Hering
2011-11-23 23:12                           ` Keir Fraser
2011-11-24 10:00                             ` Olaf Hering
2011-11-25 12:56                               ` Olaf Hering
2011-11-25 18:26                                 ` Olaf Hering
2011-11-25 19:35                                   ` Keir Fraser
2011-11-24  9:15                         ` Jan Beulich
2011-11-24  9:51                           ` Keir Fraser
2011-11-24  9:58                           ` Keir Fraser
     [not found] <20111108224414.83985CF73A@homiemail-mx7.g.dreamhost.com>
2011-11-09  3:52 ` Andres Lagar-Cavilla
2011-11-09  7:09   ` Olaf Hering
2011-11-09 21:21     ` Andres Lagar-Cavilla
2011-11-22 14:34       ` George Dunlap
2011-11-09 21:30     ` Andres Lagar-Cavilla
2011-11-09 22:11       ` Olaf Hering
2011-11-10  4:29         ` Andres Lagar-Cavilla
2011-11-10  9:20           ` Jan Beulich
2011-11-10  9:26           ` Keir Fraser
2011-11-10 10:18           ` Olaf Hering
2011-11-10 12:05             ` Olaf Hering
     [not found] <20111108214540.EAEBB72C4A1@homiemail-mx8.g.dreamhost.com>
2011-11-09  3:37 ` Andres Lagar-Cavilla
2011-11-09  7:02   ` Olaf Hering
2011-11-08 21:20 Olaf Hering
2011-11-08 22:05 ` Keir Fraser
2011-11-08 22:20   ` Olaf Hering
2011-11-08 22:54     ` Keir Fraser
2011-11-11 22:56       ` Olaf Hering
2011-11-12  7:00         ` Keir Fraser
2011-11-22 11:40           ` Olaf Hering
2011-11-22 13:04             ` Keir Fraser
2011-11-22 13:54               ` Olaf Hering
2011-11-22 14:24                 ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAF17644.34841%keir@xen.org \
    --to=keir@xen.org \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.