From: Dmitry Artamonow <mad_soft@inbox.ru>
To: Paul Parsons <lost.distance@yahoo.com>
Cc: eric.y.miao@gmail.com, koen@dominion.thruhere.net,
dmitry.torokhov@gmail.com, philipp.zabel@gmail.com,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] pxa/hx4700: Add Synaptics NavPoint (PXA27x SSP/SPI) driver
Date: Wed, 23 Nov 2011 23:51:44 +0400 [thread overview]
Message-ID: <20111123195144.GB9918@rainbow> (raw)
In-Reply-To: <1322066725.99549.YahooMailClassic@web29017.mail.ird.yahoo.com>
On 16:45 Wed 23 Nov , Paul Parsons wrote:
> Add support for the Synaptics NavPoint touchpad connected to a PXA27x SSP port
> in SPI slave mode. The driver implements a simple navigation pad. The four
> raised dots are mapped to UP/DOWN/LEFT/RIGHT buttons and the centre of the
> touchpad is mapped to the ENTER button.
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> ---
Both patches look good to me. Sadly, I can't test them as Navpoint on my
hx4700 is broken for a long time :(
BTW, it's funny that driver is placed in input/mouse, but actually
reports only keyboard events :)
Anyway, reporting coordinates can be added at some later point.
--
Best regards,
Dmitry "MAD" Artamonow
WARNING: multiple messages have this Message-ID (diff)
From: mad_soft@inbox.ru (Dmitry Artamonow)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] pxa/hx4700: Add Synaptics NavPoint (PXA27x SSP/SPI) driver
Date: Wed, 23 Nov 2011 23:51:44 +0400 [thread overview]
Message-ID: <20111123195144.GB9918@rainbow> (raw)
In-Reply-To: <1322066725.99549.YahooMailClassic@web29017.mail.ird.yahoo.com>
On 16:45 Wed 23 Nov , Paul Parsons wrote:
> Add support for the Synaptics NavPoint touchpad connected to a PXA27x SSP port
> in SPI slave mode. The driver implements a simple navigation pad. The four
> raised dots are mapped to UP/DOWN/LEFT/RIGHT buttons and the centre of the
> touchpad is mapped to the ENTER button.
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> ---
Both patches look good to me. Sadly, I can't test them as Navpoint on my
hx4700 is broken for a long time :(
BTW, it's funny that driver is placed in input/mouse, but actually
reports only keyboard events :)
Anyway, reporting coordinates can be added at some later point.
--
Best regards,
Dmitry "MAD" Artamonow
next prev parent reply other threads:[~2011-11-23 19:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 16:45 [PATCH v3 1/2] pxa/hx4700: Add Synaptics NavPoint (PXA27x SSP/SPI) driver Paul Parsons
2011-11-23 16:45 ` Paul Parsons
2011-11-23 19:51 ` Dmitry Artamonow [this message]
2011-11-23 19:51 ` Dmitry Artamonow
2011-11-23 20:45 ` Paul Parsons
2011-11-23 20:45 ` Paul Parsons
2011-11-23 22:49 ` Philipp Zabel
2011-11-23 22:49 ` Philipp Zabel
2011-11-23 22:46 ` Philipp Zabel
2011-11-23 22:46 ` Philipp Zabel
2011-11-23 23:04 ` Philipp Zabel
2011-11-23 23:04 ` Philipp Zabel
2011-11-24 1:06 ` Paul Parsons
2011-11-24 1:06 ` Paul Parsons
2011-11-23 23:01 ` Russell King - ARM Linux
2011-11-23 23:01 ` Russell King - ARM Linux
2011-11-24 2:53 ` Paul Parsons
2011-11-24 2:53 ` Paul Parsons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123195144.GB9918@rainbow \
--to=mad_soft@inbox.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.