From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, linuxppc-dev@ozlabs.org,
Avi Kivity <avi@redhat.com>, kvm list <kvm@vger.kernel.org>
Subject: Re: [RFC PATCH 0/11] KVM: PPC: Update Book3S HV memory handling
Date: Wed, 23 Nov 2011 23:59:07 +0000 [thread overview]
Message-ID: <20111123235907.GC8125@amt.cnet> (raw)
In-Reply-To: <20111118215424.GA24455@bloggs.ozlabs.ibm.com>
On Sat, Nov 19, 2011 at 08:54:24AM +1100, Paul Mackerras wrote:
> On Fri, Nov 18, 2011 at 02:57:11PM +0100, Alexander Graf wrote:
> >
> > This touches areas that I'm sure non-PPC people would want to see as
> > well. Could you please CC kvm@vger too next time?
> >
> > Avi, Marcelo, mind to review some of the bits in this patch set? :)
>
> I did cc the last patch (the one that adds barriers in the MMU
> notifier sequence/count logic) to kvm@vger. Do you mean I should cc
> the whole series? The only other thing touching generic code is the
> addition of the KVM_MEMSLOT_IO flag in the first patch.
I don't see such flag anywhere in the patches in this thread?
> I'm hoping the extra barriers will be OK since they are no-ops on
> x86. In fact I now think that the smp_wmbs I added to
> kvm_mmu_notifier_invalidate_page and kvm_mmu_notifier_change_pte
> aren't in fact necessary, since it's only necessary to ensure that the
> sequence number increase is visible before the point where
> kvm_unmap_hva or kvm_set_spte_hva unlock the bitlock on the first rmap
> chain they look at, which will be ensured anyway by the barrier before
> the unlock.
>
> Paul.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, kvm list <kvm@vger.kernel.org>,
Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [RFC PATCH 0/11] KVM: PPC: Update Book3S HV memory handling
Date: Wed, 23 Nov 2011 21:59:07 -0200 [thread overview]
Message-ID: <20111123235907.GC8125@amt.cnet> (raw)
In-Reply-To: <20111118215424.GA24455@bloggs.ozlabs.ibm.com>
On Sat, Nov 19, 2011 at 08:54:24AM +1100, Paul Mackerras wrote:
> On Fri, Nov 18, 2011 at 02:57:11PM +0100, Alexander Graf wrote:
> >
> > This touches areas that I'm sure non-PPC people would want to see as
> > well. Could you please CC kvm@vger too next time?
> >
> > Avi, Marcelo, mind to review some of the bits in this patch set? :)
>
> I did cc the last patch (the one that adds barriers in the MMU
> notifier sequence/count logic) to kvm@vger. Do you mean I should cc
> the whole series? The only other thing touching generic code is the
> addition of the KVM_MEMSLOT_IO flag in the first patch.
I don't see such flag anywhere in the patches in this thread?
> I'm hoping the extra barriers will be OK since they are no-ops on
> x86. In fact I now think that the smp_wmbs I added to
> kvm_mmu_notifier_invalidate_page and kvm_mmu_notifier_change_pte
> aren't in fact necessary, since it's only necessary to ensure that the
> sequence number increase is visible before the point where
> kvm_unmap_hva or kvm_set_spte_hva unlock the bitlock on the first rmap
> chain they look at, which will be ensured anyway by the barrier before
> the unlock.
>
> Paul.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, linuxppc-dev@ozlabs.org,
Avi Kivity <avi@redhat.com>, kvm list <kvm@vger.kernel.org>
Subject: Re: [RFC PATCH 0/11] KVM: PPC: Update Book3S HV memory handling
Date: Wed, 23 Nov 2011 21:59:07 -0200 [thread overview]
Message-ID: <20111123235907.GC8125@amt.cnet> (raw)
In-Reply-To: <20111118215424.GA24455@bloggs.ozlabs.ibm.com>
On Sat, Nov 19, 2011 at 08:54:24AM +1100, Paul Mackerras wrote:
> On Fri, Nov 18, 2011 at 02:57:11PM +0100, Alexander Graf wrote:
> >
> > This touches areas that I'm sure non-PPC people would want to see as
> > well. Could you please CC kvm@vger too next time?
> >
> > Avi, Marcelo, mind to review some of the bits in this patch set? :)
>
> I did cc the last patch (the one that adds barriers in the MMU
> notifier sequence/count logic) to kvm@vger. Do you mean I should cc
> the whole series? The only other thing touching generic code is the
> addition of the KVM_MEMSLOT_IO flag in the first patch.
I don't see such flag anywhere in the patches in this thread?
> I'm hoping the extra barriers will be OK since they are no-ops on
> x86. In fact I now think that the smp_wmbs I added to
> kvm_mmu_notifier_invalidate_page and kvm_mmu_notifier_change_pte
> aren't in fact necessary, since it's only necessary to ensure that the
> sequence number increase is visible before the point where
> kvm_unmap_hva or kvm_set_spte_hva unlock the bitlock on the first rmap
> chain they look at, which will be ensured anyway by the barrier before
> the unlock.
>
> Paul.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-11-23 23:59 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 22:50 [RFC PATCH 0/11] KVM: PPC: Update Book3S HV memory handling Paul Mackerras
2011-11-16 22:50 ` Paul Mackerras
2011-11-16 22:52 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI Paul Mackerras
2011-11-16 22:52 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI passthrough and emulation Paul Mackerras
2011-11-20 12:23 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI passthrough Avi Kivity
2011-11-20 12:23 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI passthrough and emulation Avi Kivity
2011-11-21 11:03 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI Paul Mackerras
2011-11-21 11:03 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI passthrough and emulation Paul Mackerras
2011-11-21 12:22 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI passthrough Avi Kivity
2011-11-21 12:22 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI passthrough and emulation Avi Kivity
2011-11-21 21:29 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI Paul Mackerras
2011-11-21 21:29 ` [PATCH 01/11] KVM: PPC: Add memory-mapping support for PCI passthrough and emulation Paul Mackerras
2011-11-16 22:56 ` [PATCH 02/11] KVM: PPC: Keep a record of HV guest view of hashed Paul Mackerras
2011-11-16 22:56 ` [PATCH 02/11] KVM: PPC: Keep a record of HV guest view of hashed page table entries Paul Mackerras
2011-11-16 22:58 ` [PATCH 03/11] KVM: PPC: Allow use of small pages to back guest memory Paul Mackerras
2011-11-16 22:58 ` Paul Mackerras
2011-11-16 22:58 ` [PATCH 04/11] KVM: PPC: Remove io_slot_pfn array Paul Mackerras
2011-11-16 22:58 ` Paul Mackerras
2011-11-16 22:59 ` [PATCH 05/11] KVM: PPC: Use a separate vmalloc'd array to store pfns Paul Mackerras
2011-11-16 22:59 ` Paul Mackerras
2011-11-16 22:59 ` [RFC PATCH 06/11] KVM: PPC: Use Linux page tables in h_enter and map_vrma Paul Mackerras
2011-11-16 22:59 ` Paul Mackerras
2011-11-16 23:02 ` [RFC PATCH 07/11] KVM: PPC: Convert do_h_register_vpa to use Linux page Paul Mackerras
2011-11-16 23:02 ` [RFC PATCH 07/11] KVM: PPC: Convert do_h_register_vpa to use Linux page tables Paul Mackerras
2011-11-16 23:50 ` [RFC PATCH 08/11] KVM: PPC: Add a page fault handler function Paul Mackerras
2011-11-16 23:50 ` Paul Mackerras
2011-11-16 23:51 ` [RFC PATCH 09/11] KVM: PPC: Maintain a doubly-linked list of guest HPTEs Paul Mackerras
2011-11-16 23:51 ` [RFC PATCH 09/11] KVM: PPC: Maintain a doubly-linked list of guest HPTEs for each gfn Paul Mackerras
2011-11-16 23:52 ` [RFC PATCH 10/11] KVM: PPC: Implement MMU notifiers Paul Mackerras
2011-11-16 23:52 ` Paul Mackerras
2011-11-20 12:38 ` Avi Kivity
2011-11-20 12:38 ` Avi Kivity
2011-11-16 23:55 ` [RFC PATCH 11/11] KVM: PPC: Eliminate global spinlock in Paul Mackerras
2011-11-16 23:55 ` [RFC PATCH 11/11] KVM: PPC: Eliminate global spinlock in kvmppc_h_enter Paul Mackerras
2011-11-16 23:55 ` Paul Mackerras
2011-11-23 23:54 ` [RFC PATCH 11/11] KVM: PPC: Eliminate global spinlock in Marcelo Tosatti
2011-11-23 23:54 ` [RFC PATCH 11/11] KVM: PPC: Eliminate global spinlock in kvmppc_h_enter Marcelo Tosatti
2011-11-23 23:54 ` Marcelo Tosatti
2011-11-18 13:57 ` [RFC PATCH 0/11] KVM: PPC: Update Book3S HV memory handling Alexander Graf
2011-11-18 13:57 ` Alexander Graf
2011-11-18 13:57 ` Alexander Graf
2011-11-18 21:54 ` Paul Mackerras
2011-11-18 21:54 ` Paul Mackerras
2011-11-18 21:54 ` Paul Mackerras
2011-11-23 23:59 ` Marcelo Tosatti [this message]
2011-11-23 23:59 ` Marcelo Tosatti
2011-11-23 23:59 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123235907.GC8125@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.