From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org
Subject: Re: [patch] mtd/docg3: fix error handling in docg3_probe()
Date: Thu, 24 Nov 2011 09:31:20 +0000 [thread overview]
Message-ID: <20111124093119.GH3258@mwanda> (raw)
In-Reply-To: <4ECE083D.4030707@bfs.de>
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
On Thu, Nov 24, 2011 at 10:02:53AM +0100, walter harms wrote:
> the code nicely shows that docg3_floors[floor] will be foobar if mtd==NULL and floor > 0
> I guess that can cause problems with the "doc_release_device(docg3_floors[floor]);"
>
> perhaps a "docg3_floors[floor] = NULL;" can help here ?
>
It's allocated with kzalloc() so it already is.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org
Subject: Re: [patch] mtd/docg3: fix error handling in docg3_probe()
Date: Thu, 24 Nov 2011 12:31:20 +0300 [thread overview]
Message-ID: <20111124093119.GH3258@mwanda> (raw)
In-Reply-To: <4ECE083D.4030707@bfs.de>
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
On Thu, Nov 24, 2011 at 10:02:53AM +0100, walter harms wrote:
> the code nicely shows that docg3_floors[floor] will be foobar if mtd==NULL and floor > 0
> I guess that can cause problems with the "doc_release_device(docg3_floors[floor]);"
>
> perhaps a "docg3_floors[floor] = NULL;" can help here ?
>
It's allocated with kzalloc() so it already is.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-24 9:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 7:21 [patch] mtd/docg3: fix error handling in docg3_probe() Dan Carpenter
2011-11-24 7:21 ` Dan Carpenter
2011-11-24 9:02 ` walter harms
2011-11-24 9:02 ` walter harms
2011-11-24 9:31 ` Dan Carpenter [this message]
2011-11-24 9:31 ` Dan Carpenter
2011-11-24 10:17 ` Robert Jarzmik
2011-11-24 10:17 ` Robert Jarzmik
2011-11-24 10:31 ` Dan Carpenter
2011-11-24 10:31 ` Dan Carpenter
2011-11-24 21:00 ` Robert Jarzmik
2011-11-24 21:08 ` Artem Bityutskiy
2011-11-24 21:29 ` Artem Bityutskiy
2011-11-26 10:58 ` Robert Jarzmik
2011-11-26 10:58 ` Robert Jarzmik
2011-11-28 13:53 ` [patch v2] mtd/docg3: dereferencing an ERR_PTR() " Dan Carpenter
2011-11-28 13:53 ` Dan Carpenter
2011-11-29 22:00 ` Robert Jarzmik
2011-11-29 22:00 ` Robert Jarzmik
2011-12-01 8:02 ` [patch v2] mtd/docg3: dereferencing an ERR_PTR() in Artem Bityutskiy
2011-12-01 8:02 ` [patch v2] mtd/docg3: dereferencing an ERR_PTR() in docg3_probe() Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124093119.GH3258@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.