All of lore.kernel.org
 help / color / mirror / Atom feed
From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] power: bq20z75: devicetree init support
Date: Thu, 24 Nov 2011 22:42:15 +0400	[thread overview]
Message-ID: <20111124184215.GA29135@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1316031547-18281-1-git-send-email-rklein@nvidia.com>

Hello Rhyland,

Got this:

  CC [M]  drivers/power/bq20z75.o
drivers/power/bq20z75.c: In function ?bq20z75_of_populate_pdata?:
drivers/power/bq20z75.c:630:21: error: storage size of ?gpio_flags? isn?t known
drivers/power/bq20z75.c:668:2: error: implicit declaration of function ?of_get_named_gpio_flags? [-Werror=implicit-function-declaration]
drivers/power/bq20z75.c:671:19: error: ?OF_GPIO_ACTIVE_LOW? undeclared (first use in this function)
drivers/power/bq20z75.c:671:19: note: each undeclared identifier is reported only once for each function it appears in
drivers/power/bq20z75.c:630:21: warning: unused variable ?gpio_flags? [-Wunused-variable]
drivers/power/bq20z75.c:627:29: warning: unused variable ?dtid? [-Wunused-variable]

I fixed this by...

On Wed, Sep 14, 2011 at 01:19:07PM -0700, Rhyland Klein wrote:

> +#if defined(CONFIG_OF)
> +#include <linux/of_device.h>

Adding linux/of_gpio.h

> +static const struct of_device_id bq20z75_dt_ids[] = {
> +	{ .compatible = "ti,bq20z75" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, bq20z75_dt_ids);
> +
> +static struct bq20z75_platform_data *bq20z75_of_populate_pdata(
> +	struct i2c_client *client)
> +{
> +	const struct of_device_id *dtid;

And deleting that line.


Applied to battery-2.6.git, but please double check if everything
is OK.

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru at gmail.com

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5] power: bq20z75: devicetree init support
Date: Thu, 24 Nov 2011 22:42:15 +0400	[thread overview]
Message-ID: <20111124184215.GA29135@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1316031547-18281-1-git-send-email-rklein@nvidia.com>

Hello Rhyland,

Got this:

  CC [M]  drivers/power/bq20z75.o
drivers/power/bq20z75.c: In function ‘bq20z75_of_populate_pdata’:
drivers/power/bq20z75.c:630:21: error: storage size of ‘gpio_flags’ isn’t known
drivers/power/bq20z75.c:668:2: error: implicit declaration of function ‘of_get_named_gpio_flags’ [-Werror=implicit-function-declaration]
drivers/power/bq20z75.c:671:19: error: ‘OF_GPIO_ACTIVE_LOW’ undeclared (first use in this function)
drivers/power/bq20z75.c:671:19: note: each undeclared identifier is reported only once for each function it appears in
drivers/power/bq20z75.c:630:21: warning: unused variable ‘gpio_flags’ [-Wunused-variable]
drivers/power/bq20z75.c:627:29: warning: unused variable ‘dtid’ [-Wunused-variable]

I fixed this by...

On Wed, Sep 14, 2011 at 01:19:07PM -0700, Rhyland Klein wrote:

> +#if defined(CONFIG_OF)
> +#include <linux/of_device.h>

Adding linux/of_gpio.h

> +static const struct of_device_id bq20z75_dt_ids[] = {
> +	{ .compatible = "ti,bq20z75" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, bq20z75_dt_ids);
> +
> +static struct bq20z75_platform_data *bq20z75_of_populate_pdata(
> +	struct i2c_client *client)
> +{
> +	const struct of_device_id *dtid;

And deleting that line.


Applied to battery-2.6.git, but please double check if everything
is OK.

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

  parent reply	other threads:[~2011-11-24 18:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-14 20:19 [PATCH v5] power: bq20z75: devicetree init support Rhyland Klein
2011-09-14 20:19 ` Rhyland Klein
2011-09-14 20:19 ` Rhyland Klein
2011-10-14 19:03 ` Rhyland Klein
2011-10-14 19:03   ` Rhyland Klein
2011-10-14 19:03   ` Rhyland Klein
2011-11-24 18:42 ` Anton Vorontsov [this message]
2011-11-24 18:42   ` Anton Vorontsov
2011-11-28 19:13   ` Rhyland Klein
2011-11-28 19:13     ` Rhyland Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111124184215.GA29135@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.