From: Andrea Arcangeli <aarcange@redhat.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: migration: pair unlock_page and lock_page when migrating huge pages
Date: Sat, 26 Nov 2011 18:33:15 +0100 [thread overview]
Message-ID: <20111126173315.GG8397@redhat.com> (raw)
In-Reply-To: <CAJd=RBChfVC4hUKvO5ks0+NxahTgibdivLotw3VpAa7_-r8_+g@mail.gmail.com>
Hi Hillf,
On Fri, Nov 25, 2011 at 08:20:31PM +0800, Hillf Danton wrote:
> Skip unlocking page if fail to lock, then lock and unlock are paired.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/mm/migrate.c Fri Nov 25 20:11:14 2011
> +++ b/mm/migrate.c Fri Nov 25 20:21:26 2011
> @@ -869,9 +869,9 @@ static int unmap_and_move_huge_page(new_
>
> if (anon_vma)
> put_anon_vma(anon_vma);
> -out:
> unlock_page(hpage);
>
> +out:
> if (rc != -EAGAIN) {
> list_del(&hpage->lru);
> put_page(hpage);
Looks good, I guess that path wasn't exercised frequently because
there's no blocking I/O involvement with hugetlbfs.
Thanks,
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: migration: pair unlock_page and lock_page when migrating huge pages
Date: Sat, 26 Nov 2011 18:33:15 +0100 [thread overview]
Message-ID: <20111126173315.GG8397@redhat.com> (raw)
In-Reply-To: <CAJd=RBChfVC4hUKvO5ks0+NxahTgibdivLotw3VpAa7_-r8_+g@mail.gmail.com>
Hi Hillf,
On Fri, Nov 25, 2011 at 08:20:31PM +0800, Hillf Danton wrote:
> Skip unlocking page if fail to lock, then lock and unlock are paired.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/mm/migrate.c Fri Nov 25 20:11:14 2011
> +++ b/mm/migrate.c Fri Nov 25 20:21:26 2011
> @@ -869,9 +869,9 @@ static int unmap_and_move_huge_page(new_
>
> if (anon_vma)
> put_anon_vma(anon_vma);
> -out:
> unlock_page(hpage);
>
> +out:
> if (rc != -EAGAIN) {
> list_del(&hpage->lru);
> put_page(hpage);
Looks good, I guess that path wasn't exercised frequently because
there's no blocking I/O involvement with hugetlbfs.
Thanks,
Andrea
next prev parent reply other threads:[~2011-11-26 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 12:20 [PATCH] mm: migration: pair unlock_page and lock_page when migrating huge pages Hillf Danton
2011-11-25 12:20 ` Hillf Danton
2011-11-26 17:33 ` Andrea Arcangeli [this message]
2011-11-26 17:33 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111126173315.GG8397@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.