From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
levinsasha928@gmail.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhost-net: Acquire device lock when releasing device
Date: Sun, 27 Nov 2011 18:50:14 +0200 [thread overview]
Message-ID: <20111127165013.GB24941@redhat.com> (raw)
In-Reply-To: <20111126.154503.1317670837061338352.davem@davemloft.net>
On Sat, Nov 26, 2011 at 03:45:03PM -0500, David Miller wrote:
> From: Sasha Levin <levinsasha928@gmail.com>
> Date: Fri, 18 Nov 2011 11:19:42 +0200
>
> > Device lock should be held when releasing a device, and specifically
> > when calling vhost_dev_cleanup(). Otherwise, RCU complains about it:
> ...
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: kvm@vger.kernel.org
> > Cc: virtualization@lists.linux-foundation.org
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>
> Michael et al., are you guys going to gather this fix or should I
> apply it directly to thet net tree?
>
> Thanks.
I think it needs a small tweak before being applied.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: levinsasha928@gmail.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] vhost-net: Acquire device lock when releasing device
Date: Sun, 27 Nov 2011 18:50:14 +0200 [thread overview]
Message-ID: <20111127165013.GB24941@redhat.com> (raw)
In-Reply-To: <20111126.154503.1317670837061338352.davem@davemloft.net>
On Sat, Nov 26, 2011 at 03:45:03PM -0500, David Miller wrote:
> From: Sasha Levin <levinsasha928@gmail.com>
> Date: Fri, 18 Nov 2011 11:19:42 +0200
>
> > Device lock should be held when releasing a device, and specifically
> > when calling vhost_dev_cleanup(). Otherwise, RCU complains about it:
> ...
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: kvm@vger.kernel.org
> > Cc: virtualization@lists.linux-foundation.org
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>
> Michael et al., are you guys going to gather this fix or should I
> apply it directly to thet net tree?
>
> Thanks.
I think it needs a small tweak before being applied.
--
MST
next prev parent reply other threads:[~2011-11-27 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 9:19 [PATCH] vhost-net: Acquire device lock when releasing device Sasha Levin
2011-11-18 9:19 ` Sasha Levin
2011-11-26 20:45 ` David Miller
2011-11-27 16:50 ` Michael S. Tsirkin [this message]
2011-11-27 16:50 ` Michael S. Tsirkin
2011-11-26 20:45 ` David Miller
2011-11-27 16:49 ` Michael S. Tsirkin
2011-11-27 16:49 ` Michael S. Tsirkin
2011-11-27 17:06 ` Michael S. Tsirkin
2011-11-27 17:06 ` Michael S. Tsirkin
2012-01-28 0:13 ` Sasha Levin
2012-01-28 0:13 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111127165013.GB24941@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.