From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] ARM: vexpress: Get rid of MMIO_P2V
Date: Mon, 28 Nov 2011 10:53:04 +0000 [thread overview]
Message-ID: <20111128105247.GA2465@localhost.localdomain> (raw)
In-Reply-To: <20111128104416.GD9581@n2100.arm.linux.org.uk>
On Mon, Nov 28, 2011 at 10:44:16AM +0000, Russell King - ARM Linux wrote:
> On Fri, Nov 25, 2011 at 04:15:00PM +0000, Dave Martin wrote:
> > diff --git a/arch/arm/plat-versatile/headsmp.S b/arch/arm/plat-versatile/headsmp.S
> > index d397a1f..0be2efc 100644
> > --- a/arch/arm/plat-versatile/headsmp.S
> > +++ b/arch/arm/plat-versatile/headsmp.S
> > @@ -28,6 +28,7 @@ ENTRY(versatile_secondary_startup)
> > pen: ldr r7, [r6]
> > cmp r7, r0
> > bne pen
> > +ENDPROC(versatile_secondary_startup)
>
> This is wrong. You're telling the assembler that this function ends here.
> It doesn't, it continues on. Put the ENDPROC at the end of the function.
Dunno what I was thinking of there -- agreed, the ENDPROC() should move
to the end of the file.
(I'm assuming that literals should be included in the size of the
relevant function symbol here -- that's the convention the compiler
follows.)
Cheers
---Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH v2 1/4] ARM: vexpress: Get rid of MMIO_P2V
Date: Mon, 28 Nov 2011 10:53:04 +0000 [thread overview]
Message-ID: <20111128105247.GA2465@localhost.localdomain> (raw)
In-Reply-To: <20111128104416.GD9581-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On Mon, Nov 28, 2011 at 10:44:16AM +0000, Russell King - ARM Linux wrote:
> On Fri, Nov 25, 2011 at 04:15:00PM +0000, Dave Martin wrote:
> > diff --git a/arch/arm/plat-versatile/headsmp.S b/arch/arm/plat-versatile/headsmp.S
> > index d397a1f..0be2efc 100644
> > --- a/arch/arm/plat-versatile/headsmp.S
> > +++ b/arch/arm/plat-versatile/headsmp.S
> > @@ -28,6 +28,7 @@ ENTRY(versatile_secondary_startup)
> > pen: ldr r7, [r6]
> > cmp r7, r0
> > bne pen
> > +ENDPROC(versatile_secondary_startup)
>
> This is wrong. You're telling the assembler that this function ends here.
> It doesn't, it continues on. Put the ENDPROC at the end of the function.
Dunno what I was thinking of there -- agreed, the ENDPROC() should move
to the end of the file.
(I'm assuming that literals should be included in the size of the
relevant function symbol here -- that's the convention the compiler
follows.)
Cheers
---Dave
next prev parent reply other threads:[~2011-11-28 10:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 15:01 [PATCH v2 0/4] Versatile Express DT support Pawel Moll
2011-11-23 15:01 ` Pawel Moll
2011-11-23 15:01 ` [PATCH v2 1/4] ARM: vexpress: Get rid of MMIO_P2V Pawel Moll
2011-11-23 15:01 ` Pawel Moll
2011-11-25 16:15 ` Dave Martin
2011-11-25 16:15 ` Dave Martin
2011-11-28 10:40 ` Pawel Moll
2011-11-28 10:40 ` Pawel Moll
2011-11-28 10:44 ` Russell King - ARM Linux
2011-11-28 10:44 ` Russell King - ARM Linux
2011-11-28 10:53 ` Dave Martin [this message]
2011-11-28 10:53 ` Dave Martin
2011-11-23 15:01 ` [PATCH v2 2/4] ARM: vexpress: Add DT support in v2m Pawel Moll
2011-11-23 15:01 ` Pawel Moll
2011-11-23 16:10 ` Pawel Moll
2011-11-23 16:10 ` Pawel Moll
2011-11-25 16:18 ` Dave Martin
2011-11-25 16:18 ` Dave Martin
2011-11-28 10:54 ` Pawel Moll
2011-11-28 10:54 ` Pawel Moll
2011-11-28 11:38 ` Dave Martin
2011-11-28 11:38 ` Dave Martin
2011-11-23 15:01 ` [PATCH v2 3/4] ARM: vexpress: Initial RS1 memory map support Pawel Moll
2011-11-23 15:01 ` Pawel Moll
2011-11-23 15:01 ` [PATCH v2 4/4] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4 Pawel Moll
2011-11-23 15:01 ` Pawel Moll
2011-11-28 16:29 ` Dave Martin
2011-11-28 16:29 ` Dave Martin
2011-11-28 17:00 ` Pawel Moll
2011-11-28 17:00 ` Pawel Moll
2011-11-28 17:08 ` Dave Martin
2011-11-28 17:08 ` Dave Martin
2011-11-28 14:25 ` [PATCH v2 0/4] Versatile Express DT support Rob Herring
2011-11-28 14:25 ` Rob Herring
2011-11-28 14:42 ` Dave Martin
2011-11-28 14:42 ` Dave Martin
2011-11-28 14:57 ` Dave Martin
2011-11-28 14:57 ` Dave Martin
2011-11-28 15:09 ` Pawel Moll
2011-11-28 15:09 ` Pawel Moll
2011-11-28 15:14 ` Dave Martin
2011-11-28 15:14 ` Dave Martin
2011-11-28 15:20 ` Pawel Moll
2011-11-28 15:20 ` Pawel Moll
2011-11-28 15:39 ` Rob Herring
2011-11-28 15:39 ` Rob Herring
2011-11-28 16:02 ` Pawel Moll
2011-11-28 16:02 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128105247.GA2465@localhost.localdomain \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.