All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Theodore Tso <tytso@MIT.EDU>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	Yu Jian <yujian@whamcloud.com>,
	Andreas Dilger <adilger@whamcloud.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: Sort recursive getfattr output in 062
Date: Mon, 28 Nov 2011 06:03:02 -0500	[thread overview]
Message-ID: <20111128110302.GD13766@infradead.org> (raw)
In-Reply-To: <4ECD28D1.1080800@redhat.com>

On Wed, Nov 23, 2011 at 11:09:37AM -0600, Eric Sandeen wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Test 062 was made "generic" a while back, but it fails on any filesystem
> which returns getfattr -R results (aka readdir results) in something
> other than inode-order.
> 
> With a little awk-fu we can sort the records from getfattr -R so that
> the output is the same for xfs as well as ext4, etc.
> 
> Also filter out lost+found which extN creates at mkfs time, but
> some other filesystems do not.

Looks fine to me, except that I'd put the sorting helper into
common.attr.


Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Andreas Dilger <adilger@whamcloud.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	Theodore Tso <tytso@MIT.EDU>, Yu Jian <yujian@whamcloud.com>,
	xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: Sort recursive getfattr output in 062
Date: Mon, 28 Nov 2011 06:03:02 -0500	[thread overview]
Message-ID: <20111128110302.GD13766@infradead.org> (raw)
In-Reply-To: <4ECD28D1.1080800@redhat.com>

On Wed, Nov 23, 2011 at 11:09:37AM -0600, Eric Sandeen wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Test 062 was made "generic" a while back, but it fails on any filesystem
> which returns getfattr -R results (aka readdir results) in something
> other than inode-order.
> 
> With a little awk-fu we can sort the records from getfattr -R so that
> the output is the same for xfs as well as ext4, etc.
> 
> Also filter out lost+found which extN creates at mkfs time, but
> some other filesystems do not.

Looks fine to me, except that I'd put the sorting helper into
common.attr.


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-11-28 11:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 12:15 ceph and ext4 Martin Mailand
2011-11-14 13:09 ` Tomasz Paszkowski
2011-11-14 13:33   ` Martin Mailand
2011-11-14 19:10     ` Gregory Farnum
2011-11-14 19:40       ` Martin Mailand
     [not found]         ` <CAF3hT9DbnQLJb5YPZJ15ekt5JWZLwyoMymm2x=s9V64kw5qKWQ@mail.gmail.com>
2011-11-14 19:54           ` Fwd: " Gregory Farnum
2011-11-14 20:03       ` Sage Weil
2011-11-14 20:08         ` Martin Mailand
2011-11-14 20:08         ` Gregory Farnum
2011-11-15  8:29 ` Christian Brunner
2011-11-15 14:22   ` Ted Ts'o
2011-11-15 16:43     ` Andreas Dilger
2011-11-15 18:43       ` Yehuda Sadeh Weinraub
2011-11-21 12:22       ` Increase xattr space by allocating contiguous xattr blocks Yu Jian
2011-11-21 15:08         ` Theodore Tso
2011-11-22  3:32           ` Yu Jian
2011-11-22  4:53           ` Eric Sandeen
2011-11-23 17:09             ` [PATCH] xfstests: Sort recursive getfattr output in 062 Eric Sandeen
2011-11-23 17:09               ` Eric Sandeen
2011-11-28 11:03               ` Christoph Hellwig [this message]
2011-11-28 11:03                 ` Christoph Hellwig
2012-01-25 21:38               ` [PATCH V2] " Eric Sandeen
2012-01-25 21:38                 ` Eric Sandeen
2012-01-27 10:53                 ` Christoph Hellwig
2012-01-27 10:53                   ` Christoph Hellwig
2011-12-08 22:59       ` ceph and ext4 Christian Brunner
2011-12-09 22:24         ` Andreas Dilger
2012-02-12  4:05           ` Yehuda Sadeh Weinraub
2012-02-12 17:18             ` Andreas Dilger
2012-02-12 19:50               ` Yehuda Sadeh Weinraub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111128110302.GD13766@infradead.org \
    --to=hch@infradead.org \
    --cc=adilger@whamcloud.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@MIT.EDU \
    --cc=xfs@oss.sgi.com \
    --cc=yujian@whamcloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.