From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: add infrastructure to change routing algorithm at runtime
Date: Mon, 28 Nov 2011 20:00:31 +0100 [thread overview]
Message-ID: <20111128190031.GD13600@lunn.ch> (raw)
In-Reply-To: <1322497717-21268-1-git-send-email-lindner_marek@yahoo.de>
Hi Marek
> +static struct bat_algo *bat_algo_get(char *name)
> +{
> + struct bat_algo *bat_algo = NULL, *bat_algo_tmp;
> + struct hlist_node *node;
> +
> + rcu_read_lock();
> + hlist_for_each_entry_rcu(bat_algo_tmp, node, &bat_algo_list, list) {
> + if (strcmp(bat_algo_tmp->name, name) != 0)
> + continue;
> +
> + bat_algo = bat_algo_tmp;
You should have a try_module_get() here, to stop the module
implementing the algorithm from being unloaded.
Andrew
next prev parent reply other threads:[~2011-11-28 19:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:27 [B.A.T.M.A.N.] [RFC] batman-adv: switch routing algorithm at runtime Marek Lindner
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: add infrastructure to change " Marek Lindner
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: convert batman iv algorithm to use dynamic infrastructure Marek Lindner
2011-11-28 19:02 ` Andrew Lunn
2011-11-28 19:45 ` Marek Lindner
2011-11-29 6:09 ` Andrew Lunn
2011-11-29 6:35 ` Marek Lindner
2011-11-29 8:45 ` Andrew Lunn
2011-11-29 15:23 ` Simon Wunderlich
2011-12-04 20:00 ` Marek Lindner
2011-12-06 19:20 ` Simon Wunderlich
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: allowing changing the routing algorithm via sysfs Marek Lindner
2011-11-28 19:00 ` Andrew Lunn [this message]
2011-11-28 18:47 ` [B.A.T.M.A.N.] [RFC] batman-adv: switch routing algorithm at runtime Andrew Lunn
2011-11-28 19:42 ` Marek Lindner
2011-11-29 6:18 ` Andrew Lunn
2011-11-29 6:34 ` Marek Lindner
2011-11-29 8:02 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2011-12-05 9:56 [B.A.T.M.A.N.] " Marek Lindner
2011-12-05 9:56 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: add infrastructure to change " Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128190031.GD13600@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.