From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: switch routing algorithm at runtime
Date: Tue, 29 Nov 2011 07:18:10 +0100 [thread overview]
Message-ID: <20111129061810.GG13600@lunn.ch> (raw)
In-Reply-To: <201111290342.31065.lindner_marek@yahoo.de>
> All functions are checked right now and all functions can be NULL.
> Check the patch #2 ...
This seems strange. What sort of routing protocol can you build, which
has a NULL receive function? Only static routes. I would perform the
check once in _register(), that there is a receive function, and never
check it again. Save yourself a few cycles.
There is an LWN article about these ideas. Worth a read. I will post a
link later.
Andrew
next prev parent reply other threads:[~2011-11-29 6:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:27 [B.A.T.M.A.N.] [RFC] batman-adv: switch routing algorithm at runtime Marek Lindner
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: add infrastructure to change " Marek Lindner
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: convert batman iv algorithm to use dynamic infrastructure Marek Lindner
2011-11-28 19:02 ` Andrew Lunn
2011-11-28 19:45 ` Marek Lindner
2011-11-29 6:09 ` Andrew Lunn
2011-11-29 6:35 ` Marek Lindner
2011-11-29 8:45 ` Andrew Lunn
2011-11-29 15:23 ` Simon Wunderlich
2011-12-04 20:00 ` Marek Lindner
2011-12-06 19:20 ` Simon Wunderlich
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: allowing changing the routing algorithm via sysfs Marek Lindner
2011-11-28 19:00 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: add infrastructure to change routing algorithm at runtime Andrew Lunn
2011-11-28 18:47 ` [B.A.T.M.A.N.] [RFC] batman-adv: switch " Andrew Lunn
2011-11-28 19:42 ` Marek Lindner
2011-11-29 6:18 ` Andrew Lunn [this message]
2011-11-29 6:34 ` Marek Lindner
2011-11-29 8:02 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129061810.GG13600@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.