From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: drivers@analog.com, alsa-devel@alsa-project.org,
Liam Girdwood <lrg@ti.com>,
device-drivers-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] ASoC: AD193X: Make enum items const char * const
Date: Mon, 28 Nov 2011 19:03:22 +0000 [thread overview]
Message-ID: <20111128190322.GE1586@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4ED3DA92.6050704@metafoo.de>
On Mon, Nov 28, 2011 at 08:01:38PM +0100, Lars-Peter Clausen wrote:
> On 11/28/2011 07:53 PM, Mark Brown wrote:
> > On Mon, Nov 28, 2011 at 05:28:08PM +0100, Lars-Peter Clausen wrote:
> >> -static const char *ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
> >> +static const char * const ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
> > Ideally this would be converted to a switch and the driver would
> > automatically select the rate based on the current sample rate.
> Ideally yes, but I'm not sure if this couldn't break some existing setup if it
> expects to find that control.
Well, it might but I'm not sure anyone actually uses deemphasis any more
anyway.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
drivers@analog.com, device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH 3/7] ASoC: AD193X: Make enum items const char * const
Date: Mon, 28 Nov 2011 19:03:22 +0000 [thread overview]
Message-ID: <20111128190322.GE1586@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4ED3DA92.6050704@metafoo.de>
On Mon, Nov 28, 2011 at 08:01:38PM +0100, Lars-Peter Clausen wrote:
> On 11/28/2011 07:53 PM, Mark Brown wrote:
> > On Mon, Nov 28, 2011 at 05:28:08PM +0100, Lars-Peter Clausen wrote:
> >> -static const char *ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
> >> +static const char * const ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
> > Ideally this would be converted to a switch and the driver would
> > automatically select the rate based on the current sample rate.
> Ideally yes, but I'm not sure if this couldn't break some existing setup if it
> expects to find that control.
Well, it might but I'm not sure anyone actually uses deemphasis any more
anyway.
next prev parent reply other threads:[~2011-11-28 19:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:28 [PATCH 1/7] ASoC: ad193X: Use table based DAPM and controls setup Lars-Peter Clausen
2011-11-28 16:28 ` Lars-Peter Clausen
2011-11-28 16:28 ` [PATCH 2/7] ASoC: ad193X: Provide dB ranges for the volume controls Lars-Peter Clausen
2011-11-28 16:28 ` Lars-Peter Clausen
2011-11-28 16:28 ` [PATCH 3/7] ASoC: AD193X: Make enum items const char * const Lars-Peter Clausen
2011-11-28 16:28 ` Lars-Peter Clausen
2011-11-28 18:53 ` Mark Brown
2011-11-28 18:53 ` Mark Brown
2011-11-28 19:01 ` Lars-Peter Clausen
2011-11-28 19:01 ` Lars-Peter Clausen
2011-11-28 19:03 ` Mark Brown [this message]
2011-11-28 19:03 ` Mark Brown
2011-11-28 16:28 ` [PATCH 4/7] ASoC: ad193X: Remove non-functional DAPM route controls Lars-Peter Clausen
2011-11-28 16:28 ` Lars-Peter Clausen
2011-11-28 16:28 ` [PATCH 5/7] ASOC: AD193X: Add sysclk DAPM supply Lars-Peter Clausen
2011-11-28 16:28 ` Lars-Peter Clausen
2011-11-29 5:24 ` Mike Frysinger
2011-11-29 11:34 ` Mark Brown
2011-11-29 11:34 ` Mark Brown
2011-11-30 5:42 ` Mike Frysinger
2011-11-30 5:42 ` Mike Frysinger
2011-11-28 16:28 ` [PATCH 6/7] ASoC: AD193X: Use snd_soc_update_bits where appropriate Lars-Peter Clausen
2011-11-28 16:28 ` Lars-Peter Clausen
2011-11-28 16:28 ` [PATCH 7/7] ASoC: AD193X: Convert to direct regmap API usage Lars-Peter Clausen
2011-11-28 16:28 ` Lars-Peter Clausen
2011-11-28 18:57 ` [PATCH 1/7] ASoC: ad193X: Use table based DAPM and controls setup Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128190322.GE1586@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.