* [PATCH] ASoC: Staticise and constify cs42l73_reg_defaults
@ 2011-11-22 15:14 Mark Brown
2011-11-28 21:26 ` Brian Austin
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-11-22 15:14 UTC (permalink / raw)
To: Brian Austin, Liam Girdwood; +Cc: alsa-devel, Mark Brown
It's not exported and doesn't need to change.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/cs42l73.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index 5544f14..2b294a9 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -42,7 +42,7 @@ struct cs42l73_private {
u32 mclk;
};
-struct reg_default cs42l73_reg_defaults[] = {
+static const struct reg_default cs42l73_reg_defaults[] = {
{ 1, 0x42 }, /* r01 - Device ID A&B */
{ 2, 0xA7 }, /* r02 - Device ID C&D */
{ 3, 0x30 }, /* r03 - Device ID E */
--
1.7.7.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Staticise and constify cs42l73_reg_defaults
2011-11-22 15:14 [PATCH] ASoC: Staticise and constify cs42l73_reg_defaults Mark Brown
@ 2011-11-28 21:26 ` Brian Austin
2011-11-28 21:30 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Brian Austin @ 2011-11-28 21:26 UTC (permalink / raw)
To: Mark Brown; +Cc: Brian Austin, Liam Girdwood, alsa-devel
> -struct reg_default cs42l73_reg_defaults[] = {
> +static const struct reg_default cs42l73_reg_defaults[] = {
> { 1, 0x42 }, /* r01 - Device ID A&B */
> { 2, 0xA7 }, /* r02 - Device ID C&D */
> { 3, 0x30 }, /* r03 - Device ID E */
Shouldn't this require struct reg_default *reg_defaults;
be const as well?
sound/soc/codecs/cs42l73.c:1327: warning: initialization discards
qualifiers from pointer target type
Or not use const?
-Brian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Staticise and constify cs42l73_reg_defaults
2011-11-28 21:26 ` Brian Austin
@ 2011-11-28 21:30 ` Mark Brown
2011-11-28 21:44 ` Brian Austin
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-11-28 21:30 UTC (permalink / raw)
To: Brian Austin; +Cc: alsa-devel, Liam Girdwood
On Mon, Nov 28, 2011 at 03:26:53PM -0600, Brian Austin wrote:
> Shouldn't this require struct reg_default *reg_defaults;
> be const as well?
> sound/soc/codecs/cs42l73.c:1327: warning: initialization discards
> qualifiers from pointer target type
It'll all be fine in -next, the regmap header has changed there.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Staticise and constify cs42l73_reg_defaults
2011-11-28 21:30 ` Mark Brown
@ 2011-11-28 21:44 ` Brian Austin
0 siblings, 0 replies; 4+ messages in thread
From: Brian Austin @ 2011-11-28 21:44 UTC (permalink / raw)
To: Mark Brown; +Cc: Brian Austin, Liam Girdwood, alsa-devel
>
> It'll all be fine in -next, the regmap header has changed there.
>
>
OK
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-28 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 15:14 [PATCH] ASoC: Staticise and constify cs42l73_reg_defaults Mark Brown
2011-11-28 21:26 ` Brian Austin
2011-11-28 21:30 ` Mark Brown
2011-11-28 21:44 ` Brian Austin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.