* [PATCH RESEND] ASoC: cs42l73: Fix clear wrong bits in cs42l73_set_dai_fmt
@ 2011-11-29 11:47 Axel Lin
2011-11-29 11:51 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-11-29 11:47 UTC (permalink / raw)
To: alsa-devel; +Cc: Brian Austin, Mark Brown, Liam Girdwood
What we want is to clear BIT[5:4](PCM_MODE_MASK) and BIT[3](PCM_BIT_ORDER) bits,
but current code clears BIT[2:0].
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Brian Austin <brian.austin@cirrus.com>
---
This patch was sent on http://comments.gmane.org/gmane.linux.alsa.devel/91501
and Brian replied "tested and acked" for both patches.
[PATCH 1/2] ASoC: cs42l73: Unify the way to define bits of register is already merged,
but [PATCH 2/2] ASoC: cs42l73: Fix clear wrong bits in cs42l73_set_dai_fmt is missed.
sound/soc/codecs/cs42l73.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index 0306e72..a2af595 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -1024,7 +1024,8 @@ static int cs42l73_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
}
if (spc & SPDIF_PCM) {
- spc &= (31 << 3); /* Clear PCM mode, set MSB->LSB */
+ /* Clear PCM mode, clear PCM_BIT_ORDER bit for MSB->LSB */
+ spc &= ~(PCM_MODE_MASK | PCM_BIT_ORDER);
switch (format) {
case SND_SOC_DAIFMT_DSP_B:
if (inv == SND_SOC_DAIFMT_IB_IF)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] ASoC: cs42l73: Fix clear wrong bits in cs42l73_set_dai_fmt
2011-11-29 11:47 [PATCH RESEND] ASoC: cs42l73: Fix clear wrong bits in cs42l73_set_dai_fmt Axel Lin
@ 2011-11-29 11:51 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2011-11-29 11:51 UTC (permalink / raw)
To: Axel Lin; +Cc: Brian Austin, alsa-devel, Liam Girdwood
On Tue, Nov 29, 2011 at 07:47:38PM +0800, Axel Lin wrote:
> What we want is to clear BIT[5:4](PCM_MODE_MASK) and BIT[3](PCM_BIT_ORDER) bits,
> but current code clears BIT[2:0].
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-29 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-29 11:47 [PATCH RESEND] ASoC: cs42l73: Fix clear wrong bits in cs42l73_set_dai_fmt Axel Lin
2011-11-29 11:51 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.