All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [RFC] virtio: use mandatory barriers for remote processor vdevs
Date: Tue, 29 Nov 2011 17:16:07 +0200	[thread overview]
Message-ID: <20111129151607.GE30966@redhat.com> (raw)
In-Reply-To: <CAK=WgbZoGYVyKt=XXvnPVdh0koSBJC0zcgkLaYRkmjwBLOFA-A@mail.gmail.com>

On Tue, Nov 29, 2011 at 03:57:19PM +0200, Ohad Ben-Cohen wrote:
> On Tue, Nov 29, 2011 at 3:11 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Nov 29, 2011 at 02:31:26PM +0200, Ohad Ben-Cohen wrote:
> >> Virtio is using memory barriers to control the ordering of
> >> references to the vrings on SMP systems. When the guest is compiled
> >> with SMP support, virtio is only using SMP barriers in order to
> >> avoid incurring the overhead involved with mandatory barriers.
> >>
> >> Lately, though, virtio is being increasingly used with inter-processor
> >> communication scenarios too, which involve running two (separate)
> >> instances of operating systems on two (separate) processors, each of
> >> which might either be UP or SMP.
> >
> > Is that using virtio-mmio?
> 
> No, I'm using this:
> 
> https://lkml.org/lkml/2011/10/25/139

This mentions iommu - is there a need to use dma api to let
the firmware acess the rings? Or does it have access to all
of memory?

> > Sorry, could you pls explain what are 'two external processors'?
> > I think I know that if two x86 CPUs in an SMP system run kernels built
> > in an SMP configuration, smp_*mb barriers are enough.
> 
> Sure:
> 
> My setup is not SMP-based; it's two separate processors running in AMP
> configuration. The processors have completely different architectures,
> are not cache coherent, and only simply share some memory, which is
> used for communications using virtio as the shared memory "wire"
> protocol (i.e. we're not even doing virtualization: we have Linux on
> one processor, and some RTOS on another processor, and they use virtio
> to send and receive buffers).

I'd like to make sure I understand the memory model some more.
Is there cache snooping? If yes access from an external device
typically works mostly in the same way as smp ...


> So it's not SMP effects we're controlling; we're pretty much doing
> MMIO and must use mandatory barriers

So you put virtio rings in MMIO memory?

> (otherwise we see breakage).

Could you please give a couple of examples of breakage?

-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: mst@redhat.com (Michael S. Tsirkin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] virtio: use mandatory barriers for remote processor vdevs
Date: Tue, 29 Nov 2011 17:16:07 +0200	[thread overview]
Message-ID: <20111129151607.GE30966@redhat.com> (raw)
In-Reply-To: <CAK=WgbZoGYVyKt=XXvnPVdh0koSBJC0zcgkLaYRkmjwBLOFA-A@mail.gmail.com>

On Tue, Nov 29, 2011 at 03:57:19PM +0200, Ohad Ben-Cohen wrote:
> On Tue, Nov 29, 2011 at 3:11 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Nov 29, 2011 at 02:31:26PM +0200, Ohad Ben-Cohen wrote:
> >> Virtio is using memory barriers to control the ordering of
> >> references to the vrings on SMP systems. When the guest is compiled
> >> with SMP support, virtio is only using SMP barriers in order to
> >> avoid incurring the overhead involved with mandatory barriers.
> >>
> >> Lately, though, virtio is being increasingly used with inter-processor
> >> communication scenarios too, which involve running two (separate)
> >> instances of operating systems on two (separate) processors, each of
> >> which might either be UP or SMP.
> >
> > Is that using virtio-mmio?
> 
> No, I'm using this:
> 
> https://lkml.org/lkml/2011/10/25/139

This mentions iommu - is there a need to use dma api to let
the firmware acess the rings? Or does it have access to all
of memory?

> > Sorry, could you pls explain what are 'two external processors'?
> > I think I know that if two x86 CPUs in an SMP system run kernels built
> > in an SMP configuration, smp_*mb barriers are enough.
> 
> Sure:
> 
> My setup is not SMP-based; it's two separate processors running in AMP
> configuration. The processors have completely different architectures,
> are not cache coherent, and only simply share some memory, which is
> used for communications using virtio as the shared memory "wire"
> protocol (i.e. we're not even doing virtualization: we have Linux on
> one processor, and some RTOS on another processor, and they use virtio
> to send and receive buffers).

I'd like to make sure I understand the memory model some more.
Is there cache snooping? If yes access from an external device
typically works mostly in the same way as smp ...


> So it's not SMP effects we're controlling; we're pretty much doing
> MMIO and must use mandatory barriers

So you put virtio rings in MMIO memory?

> (otherwise we see breakage).

Could you please give a couple of examples of breakage?

-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [RFC] virtio: use mandatory barriers for remote processor vdevs
Date: Tue, 29 Nov 2011 17:16:07 +0200	[thread overview]
Message-ID: <20111129151607.GE30966@redhat.com> (raw)
In-Reply-To: <CAK=WgbZoGYVyKt=XXvnPVdh0koSBJC0zcgkLaYRkmjwBLOFA-A@mail.gmail.com>

On Tue, Nov 29, 2011 at 03:57:19PM +0200, Ohad Ben-Cohen wrote:
> On Tue, Nov 29, 2011 at 3:11 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Nov 29, 2011 at 02:31:26PM +0200, Ohad Ben-Cohen wrote:
> >> Virtio is using memory barriers to control the ordering of
> >> references to the vrings on SMP systems. When the guest is compiled
> >> with SMP support, virtio is only using SMP barriers in order to
> >> avoid incurring the overhead involved with mandatory barriers.
> >>
> >> Lately, though, virtio is being increasingly used with inter-processor
> >> communication scenarios too, which involve running two (separate)
> >> instances of operating systems on two (separate) processors, each of
> >> which might either be UP or SMP.
> >
> > Is that using virtio-mmio?
> 
> No, I'm using this:
> 
> https://lkml.org/lkml/2011/10/25/139

This mentions iommu - is there a need to use dma api to let
the firmware acess the rings? Or does it have access to all
of memory?

> > Sorry, could you pls explain what are 'two external processors'?
> > I think I know that if two x86 CPUs in an SMP system run kernels built
> > in an SMP configuration, smp_*mb barriers are enough.
> 
> Sure:
> 
> My setup is not SMP-based; it's two separate processors running in AMP
> configuration. The processors have completely different architectures,
> are not cache coherent, and only simply share some memory, which is
> used for communications using virtio as the shared memory "wire"
> protocol (i.e. we're not even doing virtualization: we have Linux on
> one processor, and some RTOS on another processor, and they use virtio
> to send and receive buffers).

I'd like to make sure I understand the memory model some more.
Is there cache snooping? If yes access from an external device
typically works mostly in the same way as smp ...


> So it's not SMP effects we're controlling; we're pretty much doing
> MMIO and must use mandatory barriers

So you put virtio rings in MMIO memory?

> (otherwise we see breakage).

Could you please give a couple of examples of breakage?

-- 
MST

  reply	other threads:[~2011-11-29 15:16 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 12:31 [RFC] virtio: use mandatory barriers for remote processor vdevs Ohad Ben-Cohen
2011-11-29 12:31 ` Ohad Ben-Cohen
2011-11-29 13:11 ` Michael S. Tsirkin
2011-11-29 13:11   ` Michael S. Tsirkin
2011-11-29 13:11   ` Michael S. Tsirkin
2011-11-29 13:57   ` Ohad Ben-Cohen
2011-11-29 13:57     ` Ohad Ben-Cohen
2011-11-29 13:57     ` Ohad Ben-Cohen
2011-11-29 15:16     ` Michael S. Tsirkin [this message]
2011-11-29 15:16       ` Michael S. Tsirkin
2011-11-29 15:16       ` Michael S. Tsirkin
2011-11-30 11:45       ` Ohad Ben-Cohen
2011-11-30 11:45         ` Ohad Ben-Cohen
2011-11-30 11:45         ` Ohad Ben-Cohen
2011-11-30 14:59         ` Michael S. Tsirkin
2011-11-30 14:59           ` Michael S. Tsirkin
2011-11-30 14:59           ` Michael S. Tsirkin
2011-11-30 16:04           ` Ohad Ben-Cohen
2011-11-30 16:04           ` Ohad Ben-Cohen
2011-11-30 16:04             ` Ohad Ben-Cohen
2011-11-30 16:15             ` Michael S. Tsirkin
2011-11-30 16:15               ` Michael S. Tsirkin
2011-11-30 16:15               ` Michael S. Tsirkin
2011-11-30 16:24               ` Ohad Ben-Cohen
2011-11-30 16:24                 ` Ohad Ben-Cohen
2011-11-30 16:24                 ` Ohad Ben-Cohen
2011-11-30 23:27                 ` Ohad Ben-Cohen
2011-11-30 23:27                   ` Ohad Ben-Cohen
2011-11-30 23:27                   ` Ohad Ben-Cohen
2011-11-30 23:43                   ` Michael S. Tsirkin
2011-11-30 23:43                     ` Michael S. Tsirkin
2011-11-30 23:43                     ` Michael S. Tsirkin
2011-12-01  6:20                     ` Ohad Ben-Cohen
2011-12-01  6:20                       ` Ohad Ben-Cohen
2011-12-01  6:20                       ` Ohad Ben-Cohen
2011-11-29 15:19     ` Michael S. Tsirkin
2011-11-29 15:19       ` Michael S. Tsirkin
2011-11-29 15:19       ` Michael S. Tsirkin
2011-11-30 11:55       ` Ohad Ben-Cohen
2011-11-30 11:55         ` Ohad Ben-Cohen
2011-11-30 11:55         ` Ohad Ben-Cohen
2011-11-30 14:50         ` Michael S. Tsirkin
2011-11-30 14:50           ` Michael S. Tsirkin
2011-11-30 14:50           ` Michael S. Tsirkin
2011-11-30 22:43           ` Ohad Ben-Cohen
2011-11-30 22:43             ` Ohad Ben-Cohen
2011-11-30 22:43             ` Ohad Ben-Cohen
2011-11-30 23:13             ` Michael S. Tsirkin
2011-11-30 23:13               ` Michael S. Tsirkin
2011-11-30 23:13               ` Michael S. Tsirkin
2011-12-01  2:28               ` Rusty Russell
2011-12-01  2:28                 ` Rusty Russell
2011-12-01  2:28                 ` Rusty Russell
2011-12-01  7:15                 ` Ohad Ben-Cohen
2011-12-01  7:15                   ` Ohad Ben-Cohen
2011-12-01  7:15                   ` Ohad Ben-Cohen
2011-12-01  8:12                 ` Michael S. Tsirkin
2011-12-01  8:12                   ` Michael S. Tsirkin
2011-12-01  8:12                   ` Michael S. Tsirkin
2011-12-02  0:26                   ` Rusty Russell
2011-12-02  0:26                     ` Rusty Russell
2011-12-02  0:26                     ` Rusty Russell
2011-12-01  6:14               ` Ohad Ben-Cohen
2011-12-01  6:14                 ` Ohad Ben-Cohen
2011-12-01  6:14                 ` Ohad Ben-Cohen
2011-12-01  9:09                 ` Michael S. Tsirkin
2011-12-01  9:09                   ` Michael S. Tsirkin
2011-12-01  9:09                   ` Michael S. Tsirkin
2011-12-02 23:09 ` Benjamin Herrenschmidt
2011-12-02 23:09   ` Benjamin Herrenschmidt
2011-12-02 23:09   ` Benjamin Herrenschmidt
2011-12-03  5:14   ` Rusty Russell
2011-12-03  5:14     ` Rusty Russell
2011-12-03  5:14     ` Rusty Russell
2011-12-11 12:25     ` Michael S. Tsirkin
2011-12-11 12:25       ` Michael S. Tsirkin
2011-12-11 12:25       ` Michael S. Tsirkin
2011-12-11 22:27       ` Benjamin Herrenschmidt
2011-12-11 22:27         ` Benjamin Herrenschmidt
2011-12-11 22:27         ` Benjamin Herrenschmidt
2011-12-12  3:06         ` Amos Kong
2011-12-12  3:06           ` Amos Kong
2011-12-12  3:06           ` Amos Kong
2011-12-12  5:12           ` Rusty Russell
2011-12-12  5:12             ` Rusty Russell
2011-12-12  5:12             ` Rusty Russell
2011-12-12 23:56             ` Amos Kong
2011-12-12 23:56               ` Amos Kong
2011-12-12 23:56               ` Amos Kong
2011-12-19  2:35               ` Rusty Russell
2011-12-19  2:35                 ` Rusty Russell
2011-12-19  2:35                 ` Rusty Russell
2011-12-19  2:19             ` Amos Kong
2011-12-19  2:19               ` Amos Kong
2011-12-19  2:19               ` Amos Kong
2011-12-19  2:41               ` Benjamin Herrenschmidt
2011-12-19  2:41                 ` Benjamin Herrenschmidt
2011-12-19  2:41                 ` Benjamin Herrenschmidt
2011-12-19  7:21                 ` Amos Kong
2011-12-19  7:21                   ` Amos Kong
2011-12-19  7:21                   ` Amos Kong
2011-12-19  2:50               ` Amos Kong
2011-12-19  2:50                 ` Amos Kong
2011-12-19  2:50                 ` Amos Kong
2011-12-19  8:37                 ` Rusty Russell
2011-12-19  8:37                   ` Rusty Russell
2011-12-19  8:37                   ` Rusty Russell
2011-12-03  6:01   ` Ohad Ben-Cohen
2011-12-03  6:01     ` Ohad Ben-Cohen
2011-12-03  6:01     ` Ohad Ben-Cohen
  -- strict thread matches above, loose matches on Subject: below --
2011-11-29 12:31 Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111129151607.GE30966@redhat.com \
    --to=mst@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.