From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Avoid using mappable space for relocation processing through the CPU
Date: Tue, 29 Nov 2011 16:34:41 +0100 [thread overview]
Message-ID: <20111129153441.GC5667@phenom.ffwll.local> (raw)
In-Reply-To: <1322579560-15548-1-git-send-email-chris@chris-wilson.co.uk>
On Tue, Nov 29, 2011 at 03:12:40PM +0000, Chris Wilson wrote:
> We try to avoid writing the relocations through the uncached GTT, if the
> buffer is currently in the CPU write domain and so will be flushed out to
> main memory afterwards anyway. Also on SandyBridge we can safely write
> to the pages in cacheable memory, so long as the buffer is LLC mapped.
> In either of these caches, we therefore do not need to force the
> reallocation of the buffer into the mappable region of the GTT, reducing
> the aperture pressure.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
The error_state capture currently relies on us pinning buffers as mappable
when they contain relocations (and userspace always submitting a
batchbuffers containing relocations). You break that guarantee without
fixing up the error capture code. Otherwise I like this.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-11-29 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 15:12 [PATCH] drm/i915: Avoid using mappable space for relocation processing through the CPU Chris Wilson
2011-11-29 15:34 ` Daniel Vetter [this message]
2011-11-29 16:48 ` Chris Wilson
2011-11-29 17:03 ` Daniel Vetter
2011-11-29 17:15 ` Chris Wilson
2011-11-29 17:17 ` Daniel Vetter
2011-11-29 17:21 ` Daniel Vetter
2011-11-29 19:22 ` Daniel Vetter
2011-11-29 21:32 ` Ben Widawsky
[not found] <id:1322579560-15548-1-git-send-email-chris@chris-wilson.co.uk>
2011-12-04 12:26 ` Chris Wilson
2011-12-05 10:41 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2012-03-26 8:10 Daniel Vetter
2012-03-26 8:32 ` Chris Wilson
2012-03-27 11:17 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129153441.GC5667@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.