From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] ARM: vexpress: Get rid of MMIO_P2V
Date: Wed, 30 Nov 2011 13:48:54 +0000 [thread overview]
Message-ID: <201111301348.54350.arnd@arndb.de> (raw)
In-Reply-To: <1322652891.3164.144.camel@hornet.cambridge.arm.com>
On Wednesday 30 November 2011, Pawel Moll wrote:
> > and so on. This ends up being more readable IMHO because it
> > means you don't have to know what the macro does.
>
> I wouldn't mind that, it's just that the V2M_PERIPH is also used in the
> map_desc:
>
> static struct map_desc v2m_io_desc[] __initdata = {
> {
> .virtual = V2M_PERIPH,
>
> and as the .virtual is unsigned long I'd need a cast in one place or the
> other.
I have patches for other platforms to do the same conversion and
add the cast here, but also plan to change the way that I/O mappings
are done in the long run, you have to specify the virtual address
as __iomem* instead of an integer anyway.
> My best hope is that once Nico's "ioremap optimization" is pulled
> (http://thread.gmane.org/gmane.linux.ports.arm.kernel/140974), I'll be
> able to replace the _P2V macros with ioremap()s.
Yes.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v3 2/5] ARM: vexpress: Get rid of MMIO_P2V
Date: Wed, 30 Nov 2011 13:48:54 +0000 [thread overview]
Message-ID: <201111301348.54350.arnd@arndb.de> (raw)
In-Reply-To: <1322652891.3164.144.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>
On Wednesday 30 November 2011, Pawel Moll wrote:
> > and so on. This ends up being more readable IMHO because it
> > means you don't have to know what the macro does.
>
> I wouldn't mind that, it's just that the V2M_PERIPH is also used in the
> map_desc:
>
> static struct map_desc v2m_io_desc[] __initdata = {
> {
> .virtual = V2M_PERIPH,
>
> and as the .virtual is unsigned long I'd need a cast in one place or the
> other.
I have patches for other platforms to do the same conversion and
add the cast here, but also plan to change the way that I/O mappings
are done in the long run, you have to specify the virtual address
as __iomem* instead of an integer anyway.
> My best hope is that once Nico's "ioremap optimization" is pulled
> (http://thread.gmane.org/gmane.linux.ports.arm.kernel/140974), I'll be
> able to replace the _P2V macros with ioremap()s.
Yes.
Arnd
next prev parent reply other threads:[~2011-11-30 13:48 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 15:11 [PATCH v3 0/5] Versatile Express DT support Pawel Moll
2011-11-29 15:11 ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 1/5] ARM: versatile: Add missing ENDPROC to headsmp.S Pawel Moll
2011-11-29 15:11 ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 2/5] ARM: vexpress: Get rid of MMIO_P2V Pawel Moll
2011-11-29 15:11 ` Pawel Moll
2011-11-29 21:15 ` Arnd Bergmann
2011-11-29 21:15 ` Arnd Bergmann
2011-11-30 11:34 ` Pawel Moll
2011-11-30 11:34 ` Pawel Moll
2011-11-30 13:48 ` Arnd Bergmann [this message]
2011-11-30 13:48 ` Arnd Bergmann
2011-11-30 13:52 ` Pawel Moll
2011-11-30 13:52 ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 3/5] ARM: vexpress: Add DT support in v2m Pawel Moll
2011-11-29 15:11 ` Pawel Moll
2011-11-29 21:19 ` Arnd Bergmann
2011-11-29 21:19 ` Arnd Bergmann
2011-11-30 11:46 ` Pawel Moll
2011-11-30 11:46 ` Pawel Moll
2011-11-30 13:34 ` Arnd Bergmann
2011-11-30 13:34 ` Arnd Bergmann
2011-11-30 13:38 ` Pawel Moll
2011-11-30 13:38 ` Pawel Moll
2011-11-30 15:10 ` Arnd Bergmann
2011-11-30 15:10 ` Arnd Bergmann
2011-11-30 15:58 ` Dave Martin
2011-11-30 15:58 ` Dave Martin
2011-11-30 18:46 ` Pawel Moll
2011-11-30 18:46 ` Pawel Moll
2011-12-01 10:57 ` Dave Martin
2011-12-01 10:57 ` Dave Martin
2011-12-05 16:25 ` Dave Martin
2011-12-05 16:25 ` Dave Martin
2011-12-05 16:30 ` Pawel Moll
2011-12-05 16:30 ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support Pawel Moll
2011-11-29 15:11 ` Pawel Moll
2011-11-30 15:37 ` Dave Martin
2011-11-30 15:37 ` Dave Martin
2011-11-30 17:15 ` Pawel Moll
2011-11-30 17:15 ` Pawel Moll
2011-11-30 17:54 ` Dave Martin
2011-11-30 17:54 ` Dave Martin
2011-11-30 18:31 ` Pawel Moll
2011-11-30 18:31 ` Pawel Moll
2011-11-30 20:43 ` Nicolas Pitre
2011-11-30 20:43 ` Nicolas Pitre
2011-11-30 20:48 ` Mark Brown
2011-11-30 20:48 ` Mark Brown
2011-11-30 21:21 ` Stephen Warren
2011-11-30 21:21 ` Stephen Warren
2011-11-30 21:38 ` Nicolas Pitre
2011-11-30 21:38 ` Nicolas Pitre
2011-11-30 21:50 ` Russell King - ARM Linux
2011-11-30 21:50 ` Russell King - ARM Linux
2011-12-01 3:36 ` Nicolas Pitre
2011-12-01 3:36 ` Nicolas Pitre
2011-12-01 11:10 ` Mark Brown
2011-12-01 11:10 ` Mark Brown
2011-12-01 12:14 ` Dave Martin
2011-12-01 12:14 ` Dave Martin
2011-12-01 16:19 ` Stephen Warren
2011-12-01 16:19 ` Stephen Warren
2011-12-02 17:41 ` Stephen Warren
2011-12-02 17:41 ` Stephen Warren
2011-12-02 19:06 ` Marek Vasut
2011-12-02 19:06 ` Marek Vasut
2011-12-02 19:28 ` Dave Martin
2011-12-02 19:28 ` Dave Martin
2011-12-02 22:52 ` Nicolas Pitre
2011-12-02 22:52 ` Nicolas Pitre
2011-12-02 23:03 ` Marek Vasut
2011-12-02 23:03 ` Marek Vasut
2011-12-01 18:37 ` Russell King - ARM Linux
2011-12-01 18:37 ` Russell King - ARM Linux
2011-11-29 15:11 ` [PATCH v3 5/5] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4 Pawel Moll
2011-11-29 15:11 ` Pawel Moll
2011-11-29 16:40 ` Dave Martin
2011-11-29 16:40 ` Dave Martin
2011-11-30 18:39 ` Pawel Moll
2011-11-30 18:39 ` Pawel Moll
2011-12-01 12:21 ` Dave Martin
2011-12-01 12:21 ` Dave Martin
2011-12-05 17:24 ` Pawel Moll
2011-12-05 17:24 ` Pawel Moll
2011-12-05 17:37 ` Dave Martin
2011-12-05 17:37 ` Dave Martin
2011-12-05 17:47 ` Pawel Moll
2011-12-05 17:47 ` Pawel Moll
2011-12-05 18:06 ` Dave Martin
2011-12-05 18:06 ` Dave Martin
2011-11-29 17:00 ` [PATCH v3 0/5] Versatile Express DT support Dave Martin
2011-11-29 17:00 ` Dave Martin
2011-11-29 17:16 ` Pawel Moll
2011-11-29 17:16 ` Pawel Moll
2011-11-30 10:48 ` Dave Martin
2011-11-30 10:48 ` Dave Martin
2011-11-30 11:14 ` Pawel Moll
2011-11-30 11:14 ` Pawel Moll
2011-11-30 12:08 ` Dave Martin
2011-11-30 12:08 ` Dave Martin
2011-11-30 12:15 ` Pawel Moll
2011-11-30 12:15 ` Pawel Moll
2011-11-29 21:24 ` Arnd Bergmann
2011-11-29 21:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111301348.54350.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.