From: Arnd Bergmann <arnd@arndb.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Paul Mundt <lethal@linux-sh.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH-RFC 1/2] tile: don't panic on iomap
Date: Wed, 30 Nov 2011 14:04:41 +0000 [thread overview]
Message-ID: <201111301404.41544.arnd@arndb.de> (raw)
In-Reply-To: <20111130115956.GA21413@redhat.com>
On Wednesday 30 November 2011, Michael S. Tsirkin wrote:
> > > Presumably whoever wrote that architecture considered and discarded setting GENERIC_IOMAP.
> >
> > The tile PCI controller is apparently special in that it does not map the
> > PIO region into MMIO space, or make it available in any other way, so generic
> > iomap with IOCOND is pointless. Setting NO_IPORT will still mean that drivers
> > using ioport_map will not be built. This mostly impacts the legacy (non-AHCI)
> > ATA controllers, which I assume are not used on tile anyway.
>
> I don't object to setting NO_IPORT at all, but this won't help address
> the problem this patch is fixing, which is to use a generic pci_iomap
> on tile.
Ah, right. I didn't realize that the generic pci_iomap still attempts
to call ioport_map(). It would probably make sense to enclose
the ioport_map() call in pci_iomap() inside of #ifdef CONFIG_HAS_IOPORT.
It's not exactly beautiful, but probably the most correct solution
so that we can make any call to ioport_map() a build-time error on
architectures that set CONFIG_NO_IOPORT.
Arnd
next prev parent reply other threads:[~2011-11-30 14:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 18:54 [PATCH-RFC 0/2] tile: switch to generic pci_iomap Michael S. Tsirkin
2011-11-29 18:54 ` Michael S. Tsirkin
2011-11-29 18:54 ` [PATCH-RFC 1/2] tile: don't panic on iomap Michael S. Tsirkin
2011-11-29 18:54 ` Michael S. Tsirkin
2011-11-29 21:04 ` Bjorn Helgaas
2011-11-30 7:04 ` Michael S. Tsirkin
2011-11-29 22:05 ` Arnd Bergmann
2011-11-30 7:13 ` Michael S. Tsirkin
2011-11-30 9:09 ` Arnd Bergmann
2011-11-30 11:59 ` Michael S. Tsirkin
2011-11-30 14:04 ` Arnd Bergmann [this message]
2011-11-30 14:31 ` Michael S. Tsirkin
2011-11-30 15:49 ` Arnd Bergmann
2011-11-30 15:59 ` Michael S. Tsirkin
2011-11-30 18:32 ` Arnd Bergmann
2011-12-01 17:59 ` [PATCH] lib/devres.c: allow specifying NO_IOPORT while using PCI Chris Metcalf
2011-12-01 17:59 ` Chris Metcalf
2011-12-01 18:44 ` Tejun Heo
2011-12-01 18:48 ` Chris Metcalf
2011-12-01 18:48 ` Chris Metcalf
2011-12-01 22:47 ` Arnd Bergmann
2011-12-02 18:48 ` Chris Metcalf
2011-12-02 18:48 ` Chris Metcalf
2011-12-05 15:14 ` Arnd Bergmann
2011-12-05 20:08 ` Chris Metcalf
2011-12-05 20:08 ` Chris Metcalf
2011-11-30 9:08 ` [PATCH-RFC 1/2 v2] tile: don't panic on iomap Michael S. Tsirkin
2011-11-29 18:54 ` [PATCH-RFC 2/2] tile: switch to GENERIC_PCI_IOMAP Michael S. Tsirkin
2011-11-29 18:54 ` Michael S. Tsirkin
2011-11-30 21:19 ` Chris Metcalf
2011-11-30 21:19 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111301404.41544.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.