From: Andrew Morton <akpm@linux-foundation.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Xi Wang <xi.wang@gmail.com>, Mel Gorman <mgorman@suse.de>,
Minchan Kim <minchan.kim@gmail.com>,
Johannes Weiner <jweiner@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: incorrect overflow check in shrink_slab()
Date: Thu, 1 Dec 2011 12:54:57 -0800 [thread overview]
Message-ID: <20111201125457.fdf79489.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111201183202.2e5bd872.kamezawa.hiroyu@jp.fujitsu.com>
On Thu, 1 Dec 2011 18:32:02 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > total_scan is unsigned long, so the overflow check (total_scan < 0)
> > didn't work.
> >
> > Signed-off-by: Xi Wang <xi.wang@gmail.com>
>
> Nice catch but.... the 'total_scan" shouldn't be long ?
> Rather than type casting ?
Konstantin Khlebnikov's "vmscan: fix initial shrinker size handling"
does change it to `long'. That patch is in -mm and linux-next and is
queued for 3.3. It was queued for 3.2 but didn't make it due to some
me/Dave Chinner confusion.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Xi Wang <xi.wang@gmail.com>, Mel Gorman <mgorman@suse.de>,
Minchan Kim <minchan.kim@gmail.com>,
Johannes Weiner <jweiner@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: incorrect overflow check in shrink_slab()
Date: Thu, 1 Dec 2011 12:54:57 -0800 [thread overview]
Message-ID: <20111201125457.fdf79489.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111201183202.2e5bd872.kamezawa.hiroyu@jp.fujitsu.com>
On Thu, 1 Dec 2011 18:32:02 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > total_scan is unsigned long, so the overflow check (total_scan < 0)
> > didn't work.
> >
> > Signed-off-by: Xi Wang <xi.wang@gmail.com>
>
> Nice catch but.... the 'total_scan" shouldn't be long ?
> Rather than type casting ?
Konstantin Khlebnikov's "vmscan: fix initial shrinker size handling"
does change it to `long'. That patch is in -mm and linux-next and is
queued for 3.3. It was queued for 3.2 but didn't make it due to some
me/Dave Chinner confusion.
next prev parent reply other threads:[~2011-12-01 20:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 9:20 [PATCH] mm: incorrect overflow check in shrink_slab() Xi Wang
2011-12-01 9:20 ` Xi Wang
2011-12-01 9:32 ` KAMEZAWA Hiroyuki
2011-12-01 9:32 ` KAMEZAWA Hiroyuki
2011-12-01 9:57 ` Xi Wang
2011-12-01 9:57 ` Xi Wang
2011-12-01 20:54 ` Andrew Morton [this message]
2011-12-01 20:54 ` Andrew Morton
2011-12-02 2:00 ` Xi Wang
2011-12-02 2:00 ` Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201125457.fdf79489.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.