From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] nohz: Remove update_ts_time_stat from tick_nohz_start_idle
Date: Fri, 2 Dec 2011 15:27:56 +0530 [thread overview]
Message-ID: <20111202095756.GB15975@linux.vnet.ibm.com> (raw)
In-Reply-To: <1322755222-6951-1-git-send-email-mhocko@suse.cz>
* Michal Hocko <mhocko@suse.cz> [2011-12-01 17:00:22]:
> There is no reason to call update_ts_time_stat from tick_nohz_start_idle
> anymore (after e0e37c20 sched: Eliminate the ts->idle_lastupdate field)
> when we updated idle_lastupdate unconditionally.
>
> We haven't set idle_active yet and do not provide last_update_time so
> the whole call end up being just 2 wasted branches.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> CC: Arjan van de Ven <arjan@linux.intel.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-12-02 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 16:00 [PATCH] nohz: Remove update_ts_time_stat from tick_nohz_start_idle Michal Hocko
2011-12-02 0:45 ` Frederic Weisbecker
2011-12-02 9:57 ` Kamalesh Babulal [this message]
2012-02-15 19:37 ` [tip:timers/core] " tip-bot for Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202095756.GB15975@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.