All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Eddi De Pieri <eddi-soWH+0lSOSbR7s880joybQ@public.gmane.org>
Cc: Guenter Roeck
	<guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>,
	Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] i2c multiplexer driver for Proliant  microserver N36L
Date: Sat, 3 Dec 2011 18:08:19 +0100	[thread overview]
Message-ID: <20111203180819.2ddbcb3a@endymion.delvare> (raw)
In-Reply-To: <CAKdnbx54R9t-mS9-EvyT-618wVp-YH0YDO++=m5t-JqR6h=GCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Eddi,

On Sat, 3 Dec 2011 17:42:16 +0100, Eddi De Pieri wrote:
> Actually I don't have a development system with latest git. I build my
> patch on my debian with 2.6.32 kernel..
> 
> The patch is based on i2c-amd756-s4882.c and adapted to work with sb8xx...
> 
> i2c-amd756-s4882.c is still present and don't use i2c-mux infrastructure.

That's because i2c-amd756-s4882.c was written before the i2c-mux
infrastructure was available. Ideally SMBus multiplexing support on the
Tyan S4882 would be converted to i2c-mux (i.e. i2c-amd756-s4882.c would
be deleted and the multiplexer would be instantiated in i2c-amd756.c
itself, based on DMI data.) This shouldn't be particularly difficult,
the real difficulty is to find someone with one of these boards to test
the changes.

> However if you are interested in porting my work to latest git, you
> will be welcome!

That's not how it works, sorry. Submissions must be based on a recent
kernel in order to be accepted upstream. If you want SMBus multiplexing
support on your system, it will have to be based on i2c-mux, because
that's how things work now. Otherwise I will not accept your code.

-- 
Jean Delvare

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Eddi De Pieri <eddi-soWH+0lSOSbR7s880joybQ@public.gmane.org>
Cc: Guenter Roeck
	<guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>,
	Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [lm-sensors] [PATCH] i2c multiplexer driver for Proliant
Date: Sat, 03 Dec 2011 17:08:19 +0000	[thread overview]
Message-ID: <20111203180819.2ddbcb3a@endymion.delvare> (raw)
In-Reply-To: <CAKdnbx54R9t-mS9-EvyT-618wVp-YH0YDO++=m5t-JqR6h=GCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Eddi,

On Sat, 3 Dec 2011 17:42:16 +0100, Eddi De Pieri wrote:
> Actually I don't have a development system with latest git. I build my
> patch on my debian with 2.6.32 kernel..
> 
> The patch is based on i2c-amd756-s4882.c and adapted to work with sb8xx...
> 
> i2c-amd756-s4882.c is still present and don't use i2c-mux infrastructure.

That's because i2c-amd756-s4882.c was written before the i2c-mux
infrastructure was available. Ideally SMBus multiplexing support on the
Tyan S4882 would be converted to i2c-mux (i.e. i2c-amd756-s4882.c would
be deleted and the multiplexer would be instantiated in i2c-amd756.c
itself, based on DMI data.) This shouldn't be particularly difficult,
the real difficulty is to find someone with one of these boards to test
the changes.

> However if you are interested in porting my work to latest git, you
> will be welcome!

That's not how it works, sorry. Submissions must be based on a recent
kernel in order to be accepted upstream. If you want SMBus multiplexing
support on your system, it will have to be based on i2c-mux, because
that's how things work now. Otherwise I will not accept your code.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-12-03 17:08 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-25 22:07 [PATCH] i2c multiplexer driver for Proliant microserver N36L Eddi De Pieri
2011-11-25 22:07 ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant Eddi De Pieri
     [not found] ` <CAKdnbx7xeygkOK=BR+3vUrWT3GEt=PZrxgrEMvEB5nkOfAF0bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-27 22:55   ` [PATCH] i2c multiplexer driver for Proliant microserver N36L Ben Dooks
2011-11-27 22:55     ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant Ben Dooks
     [not found]     ` <20111127225514.GO19115-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-12-03 15:31       ` [PATCH] i2c multiplexer driver for Proliant microserver N36L Eddi De Pieri
2011-12-03 15:31         ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant Eddi De Pieri
2011-12-03 16:27         ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant microserver N36L Guenter Roeck
2011-12-03 16:27           ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant Guenter Roeck
     [not found]           ` <20111203162757.GA24302-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-12-03 16:42             ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant microserver N36L Eddi De Pieri
2011-12-03 16:42               ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant Eddi De Pieri
     [not found]               ` <CAKdnbx54R9t-mS9-EvyT-618wVp-YH0YDO++=m5t-JqR6h=GCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-03 17:08                 ` Jean Delvare [this message]
2011-12-03 17:08                   ` Jean Delvare
     [not found]                   ` <20111203180819.2ddbcb3a-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-12-05 22:57                     ` [PATCH] i2c multiplexer driver for Proliant microserver N36L Eddi De Pieri
2011-12-05 22:57                       ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant Eddi De Pieri
     [not found]                       ` <CAKdnbx5V=qfa5dshRudHx+M3o8Eb6qJXCVG+ZBaBwCeKaoQYNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-06  8:39                         ` [PATCH] i2c multiplexer driver for Proliant microserver N36L Jean Delvare
2011-12-06  8:39                           ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant Jean Delvare
     [not found]                           ` <20111206093906.21dccf8d-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-12-07 14:57                             ` [PATCH] i2c multiplexer driver for Proliant microserver N36L Eddi De Pieri
2011-12-07 14:57                               ` [lm-sensors] [PATCH] i2c multiplexer driver for Proliant Eddi De Pieri
2012-02-24 18:56                           ` [PATCH] i2c multiplexer driver for Proliant microserver N36L Thomas Brandon
     [not found]                             ` <loom.20120215T165236-509-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2012-02-24 19:04                               ` Thomas Brandon
     [not found]                                 ` <CAM5MpD5R4xde4Li1NCDoErisXs7oRMAgW7swuCwga80MkU3VMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-27  8:42                                   ` Thomas Brandon
     [not found]                                     ` <CAM5MpD46pT1N2f5yZb0yW1O8CjH7B969TmvxDZztMfwBoyom3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-14  8:28                                       ` Eddi De Pieri
     [not found]                                         ` <CAKdnbx7tiMaU1c971a+P2vhE_owO_zd8EXhKR7cAwrH=evVQ6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-29 17:44                                           ` Jean Delvare
2012-06-13  5:44                                       ` Eddi De Pieri
     [not found]                                         ` <CAKdnbx4MUfU086F7navt52WaoF4q_+3G+DHn7u2qic+FU50OiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-13  7:47                                           ` Jean Delvare
     [not found]                                             ` <20120613094739.360967aa-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-06-13 16:59                                               ` [PATCH 0/3] i2c-piix4: Multiple piix4-compatible SMBus support (revised) Andrew Armenia
2012-06-13 16:59                                                 ` Andrew Armenia
2012-06-13 16:59                                                 ` [PATCH 1/3] i2c-piix4: eliminate piix4_smba global variable Andrew Armenia
     [not found]                                                   ` <1339606749-4578-2-git-send-email-andrew-Lwj1yN59in/Ib2jZbfQ/kQ@public.gmane.org>
2012-06-13 19:37                                                     ` Jean Delvare
2012-06-13 19:37                                                       ` Jean Delvare
     [not found]                                                 ` <1339606749-4578-1-git-send-email-andrew-Lwj1yN59in/Ib2jZbfQ/kQ@public.gmane.org>
2012-06-13 16:59                                                   ` [PATCH 2/3] i2c-piix4: separate registration and probing code Andrew Armenia
2012-06-13 16:59                                                     ` Andrew Armenia
     [not found]                                                     ` <1339606749-4578-3-git-send-email-andrew-Lwj1yN59in/Ib2jZbfQ/kQ@public.gmane.org>
2012-06-14 19:38                                                       ` Jean Delvare
2012-06-14 19:38                                                         ` Jean Delvare
2012-06-13 16:59                                                 ` [PATCH 3/3] i2c-piix4: support AMD auxiliary SMBus controller Andrew Armenia
     [not found]                                                   ` <1339606749-4578-4-git-send-email-andrew-Lwj1yN59in/Ib2jZbfQ/kQ@public.gmane.org>
2012-06-15  8:31                                                     ` Jean Delvare
2012-06-15  8:31                                                       ` Jean Delvare
     [not found]                                                       ` <20120615103153.3ea7c009-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-06-15 13:43                                                         ` Andrew Armenia
2012-06-15 13:43                                                           ` Andrew Armenia
     [not found]                                                           ` <CA+jCKRVsMNf7Yj7fP4c6+4ff__v5qsea7rYYqHv25XFBi8v9yg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-16  6:51                                                             ` Jean Delvare
2012-06-16  6:51                                                               ` Jean Delvare
2012-06-15  9:22                                               ` [PATCH] i2c multiplexer driver for Proliant microserver N36L Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111203180819.2ddbcb3a@endymion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=eddi-soWH+0lSOSbR7s880joybQ@public.gmane.org \
    --cc=guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.