All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Liam Girdwood <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
	Benoit Cousson <b-cousson@ti.com>,
	Misael Lopez Cruz <misael.lopez@ti.com>,
	alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings
Date: Mon, 5 Dec 2011 15:46:11 +0000	[thread overview]
Message-ID: <20111205154611.GV11150@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4EDCCAE0.2000009@ti.com>

On Mon, Dec 05, 2011 at 03:45:04PM +0200, Peter Ujfalusi wrote:
> On 12/03/2011 01:22 PM, Mark Brown wrote:

> > Actually thinking about this some more I think what's concerning me is
> > the documentation as much as anything else - if it was just an internal,
> > unpublished interface of the OMAP core code which happened to use device
> > tree I probably wouldn't have worried about it churning.

> Actually it is documented here:
> Documentation/devicetree/bindings/arm/omap/omap.txt

That's not exactly the point...

> In order to move all OMAP drivers to DT - as Benoit already mentioned -
> we need additional work in DT.
> At this point of time if we add the DT representation we anyways need to
> change it as the core will receive the features, and we still need to
> fall back to hwmod to get the drivers working.
> As soon as we can migrate away from the hwmod we will do, but having
> this in place helps us to migrate other parts to DT.

And what I'm saying is that my main concern is that you're publishing
documenting a binding which isn't intended to be the the final binding
and which there's no intention that anyone should use directly anyway.

WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings
Date: Mon, 5 Dec 2011 15:46:11 +0000	[thread overview]
Message-ID: <20111205154611.GV11150@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4EDCCAE0.2000009@ti.com>

On Mon, Dec 05, 2011 at 03:45:04PM +0200, Peter Ujfalusi wrote:
> On 12/03/2011 01:22 PM, Mark Brown wrote:

> > Actually thinking about this some more I think what's concerning me is
> > the documentation as much as anything else - if it was just an internal,
> > unpublished interface of the OMAP core code which happened to use device
> > tree I probably wouldn't have worried about it churning.

> Actually it is documented here:
> Documentation/devicetree/bindings/arm/omap/omap.txt

That's not exactly the point...

> In order to move all OMAP drivers to DT - as Benoit already mentioned -
> we need additional work in DT.
> At this point of time if we add the DT representation we anyways need to
> change it as the core will receive the features, and we still need to
> fall back to hwmod to get the drivers working.
> As soon as we can migrate away from the hwmod we will do, but having
> this in place helps us to migrate other parts to DT.

And what I'm saying is that my main concern is that you're publishing
documenting a binding which isn't intended to be the the final binding
and which there's no intention that anyone should use directly anyway.

  reply	other threads:[~2011-12-05 15:46 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-02  9:52 [PATCH 0/5] ASoC: OMAP4: Device tree support for DMIC, McPDM Peter Ujfalusi
2011-12-02  9:52 ` Peter Ujfalusi
2011-12-02  9:52 ` [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings Peter Ujfalusi
2011-12-02  9:52   ` Peter Ujfalusi
2011-12-02 12:25   ` Mark Brown
2011-12-02 12:25     ` Mark Brown
2011-12-02 12:29     ` Cousson, Benoit
2011-12-02 12:29       ` Cousson, Benoit
2011-12-02 12:32     ` Peter Ujfalusi
2011-12-02 12:32       ` Peter Ujfalusi
2011-12-02 13:02       ` Mark Brown
2011-12-02 13:02         ` Mark Brown
2011-12-02 13:31         ` Cousson, Benoit
2011-12-02 13:31           ` Cousson, Benoit
2011-12-02 14:00           ` Mark Brown
2011-12-02 14:00             ` Mark Brown
2011-12-02 14:59             ` Cousson, Benoit
2011-12-02 14:59               ` Cousson, Benoit
2011-12-02 15:29               ` Mark Brown
2011-12-02 15:29                 ` Mark Brown
2011-12-03 11:22   ` Mark Brown
2011-12-03 11:22     ` Mark Brown
2011-12-05 13:45     ` Peter Ujfalusi
2011-12-05 13:45       ` Peter Ujfalusi
2011-12-05 15:46       ` Mark Brown [this message]
2011-12-05 15:46         ` Mark Brown
2011-12-07  8:45         ` Peter Ujfalusi
2011-12-07  8:45           ` Peter Ujfalusi
2011-12-11  3:20           ` Mark Brown
2011-12-11  3:20             ` Mark Brown
2011-12-02  9:52 ` [PATCH 2/5] ASoC: omap-mcpdm: " Peter Ujfalusi
2011-12-02  9:52   ` Peter Ujfalusi
2011-12-02  9:52 ` [PATCH 3/5] OMAP4: devices: Do not create dmic device if the dtb has been provided Peter Ujfalusi
2011-12-02  9:52   ` Peter Ujfalusi
2011-12-02  9:52 ` [PATCH 4/5] OMAP4: devices: Do not create mcpdm " Peter Ujfalusi
2011-12-02  9:52   ` Peter Ujfalusi
2011-12-02  9:53 ` [PATCH 5/5] ARM: OMAP4: DTS: Support for dmic, and McPDM in device tree Peter Ujfalusi
2011-12-02  9:53   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111205154611.GV11150@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=misael.lopez@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.