All of lore.kernel.org
 help / color / mirror / Atom feed
* Robert Yang : Remove the async_cmds and sync_cmds from command.py
@ 2011-12-05 16:19 git
  0 siblings, 0 replies; only message in thread
From: git @ 2011-12-05 16:19 UTC (permalink / raw)
  To: bitbake-devel

Module: bitbake.git
Branch: master
Commit: 24e99460800856035bb54a84c7aa33b3517436e9
URL:    http://git.openembedded.org/?p=bitbake.git&a=commit;h=24e99460800856035bb54a84c7aa33b3517436e9

Author: Robert Yang <liezhi.yang@windriver.com>
Date:   Wed Nov 30 17:23:51 2011 +0800

Remove the async_cmds and sync_cmds from command.py

In bitbake/lib/bb/command.py::Command::__init__, we have the following
lines:

for attr in CommandsSync.__dict__:
    command = attr[:].lower()
    method = getattr(CommandsSync, attr)
    sync_cmds[command] = (method)

for attr in CommandsAsync.__dict__:
    command = attr[:].lower()
    method = getattr(CommandsAsync, attr)
    async_cmds[command] = (method)

The sync_cmds and async_cmds are defined as global dictionaries, but it
seems that we've never used them (I did a "grep -r async_cmds bitbake/",
, there is no result except the ones that I have removed), and I can't
find the history of it from "git log -p", I guess that they have been
replaced by the self.cmds_sync and self.cmds_async.

[YOCTO #1791]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

---

 lib/bb/command.py |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/lib/bb/command.py b/lib/bb/command.py
index 1808f0c..83907f6 100644
--- a/lib/bb/command.py
+++ b/lib/bb/command.py
@@ -31,10 +31,6 @@ Commands are queued in a CommandQueue
 import bb.event
 import bb.cooker
 
-async_cmds = {}
-sync_cmds = {}
-
-
 class CommandCompleted(bb.event.Event):
     pass
 
@@ -60,16 +56,6 @@ class Command:
         # FIXME Add lock for this
         self.currentAsyncCommand = None
 
-        for attr in CommandsSync.__dict__:
-            command = attr[:].lower()
-            method = getattr(CommandsSync, attr)
-            sync_cmds[command] = (method)
-
-        for attr in CommandsAsync.__dict__:
-            command = attr[:].lower()
-            method = getattr(CommandsAsync, attr)
-            async_cmds[command] = (method)
-
     def runCommand(self, commandline):
         try:
             command = commandline.pop(0)




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-12-05 16:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-05 16:19 Robert Yang : Remove the async_cmds and sync_cmds from command.py git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.