All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 3/3] libxl: Introduce migrate with the new QEMU.
Date: Mon, 5 Dec 2011 19:16:53 +0100	[thread overview]
Message-ID: <20111205181652.GA31962@aepfle.de> (raw)
In-Reply-To: <1322070039-439-4-git-send-email-anthony.perard@citrix.com>

On Wed, Nov 23, Anthony PERARD wrote:

> +    case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> +        fd2 = open(filename, O_WRONLY | O_CREAT | O_TRUNC);

I havent checked wether automated testing caught this, but:

In function 'open',
    inlined from 'libxl__domain_save_device_model' at libxl_dom.c:630:
/usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments
make[3]: *** [libxl_dom.o] Error 1

Olaf

  reply	other threads:[~2011-12-05 18:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23 17:40 [PATCH 0/3] Migration on QEMU upstream Anthony PERARD
2011-11-23 17:40 ` [PATCH 1/3] libxl_qmp: Cut qmp_send function Anthony PERARD
2011-11-23 17:40 ` [PATCH 2/3] libxl_qmp: Command migrate Anthony PERARD
2011-11-23 17:40 ` [PATCH 3/3] libxl: Introduce migrate with the new QEMU Anthony PERARD
2011-12-05 18:16   ` Olaf Hering [this message]
2011-12-21  8:48     ` Ian Campbell
2011-12-21  9:04       ` Anthony PERARD
2011-11-24  9:22 ` [PATCH 0/3] Migration on QEMU upstream Ian Campbell
2011-11-24 12:09   ` Anthony PERARD
2011-11-24 12:18     ` Ian Campbell
2011-12-01 18:10 ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111205181652.GA31962@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=anthony.perard@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.