From: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Henrique de Moraes Holschuh
<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH 0/1][V3] Handle reboot in a child pid namespace
Date: Mon, 5 Dec 2011 21:50:35 +0100 [thread overview]
Message-ID: <20111205205035.GB7422@redhat.com> (raw)
In-Reply-To: <4EDBFD67.1040009-GANU6spQydw@public.gmane.org>
On 12/05, Daniel Lezcano wrote:
>
> On 12/04/2011 10:27 PM, Henrique de Moraes Holschuh wrote:
> > On Sun, 04 Dec 2011, Daniel Lezcano wrote:
> > Daniel, can you address Miquel's concern? Is it a valid concern, or
> > not? I assume CAP_REBOOT functionality is still in place inside the
> > container, so it really does look like userspace would need to know
> > whether it should drop CAP_REBOOT or not, in order to automatically use
> > the new feature.
>
> Hmm, I missed its email.
Me too... so I am not sure I really understand the problem.
> I would like to address this in a separate patch in order to discuss the
> best way to do that.
Agreed.
> Adding a fake 'reboot' parameter returning EINVAL
> or 0 seems a good solution to detect at runtime if the shutdown is
> correctly supported inside a container.
Or, perhaps, we can implement sys_reboot(REBOOT_SHOULD_NOT_WORK),
sub-init can call it to disable the shutdown ?
This needs the trivial modifications in zap_pid_ns_processes()
and reboot_pid_ns().
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Daniel Lezcano <daniel.lezcano@free.fr>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
akpm@linux-foundation.org, serge.hallyn@canonical.com,
containers@lists.linux-foundation.org, gkurz@fr.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1][V3] Handle reboot in a child pid namespace
Date: Mon, 5 Dec 2011 21:50:35 +0100 [thread overview]
Message-ID: <20111205205035.GB7422@redhat.com> (raw)
In-Reply-To: <4EDBFD67.1040009@free.fr>
On 12/05, Daniel Lezcano wrote:
>
> On 12/04/2011 10:27 PM, Henrique de Moraes Holschuh wrote:
> > On Sun, 04 Dec 2011, Daniel Lezcano wrote:
> > Daniel, can you address Miquel's concern? Is it a valid concern, or
> > not? I assume CAP_REBOOT functionality is still in place inside the
> > container, so it really does look like userspace would need to know
> > whether it should drop CAP_REBOOT or not, in order to automatically use
> > the new feature.
>
> Hmm, I missed its email.
Me too... so I am not sure I really understand the problem.
> I would like to address this in a separate patch in order to discuss the
> best way to do that.
Agreed.
> Adding a fake 'reboot' parameter returning EINVAL
> or 0 seems a good solution to detect at runtime if the shutdown is
> correctly supported inside a container.
Or, perhaps, we can implement sys_reboot(REBOOT_SHOULD_NOT_WORK),
sub-init can call it to disable the shutdown ?
This needs the trivial modifications in zap_pid_ns_processes()
and reboot_pid_ns().
Oleg.
next prev parent reply other threads:[~2011-12-05 20:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 20:24 [PATCH 0/1][V3] Handle reboot in a child pid namespace Daniel Lezcano
2011-12-04 20:24 ` Daniel Lezcano
[not found] ` <1323030290-22216-1-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-12-04 20:24 ` [PATCH 1/1][V3] Add reboot_pid_ns to handle the reboot syscall Daniel Lezcano
2011-12-04 20:24 ` Daniel Lezcano
[not found] ` <1323030290-22216-2-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-12-05 18:35 ` Serge Hallyn
2011-12-05 18:35 ` Serge Hallyn
2011-12-05 20:42 ` Oleg Nesterov
2011-12-05 20:42 ` Oleg Nesterov
[not found] ` <20111205204238.GA7422-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-12-05 21:16 ` Daniel Lezcano
2011-12-05 21:16 ` Daniel Lezcano
2011-12-05 21:17 ` Daniel Lezcano
2011-12-05 21:17 ` Daniel Lezcano
2011-12-07 1:16 ` Andrew Morton
2011-12-07 1:16 ` Andrew Morton
[not found] ` <20111206171617.e31bc3a6.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2011-12-07 15:12 ` Oleg Nesterov
2011-12-07 15:12 ` Oleg Nesterov
2011-12-07 21:36 ` Daniel Lezcano
2011-12-07 21:36 ` Daniel Lezcano
2011-12-04 21:27 ` [PATCH 0/1][V3] Handle reboot in a child pid namespace Henrique de Moraes Holschuh
2011-12-04 21:27 ` Henrique de Moraes Holschuh
[not found] ` <20111204212756.GB16362-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2011-12-04 23:08 ` Daniel Lezcano
2011-12-04 23:08 ` Daniel Lezcano
[not found] ` <4EDBFD67.1040009-GANU6spQydw@public.gmane.org>
2011-12-05 20:49 ` Daniel Lezcano
2011-12-05 20:49 ` Daniel Lezcano
[not found] ` <4EDD2E5C.1050107-GANU6spQydw@public.gmane.org>
2011-12-05 20:51 ` Oleg Nesterov
2011-12-05 20:51 ` Oleg Nesterov
2011-12-05 20:50 ` Oleg Nesterov [this message]
2011-12-05 20:50 ` Oleg Nesterov
2011-12-05 22:38 ` Miquel van Smoorenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205205035.GB7422@redhat.com \
--to=oleg-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=daniel.lezcano-GANU6spQydw@public.gmane.org \
--cc=hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.