From: "John W. Linville" <linville@tuxdriver.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linux-wireless@vger.kernel.org, "Michael Buesch" <m@bues.ch>,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH] ssb: fix init regression with SoCs
Date: Tue, 6 Dec 2011 14:56:43 -0500 [thread overview]
Message-ID: <20111206195642.GC30288@tuxdriver.com> (raw)
In-Reply-To: <1323123591-11982-1-git-send-email-hauke@hauke-m.de>
On Mon, Dec 05, 2011 at 11:19:51PM +0100, Hauke Mehrtens wrote:
> This fixes a Data bus error on some SoCs. The first fix for this
> problem did not solve it on all devices.
> commit 6ae8ec27868bfdbb815287bee8146acbefaee867
> Author: Rafał Miłecki <zajec5@gmail.com>
> Date: Tue Jul 5 17:25:32 2011 +0200
> ssb: fix init regression of hostmode PCI core
>
> In ssb_pcicore_fix_sprom_core_index() the sprom on the PCI core is
> accessed, but the sprom only exists when the ssb bus is connected over
> a PCI bus to the rest of the system and not when the SSB Bus is the
> main system bus. SoCs sometimes have a PCI host controller and there
> this code will not be executed, but there are some old SoCs with an PCI
> controller in client mode around and ssb_pcicore_fix_sprom_core_index()
> should not be called on these devices too. The PCI controller on these
> devices are unused, but without this fix it results in an Data bus
> error when it gets initialized.
>
> CC: Michael Buesch <m@bues.ch>
> CC: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Should this go to the stable list?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2011-12-06 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 22:19 [PATCH] ssb: fix init regression with SoCs Hauke Mehrtens
2011-12-05 23:44 ` Larry Finger
2011-12-08 22:37 ` Hauke Mehrtens
2011-12-06 19:56 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206195642.GC30288@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.