From: Hauke Mehrtens <hauke@hauke-m.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
"Michael Buesch" <m@bues.ch>, "Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH] ssb: fix init regression with SoCs
Date: Thu, 08 Dec 2011 23:37:00 +0100 [thread overview]
Message-ID: <4EE13C0C.30602@hauke-m.de> (raw)
In-Reply-To: <4EDD574E.9090801@lwfinger.net>
Hi Larry,
On 12/06/2011 12:44 AM, Larry Finger wrote:
> On 12/05/2011 04:19 PM, Hauke Mehrtens wrote:
>> --- a/drivers/ssb/driver_pcicore.c
>> +++ b/drivers/ssb/driver_pcicore.c
>> @@ -517,10 +517,14 @@ static void
>> ssb_pcicore_pcie_setup_workarounds(struct ssb_pcicore *pc)
>>
>> static void __devinit ssb_pcicore_init_clientmode(struct ssb_pcicore
>> *pc)
>> {
>> - ssb_pcicore_fix_sprom_core_index(pc);
>> + struct ssb_device *pdev = pc->dev;
>> + struct ssb_bus *bus = pdev->bus;
>> +
>> + if (bus->bustype == SSB_BUSTYPE_PCI)
>> + ssb_pcicore_fix_sprom_core_index(pc);
>>
>> /* Disable PCI interrupts. */
>> - ssb_write32(pc->dev, SSB_INTVEC, 0);
>> + ssb_write32(pdev, SSB_INTVEC, 0);
>
> As bus == pc->dev->bus is only used once, why bother to create it? If
> you were to change that, then pdev == pc->dev is only used once. Any
> real reason to change the lines above?
Not really, I will send a v2.
Hauke
next prev parent reply other threads:[~2011-12-08 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 22:19 [PATCH] ssb: fix init regression with SoCs Hauke Mehrtens
2011-12-05 23:44 ` Larry Finger
2011-12-08 22:37 ` Hauke Mehrtens [this message]
2011-12-06 19:56 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE13C0C.30602@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.