From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Tegra: fix undefined instruction hang immediately after reset
Date: Wed, 7 Dec 2011 19:14:31 -0500 [thread overview]
Message-ID: <201112071914.32335.vapier@gentoo.org> (raw)
In-Reply-To: <1323212419-21023-1-git-send-email-twarren@nvidia.com>
On Tuesday 06 December 2011 18:00:19 Tom Warren wrote:
> commit 0d479b53 (Aneesh V) added code for OMAP4 that doesn't
> execute on Tegra, due to the AVP (ARM7TDI) not having a CP15.
> Result was an undefined instruction hang just after reset.
>
> --- a/arch/arm/cpu/armv7/start.S
> +++ b/arch/arm/cpu/armv7/start.S
>
> +#if !defined(CONFIG_TEGRA2)
> /*
> * Setup vector:
> * (OMAP4 spl TEXT_BASE is not 32 byte aligned.
> @@ -159,6 +160,7 @@ reset:
> ldr r0, =_start
> mcr p15, 0, r0, c12, c0, 0 @Set VBAR
> #endif
> +#endif /* !Tegra2 */
forgive my ignorance, but would it be better to invert the logic ? have ARM
cores that do have a CP15 define CONFIG_ARM_CP15 (or whatever) and then put all
this logic behind that rather than grow a list of SoC's that lack it ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111207/1e908f4f/attachment.pgp>
next prev parent reply other threads:[~2011-12-08 0:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 23:00 [U-Boot] [PATCH] arm: Tegra: fix undefined instruction hang immediately after reset Tom Warren
2011-12-08 0:14 ` Mike Frysinger [this message]
2011-12-08 5:51 ` Aneesh V
2011-12-08 6:25 ` Mike Frysinger
2011-12-08 15:37 ` Tom Warren
2011-12-09 6:18 ` Aneesh V
[not found] ` <7E91C59574E9954FA075F8D8CCDF78DB392E3A5798@HQMAIL04.nvidia.com>
2011-12-20 23:27 ` Tom Warren
2011-12-21 4:07 ` Simon Glass
2011-12-21 6:58 ` Wolfgang Denk
2011-12-21 8:02 ` Aneesh V
2011-12-21 16:10 ` Tom Warren
2011-12-21 19:37 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112071914.32335.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.