From: Tony Lindgren <tony@atomide.com>
To: Thomas Weber <weber@corscience.de>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] ARM: OMAP2+: Add chip_select to ads7846 init
Date: Thu, 8 Dec 2011 16:37:44 -0800 [thread overview]
Message-ID: <20111209003744.GH31337@atomide.com> (raw)
In-Reply-To: <1320358999-11016-1-git-send-email-weber@corscience.de>
* Thomas Weber <weber@corscience.de> [111103 13:46]:
> This patch adds the chip_select as parameter to
> omap_ads7846_init.
> All existing omap2-boards use chip select 0 on
> different spi busses. I work on bringing a board
> mainline where the ads7846 is connected to
> chip select 1. This patch prepares the omap_ads7846_init
> function for this board.
>
> Signed-off-by: Thomas Weber <weber@corscience.de>
> ---
> arch/arm/mach-omap2/board-3430sdp.c | 2 +-
> arch/arm/mach-omap2/board-cm-t35.c | 2 +-
> arch/arm/mach-omap2/board-devkit8000.c | 2 +-
> arch/arm/mach-omap2/board-ldp.c | 2 +-
> arch/arm/mach-omap2/board-omap3evm.c | 2 +-
> arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
> arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
> arch/arm/mach-omap2/board-overo.c | 2 +-
> arch/arm/mach-omap2/common-board-devices.c | 13 ++++++++-----
> arch/arm/mach-omap2/common-board-devices.h | 3 ++-
> 11 files changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 77142c1..dec6407 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -710,7 +710,7 @@ static void __init omap_3430sdp_init(void)
> gpio_pendown = SDP3430_TS_GPIO_IRQ_SDPV2;
> else
> gpio_pendown = SDP3430_TS_GPIO_IRQ_SDPV1;
> - omap_ads7846_init(1, gpio_pendown, 310, NULL);
> + omap_ads7846_init(1, 0, gpio_pendown, 310, NULL);
> board_serial_init();
> omap_sdrc_init(hyb18m512160af6_sdrc_params, NULL);
> usb_musb_init(NULL);
This seems OK to me until we have device tree bindings for
this.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH] ARM: OMAP2+: Add chip_select to ads7846 init
Date: Thu, 8 Dec 2011 16:37:44 -0800 [thread overview]
Message-ID: <20111209003744.GH31337@atomide.com> (raw)
In-Reply-To: <1320358999-11016-1-git-send-email-weber@corscience.de>
* Thomas Weber <weber@corscience.de> [111103 13:46]:
> This patch adds the chip_select as parameter to
> omap_ads7846_init.
> All existing omap2-boards use chip select 0 on
> different spi busses. I work on bringing a board
> mainline where the ads7846 is connected to
> chip select 1. This patch prepares the omap_ads7846_init
> function for this board.
>
> Signed-off-by: Thomas Weber <weber@corscience.de>
> ---
> arch/arm/mach-omap2/board-3430sdp.c | 2 +-
> arch/arm/mach-omap2/board-cm-t35.c | 2 +-
> arch/arm/mach-omap2/board-devkit8000.c | 2 +-
> arch/arm/mach-omap2/board-ldp.c | 2 +-
> arch/arm/mach-omap2/board-omap3evm.c | 2 +-
> arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
> arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
> arch/arm/mach-omap2/board-overo.c | 2 +-
> arch/arm/mach-omap2/common-board-devices.c | 13 ++++++++-----
> arch/arm/mach-omap2/common-board-devices.h | 3 ++-
> 11 files changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 77142c1..dec6407 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -710,7 +710,7 @@ static void __init omap_3430sdp_init(void)
> gpio_pendown = SDP3430_TS_GPIO_IRQ_SDPV2;
> else
> gpio_pendown = SDP3430_TS_GPIO_IRQ_SDPV1;
> - omap_ads7846_init(1, gpio_pendown, 310, NULL);
> + omap_ads7846_init(1, 0, gpio_pendown, 310, NULL);
> board_serial_init();
> omap_sdrc_init(hyb18m512160af6_sdrc_params, NULL);
> usb_musb_init(NULL);
This seems OK to me until we have device tree bindings for
this.
Regards,
Tony
next prev parent reply other threads:[~2011-12-09 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 22:23 [RFC/PATCH] ARM: OMAP2+: Add chip_select to ads7846 init Thomas Weber
2011-11-03 22:23 ` Thomas Weber
2011-12-09 0:37 ` Tony Lindgren [this message]
2011-12-09 0:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209003744.GH31337@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=weber@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.