From: Alan Modra <amodra@gmail.com>
To: David Daney <david.daney@cavium.com>
Cc: binutils <binutils@sourceware.org>,
Richard Sandiford <rdsandiford@googlemail.com>,
Manuel Lauss <manuel.lauss@googlemail.com>,
Debian MIPS <debian-mips@lists.debian.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [Patch v2]: Fix ld pr11138 FAILures on mips*.
Date: Sat, 10 Dec 2011 11:09:28 +1030 [thread overview]
Message-ID: <20111210003928.GC2461@bubble.grove.modra.org> (raw)
In-Reply-To: <4EE27012.5030508@cavium.com>
On Fri, Dec 09, 2011 at 12:31:14PM -0800, David Daney wrote:
> * /elfxx-mips.c (mips_elf_link_hash_table.rld_value): Remove.
> (mips_elf_link_hash_table.rld_symbol): New field;
> (MIPS_ELF_RLD_MAP_SIZE): New macro.
> (_bfd_mips_elf_add_symbol_hook): Remember __rld_obj_head symbol
> in rld_symbol.
> (_bfd_mips_elf_create_dynamic_sections): Remember __rld_map symbol
> in rld_symbol.
> (_bfd_mips_elf_size_dynamic_sections): Set correct size for .rld_map.
> (_bfd_mips_elf_finish_dynamic_symbol): Remove .rld_map handling.
> (_bfd_mips_elf_finish_dynamic_sections): Use rld_symbol to
> calculate DT_MIPS_RLD_MAP value.
> (_bfd_mips_elf_link_hash_table_create): Initialize rld_symbol,
> quit initializing rld_value.
OK. Remove stray / in ChangeLog entry
> + s->size += MIPS_ELF_RLD_MAP_SIZE(output_bfd);
Fix formatting here.
> + dyn.d_un.d_ptr = s->output_section->vma + s->output_offset
> + + h->root.u.def.value;
And it's nice to write code that emacs auto-indent won't change, so
add parentheses
dyn.d_un.d_ptr = (s->output_section->vma + s->output_offset
+ h->root.u.def.value);
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2011-12-10 0:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 20:31 [Patch v2]: Fix ld pr11138 FAILures on mips* David Daney
2011-12-10 0:39 ` Alan Modra [this message]
2011-12-10 0:50 ` David Daney
2011-12-10 10:19 ` Richard Sandiford
2011-12-12 20:24 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111210003928.GC2461@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=david.daney@cavium.com \
--cc=debian-mips@lists.debian.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.