From: Richard Sandiford <rdsandiford@googlemail.com>
To: David Daney <david.daney@cavium.com>
Cc: binutils <binutils@sourceware.org>, Alan Modra <amodra@gmail.com>,
Manuel Lauss <manuel.lauss@googlemail.com>,
Debian MIPS <debian-mips@lists.debian.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [Patch v2]: Fix ld pr11138 FAILures on mips*.
Date: Sat, 10 Dec 2011 10:19:20 +0000 [thread overview]
Message-ID: <87y5ukenkn.fsf@firetop.home> (raw)
In-Reply-To: <4EE2ACB9.9010301@cavium.com> (David Daney's message of "Fri, 09 Dec 2011 16:50:01 -0800")
David Daney <david.daney@cavium.com> writes:
> I will wait a couple of days to give Richard a chance to object.
Looks good to me too. Thanks for doing this. I think it should go
on the 2.22 branch as well.
> I am especially concerned about what happens on IRIX where the symbol
> comes in from an external object rather than being generated by the
> linker itself. I had no way to test that.
Me neither, unfortunately. But I agree it looks right. There's a
possibility that we could create the dynamic sections before the
definition of __rld_obj_head has been read in (e.g. from the
check_relocs of a previous object). In that case it looks like
we would create the .rld_map section and __rld_map/__RLD_MAP symbol,
then later switch to __rld_obj_head. .rld_map would then be left
at zero size and the __rld_map/__RLD_MAP symbol would be ignored
when setting the tag value. But your patch preserves the
behaviour in that case too.
Richard
next prev parent reply other threads:[~2011-12-10 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 20:31 [Patch v2]: Fix ld pr11138 FAILures on mips* David Daney
2011-12-10 0:39 ` Alan Modra
2011-12-10 0:50 ` David Daney
2011-12-10 10:19 ` Richard Sandiford [this message]
2011-12-12 20:24 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5ukenkn.fsf@firetop.home \
--to=rdsandiford@googlemail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=david.daney@cavium.com \
--cc=debian-mips@lists.debian.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.