From: Vasiliy Kulikov <segoon@openwall.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>
Subject: [kernel-hardening] Re: [PATCH -next] proc: fix task_struct infoleak
Date: Mon, 12 Dec 2011 15:31:56 +0400 [thread overview]
Message-ID: <20111212113156.GA12141@albatros> (raw)
In-Reply-To: <20111211205939.GH2203@ZenIV.linux.org.uk>
On Sun, Dec 11, 2011 at 20:59 +0000, Al Viro wrote:
> On Sun, Dec 11, 2011 at 10:28:21PM +0400, Vasiliy Kulikov wrote:
> > proc_pid_permission() doesn't put task_struct on every /proc/$pid/
> > access. A demo from Hugh Dickins:
> >
> > while :; do ps; grep KernelStack /proc/meminfo; sleep 1; done
> >
> > Reported-by: Hugh Dickins <hughd@google.com>
> > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> > ---
> > This is a patch against a hidepid patchset from -mm.
>
> Choose saner commit summary, please. It's not information leak, for pity sake
> - it's a plain and simple memory leak...
Oops! s/infoleak/memleak/ surely, bad habit...
Thank you, I'll resend the patch.
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segoon@openwall.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH -next] proc: fix task_struct infoleak
Date: Mon, 12 Dec 2011 15:31:56 +0400 [thread overview]
Message-ID: <20111212113156.GA12141@albatros> (raw)
In-Reply-To: <20111211205939.GH2203@ZenIV.linux.org.uk>
On Sun, Dec 11, 2011 at 20:59 +0000, Al Viro wrote:
> On Sun, Dec 11, 2011 at 10:28:21PM +0400, Vasiliy Kulikov wrote:
> > proc_pid_permission() doesn't put task_struct on every /proc/$pid/
> > access. A demo from Hugh Dickins:
> >
> > while :; do ps; grep KernelStack /proc/meminfo; sleep 1; done
> >
> > Reported-by: Hugh Dickins <hughd@google.com>
> > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> > ---
> > This is a patch against a hidepid patchset from -mm.
>
> Choose saner commit summary, please. It's not information leak, for pity sake
> - it's a plain and simple memory leak...
Oops! s/infoleak/memleak/ surely, bad habit...
Thank you, I'll resend the patch.
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-12-12 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 18:28 [kernel-hardening] [PATCH -next] proc: fix task_struct infoleak Vasiliy Kulikov
2011-12-11 18:28 ` Vasiliy Kulikov
2011-12-11 20:59 ` [kernel-hardening] " Al Viro
2011-12-11 20:59 ` Al Viro
2011-12-12 11:31 ` Vasiliy Kulikov [this message]
2011-12-12 11:31 ` Vasiliy Kulikov
2011-12-11 23:20 ` [kernel-hardening] " Hugh Dickins
2011-12-11 23:20 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212113156.GA12141@albatros \
--to=segoon@openwall.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.