Re: [PATCH 1/2 v2] serial: bfin-uart: Enable hardware automatic CTS only when CTS pin is available.

[Greg KH <greg@kroah.com>]

On Mon, Dec 12, 2011 at 02:59:50PM +0800, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
>  drivers/tty/serial/bfin_uart.c |   19 ++++++++++---------
>  1 files changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/tty/serial/bfin_uart.c b/drivers/tty/serial/bfin_uart.c
> index abac237..a6c1c08 100644
> --- a/drivers/tty/serial/bfin_uart.c
> +++ b/drivers/tty/serial/bfin_uart.c
> @@ -726,16 +726,17 @@ static int bfin_serial_startup(struct uart_port *port)
>  	}
>  #endif
>  #ifdef CONFIG_SERIAL_BFIN_HARD_CTSRTS
> -	if (uart->cts_pin >= 0 && request_irq(uart->status_irq,
> -		bfin_serial_mctrl_cts_int,
> -		0, "BFIN_UART_MODEM_STATUS", uart)) {
> -		uart->cts_pin = -1;
> -		pr_info("Unable to attach BlackFin UART Modem Status interrupt.\n");
> -	}
> +	if (uart->cts_pin >= 0) {
> +		if (request_irq(uart->status_irq, bfin_serial_mctrl_cts_int,
> +			IRQF_DISABLED, "BFIN_UART_MODEM_STATUS", uart)) {
> +			uart->cts_pin = -1;
> +			pr_info("Unable to attach BlackFin UART Modem Status interrupt.\n");

Please use dev_info() here instead, that properly identifies the exact
device you are having problems with.

thanks,

greg k-h