From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs/fat/fat.c: fix warning: 'part_size' defined but not used
Date: Tue, 13 Dec 2011 09:53:58 +0100 [thread overview]
Message-ID: <20111213095358.5601b9ce@wker> (raw)
In-Reply-To: <20111213081815.CE6A811EF9B4@gemini.denx.de>
Hello all,
On Tue, 13 Dec 2011 09:18:15 +0100
Wolfgang Denk <wd@denx.de> wrote:
> Dear Aaron Williams,
>
> In message <201112122215.11610.Aaron.Williams@cavium.com> you wrote:
> >
> > > Commit c30a15e "FAT: Add FAT write feature" introduced a compiler
> > > warning. Fix this.
> ...
> > I know it's rather late to comment on this, but this patch breaks FAT write
> > support.
>
> How can it break something we don't have?
>
> Currently there is no write support for (V)FAT file systems in
> mainline.
>
> The commit removes a static variable of file scope, that was used in a
> single place, where a value was assigned to it. There was no place
> anywhere in the code twhere else this variable was referenced. So how
> can this break anything?
>
> Please elucidate.
The FAT write support as submitted and included seems to be broken.
The removed variable is referenced in fs/fat/fat_write.c, but in
fs/fat/fat.c it is declared as static. This issue didn't show up
because no board config file in mainline defines CONFIG_FAT_WRITE.
@ Donggeun Kim
Could you please submit a patch fixing this?
Thanks,
Anatolij
next prev parent reply other threads:[~2011-12-13 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 7:15 [U-Boot] [PATCH v2] FAT: Add FAT write feature Donggeun Kim
2011-10-26 19:41 ` Wolfgang Denk
2011-10-27 13:48 ` Marek Vasut
2011-10-26 22:45 ` Mike Frysinger
2011-10-27 20:55 ` Wolfgang Denk
2011-10-27 21:08 ` Mike Frysinger
2011-10-27 21:10 ` [U-Boot] [PATCH] fs/fat/fat.c: fix warning: 'part_size' defined but not used Wolfgang Denk
2011-12-13 6:15 ` Aaron Williams
2011-12-13 8:18 ` Wolfgang Denk
2011-12-13 8:53 ` Anatolij Gustschin [this message]
2011-12-13 11:03 ` Wolfgang Denk
2011-12-13 8:37 ` Donggeun Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213095358.5601b9ce@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.