From: Donggeun Kim <dg77.kim@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs/fat/fat.c: fix warning: 'part_size' defined but not used
Date: Tue, 13 Dec 2011 17:37:45 +0900 [thread overview]
Message-ID: <4EE70ED9.5060109@samsung.com> (raw)
In-Reply-To: <201112122215.11610.Aaron.Williams@cavium.com>
On 2011? 12? 13? 15:15, Aaron Williams wrote:
> On Thursday, October 27, 2011 02:10:58 PM Wolfgang Denk wrote:
>> Commit c30a15e "FAT: Add FAT write feature" introduced a compiler
>> warning. Fix this.
>>
>> Signed-off-by: Wolfgang Denk <wd@denx.de>
>> Cc: Donggeun Kim <dg77.kim@samsung.com>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>
>> fs/fat/fat.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/fat/fat.c b/fs/fat/fat.c
>> index 7cf173c..756ac64 100644
>> --- a/fs/fat/fat.c
>> +++ b/fs/fat/fat.c
>> @@ -46,7 +46,6 @@ static void downcase (char *str)
>> static block_dev_desc_t *cur_dev = NULL;
>>
>> static unsigned long part_offset = 0;
>> -static unsigned long part_size;
>>
>> static int cur_part = 1;
>>
>> @@ -100,7 +99,6 @@ int fat_register_device (block_dev_desc_t * dev_desc,
>> int part_no) if (!get_partition_info(dev_desc, part_no, &info)) {
>> part_offset = info.start;
>> cur_part = part_no;
>> - part_size = info.size;
>> } else if ((strncmp((char *)&buffer[DOS_FS_TYPE_OFFSET], "FAT", 3) == 0)
>> || (strncmp((char *)&buffer[DOS_FS32_TYPE_OFFSET], "FAT32", 5) == 0)) { /*
>> ok, we assume we are on a PBR only */
>
> Hi Wolfgang,
>
> I know it's rather late to comment on this, but this patch breaks FAT write
> support.
>
> -Aaron
>
>
Hi, Wolfgang,
I've overlooked the patch before.
If 'part_size' variable is not set in fat_register_device function, FAT
write feature would not work properly.
So, I will send a patch to define the variable only when FAT_WRITE is
enabled. It can avoid compile warning.
Thanks.
-Donggeun
prev parent reply other threads:[~2011-12-13 8:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 7:15 [U-Boot] [PATCH v2] FAT: Add FAT write feature Donggeun Kim
2011-10-26 19:41 ` Wolfgang Denk
2011-10-27 13:48 ` Marek Vasut
2011-10-26 22:45 ` Mike Frysinger
2011-10-27 20:55 ` Wolfgang Denk
2011-10-27 21:08 ` Mike Frysinger
2011-10-27 21:10 ` [U-Boot] [PATCH] fs/fat/fat.c: fix warning: 'part_size' defined but not used Wolfgang Denk
2011-12-13 6:15 ` Aaron Williams
2011-12-13 8:18 ` Wolfgang Denk
2011-12-13 8:53 ` Anatolij Gustschin
2011-12-13 11:03 ` Wolfgang Denk
2011-12-13 8:37 ` Donggeun Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE70ED9.5060109@samsung.com \
--to=dg77.kim@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.