From: Marcelo Tosatti <mtosatti@redhat.com>
To: Dor Laor <dlaor@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, Eric B Munson <emunson@mgebm.net>,
mingo@redhat.com, hpa@zytor.com, arnd@arndb.de,
ryanh@linux.vnet.ibm.com, aliguori@us.ibm.com,
jeremy.fitzhardinge@citrix.com, levinsasha928@gmail.com,
Jan Kiszka <jan.kiszka@siemens.com>,
kvm@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host
Date: Wed, 14 Dec 2011 10:18:10 -0200 [thread overview]
Message-ID: <20111214121810.GC18317@amt.cnet> (raw)
In-Reply-To: <4EE4A4DA.90100@redhat.com>
On Sun, Dec 11, 2011 at 02:40:58PM +0200, Dor Laor wrote:
> >>When a guest kernel is stopped by the host hypervisor it can look like a soft
> >>lockup to the guest kernel. This false warning can mask later soft lockup
> >>warnings which may be real. This patch series adds a method for a host
> >>hypervisor to communicate to a guest kernel that it is being stopped. The
> >>final patch in the series has the watchdog check this flag when it goes to
> >>issue a soft lockup warning and skip the warning if the guest knows it was
> >>stopped.
> >>
> >>It was attempted to solve this in Qemu, but the side effects of saving and
> >>restoring the clock and tsc for each vcpu put the wall clock of the guest behind
> >>by the amount of time of the pause. This forces a guest to have ntp running
> >>in order to keep the wall clock accurate.
>
> Guests need to run NTP regardless, not only the virtualization layer
> add some skew, the physical world is not that perfect.
> btw: traditional NTP client won't sync the time automatically if the
> diff is > 0.5%.
>
> >
> >Having this controlled from userspace means it doesn't work for SIGSTOP
> >or for long scheduling delays. What about doing this automatically
> >based on preempt notifiers?
> >
> >
>
> Isn't it solved by steal time?
No.
next prev parent reply other threads:[~2011-12-14 12:18 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 20:18 [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host Eric B Munson
2011-12-05 20:19 ` [PATCH 1/5 V5] Add flag to indicate that a vm was stopped by the host Eric B Munson
2011-12-05 20:19 ` [PATCH 2/5 V5] Add functions to check if the host has stopped the vm Eric B Munson
2011-12-07 14:31 ` Avi Kivity
2011-12-08 15:23 ` Eric B Munson
2011-12-14 12:11 ` Marcelo Tosatti
2011-12-14 14:37 ` Avi Kivity
2011-12-14 17:11 ` Eric B Munson
2011-12-14 17:30 ` Avi Kivity
2011-12-14 17:57 ` Eric B Munson
2011-12-05 20:19 ` [PATCH 3/5 V5] Add ioctl for KVMCLOCK_GUEST_STOPPED Eric B Munson
2011-12-07 14:34 ` Avi Kivity
2011-12-08 15:25 ` Eric B Munson
2011-12-05 20:19 ` [PATCH 4/5 V5] Add generic stubs for kvm stop check functions Eric B Munson
2011-12-07 14:36 ` Avi Kivity
2011-12-08 15:27 ` Eric B Munson
2011-12-05 20:19 ` [PATCH 5/5 V5] Add check for suspended vm in softlockup detector Eric B Munson
2011-12-07 14:38 ` Avi Kivity
2011-12-07 14:41 ` [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host Avi Kivity
2011-12-08 15:19 ` Eric B Munson
2011-12-14 15:08 ` Avi Kivity
2011-12-14 17:58 ` Eric B Munson
2011-12-15 9:48 ` Avi Kivity
2011-12-15 18:53 ` Eric B Munson
2011-12-19 13:01 ` Avi Kivity
2011-12-11 12:40 ` Dor Laor
2011-12-14 12:18 ` Marcelo Tosatti [this message]
2011-12-14 12:16 ` Marcelo Tosatti
2011-12-14 14:39 ` Avi Kivity
2011-12-14 14:49 ` Anthony Liguori
2011-12-14 15:01 ` Avi Kivity
2011-12-14 14:54 ` Eric B Munson
2011-12-14 18:21 ` Marcelo Tosatti
2011-12-15 10:21 ` Avi Kivity
2011-12-16 9:31 ` Marcelo Tosatti
2011-12-19 12:59 ` Avi Kivity
2011-12-19 16:11 ` Marcelo Tosatti
2011-12-19 17:50 ` Marcelo Tosatti
2011-12-22 9:59 ` Avi Kivity
2011-12-08 11:34 ` Amit Shah
2011-12-15 11:55 ` Avi Kivity
2011-12-19 12:52 ` Amit Shah
2011-12-19 12:59 ` Avi Kivity
2011-12-19 17:59 ` Amit Shah
2011-12-22 9:18 ` Dor Laor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214121810.GC18317@amt.cnet \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=dlaor@redhat.com \
--cc=emunson@mgebm.net \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ryanh@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.