All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Eric B Munson <emunson@mgebm.net>
Cc: mingo@redhat.com, hpa@zytor.com, arnd@arndb.de,
	ryanh@linux.vnet.ibm.com, aliguori@us.ibm.com,
	mtosatti@redhat.com, jeremy.fitzhardinge@citrix.com,
	levinsasha928@gmail.com, Jan Kiszka <jan.kiszka@siemens.com>,
	kvm@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5 V5] Add check for suspended vm in softlockup detector
Date: Wed, 07 Dec 2011 16:38:42 +0200	[thread overview]
Message-ID: <4EDF7A72.5020703@redhat.com> (raw)
In-Reply-To: <1323116344-17911-6-git-send-email-emunson@mgebm.net>

On 12/05/2011 10:19 PM, Eric B Munson wrote:
> A suspended VM can cause spurious soft lockup warnings.  To avoid these, the
> watchdog now checks if the kernel knows it was stopped by the host and skips
> the warning if so.  When the watchdog is reset successfully, clear the guest
> paused flag.
>
>  int watchdog_enabled = 1;
> @@ -280,6 +281,9 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
>  			__this_cpu_write(softlockup_touch_sync, false);
>  			sched_clock_tick();
>  		}
> +
> +		/* Clear the guest paused flag on watchdog reset */
> +		kvm_check_and_clear_guest_paused(smp_processor_id());
>  		__touch_watchdog();
>  		return HRTIMER_RESTART;
>  	}

Won't build if !CONFIG_KVMCLOCK


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-12-07 14:38 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05 20:18 [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host Eric B Munson
2011-12-05 20:19 ` [PATCH 1/5 V5] Add flag to indicate that a vm was stopped by the host Eric B Munson
2011-12-05 20:19 ` [PATCH 2/5 V5] Add functions to check if the host has stopped the vm Eric B Munson
2011-12-07 14:31   ` Avi Kivity
2011-12-08 15:23     ` Eric B Munson
2011-12-14 12:11       ` Marcelo Tosatti
2011-12-14 14:37         ` Avi Kivity
2011-12-14 17:11           ` Eric B Munson
2011-12-14 17:30             ` Avi Kivity
2011-12-14 17:57               ` Eric B Munson
2011-12-05 20:19 ` [PATCH 3/5 V5] Add ioctl for KVMCLOCK_GUEST_STOPPED Eric B Munson
2011-12-07 14:34   ` Avi Kivity
2011-12-08 15:25     ` Eric B Munson
2011-12-05 20:19 ` [PATCH 4/5 V5] Add generic stubs for kvm stop check functions Eric B Munson
2011-12-07 14:36   ` Avi Kivity
2011-12-08 15:27     ` Eric B Munson
2011-12-05 20:19 ` [PATCH 5/5 V5] Add check for suspended vm in softlockup detector Eric B Munson
2011-12-07 14:38   ` Avi Kivity [this message]
2011-12-07 14:41 ` [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host Avi Kivity
2011-12-08 15:19   ` Eric B Munson
2011-12-14 15:08     ` Avi Kivity
2011-12-14 17:58       ` Eric B Munson
2011-12-15  9:48         ` Avi Kivity
2011-12-15 18:53           ` Eric B Munson
2011-12-19 13:01             ` Avi Kivity
2011-12-11 12:40   ` Dor Laor
2011-12-14 12:18     ` Marcelo Tosatti
2011-12-14 12:16   ` Marcelo Tosatti
2011-12-14 14:39     ` Avi Kivity
2011-12-14 14:49       ` Anthony Liguori
2011-12-14 15:01         ` Avi Kivity
2011-12-14 14:54       ` Eric B Munson
2011-12-14 18:21       ` Marcelo Tosatti
2011-12-15 10:21         ` Avi Kivity
2011-12-16  9:31           ` Marcelo Tosatti
2011-12-19 12:59             ` Avi Kivity
2011-12-19 16:11               ` Marcelo Tosatti
2011-12-19 17:50                 ` Marcelo Tosatti
2011-12-22  9:59                   ` Avi Kivity
2011-12-08 11:34 ` Amit Shah
2011-12-15 11:55   ` Avi Kivity
2011-12-19 12:52     ` Amit Shah
2011-12-19 12:59       ` Avi Kivity
2011-12-19 17:59         ` Amit Shah
2011-12-22  9:18           ` Dor Laor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDF7A72.5020703@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=arnd@arndb.de \
    --cc=emunson@mgebm.net \
    --cc=hpa@zytor.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=ryanh@linux.vnet.ibm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.