From: Oliver Neukum <oneukum@suse.de>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: jkosina@suse.cz, bleung@chromium.org, stern@rowland.harvard.edu,
olofj@chromium.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue
Date: Wed, 14 Dec 2011 12:22:40 +0100 [thread overview]
Message-ID: <201112141222.41006.oneukum@suse.de> (raw)
In-Reply-To: <CAGS+omA=9qfqDYtaLp67Xz+WhcpW_=jn9hoiaad43Z+oexjsFQ@mail.gmail.com>
Am Mittwoch, 14. Dezember 2011, 11:33:03 schrieb Daniel Kurtz:
> On Wed, Dec 14, 2011 at 4:01 PM, Oliver Neukum <oneukum@suse.de> wrote:
> > Am Donnerstag, 17. November 2011, 12:23:50 schrieb Daniel Kurtz:
> >> Defer LED setting action to a workqueue.
> >> This is more likely to send all LED change events in a single URB.
> >
> > Hi,
> >
> > I hope I am looking at the correct version of this patch.
> > But as far as I can see the work for handling LEDs is not delayed
> > while a reset is going on. That is wrong.
>
> Actually, I'm not sure why this is wrong. I find the reset handling
> quite confusing in this driver.
> Can you point out what will fail, and recommend how to fix it?
That is part of the workings of a USB driver. After you return from
pre_reset() you don't do IO to the device. After post_reset() the
device should be in its default state whose LED states won't match
what they ought to be.
Regards
Oliver
next prev parent reply other threads:[~2011-12-14 11:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 11:23 [PATCH 0/3 v2] usb/hid-core: drain URB queue when going to suspend Daniel Kurtz
2011-11-17 11:23 ` [PATCH 1/3] HID: usbhid: remove LED_ON Daniel Kurtz
2011-11-17 11:23 ` [PATCH 2/3] HID: usbhid: hid-core: submit queued urbs before suspend Daniel Kurtz
2011-12-14 7:55 ` Oliver Neukum
2011-12-14 8:00 ` Daniel Kurtz
2011-12-14 8:00 ` Daniel Kurtz
[not found] ` <CAGS+omDMipRTVOGV9fG0ciWpuwMRBL-eTY8uDwaiSOW==CkQ-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-14 9:14 ` Oliver Neukum
2011-12-14 9:14 ` Oliver Neukum
2011-12-14 9:41 ` Daniel Kurtz
2011-12-14 9:41 ` Daniel Kurtz
2011-12-14 11:36 ` Oliver Neukum
2011-11-17 11:23 ` [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue Daniel Kurtz
2011-12-14 8:01 ` Oliver Neukum
2011-12-14 8:19 ` Daniel Kurtz
2011-12-14 8:19 ` Daniel Kurtz
2011-12-14 9:25 ` Oliver Neukum
[not found] ` <201112140901.35203.oneukum-l3A5Bk7waGM@public.gmane.org>
2011-12-14 10:33 ` Daniel Kurtz
2011-12-14 10:33 ` Daniel Kurtz
2011-12-14 11:22 ` Oliver Neukum [this message]
2011-12-15 6:43 ` Daniel Kurtz
2011-12-15 6:43 ` Daniel Kurtz
2011-12-15 9:01 ` Oliver Neukum
[not found] ` <201112151001.52761.oneukum-l3A5Bk7waGM@public.gmane.org>
2011-12-20 10:12 ` Daniel Kurtz
2011-12-20 10:12 ` Daniel Kurtz
2011-12-20 10:18 ` Oliver Neukum
2011-12-20 10:18 ` Oliver Neukum
2011-12-21 10:19 ` Jiri Kosina
[not found] ` <1321529030-7845-1-git-send-email-djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-07 2:42 ` [PATCH 0/3 v2] usb/hid-core: drain URB queue when going to suspend Daniel Kurtz
2011-12-07 2:42 ` Daniel Kurtz
2011-12-07 9:27 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2011-11-01 9:25 [PATCH 0/3] " Daniel Kurtz
2011-11-01 9:25 ` [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue Daniel Kurtz
2011-11-07 14:48 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112141222.41006.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.