From: Oliver Neukum <oneukum@suse.de>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: jkosina@suse.cz, bleung@chromium.org, stern@rowland.harvard.edu,
olofj@chromium.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue
Date: Tue, 20 Dec 2011 11:18:24 +0100 [thread overview]
Message-ID: <201112201118.24342.oneukum@suse.de> (raw)
In-Reply-To: <CAGS+omCLU6FAxmT3+TgYf0b8YvgfbH9CL9M6WpZ0yNS01O5Hrw@mail.gmail.com>
Am Dienstag, 20. Dezember 2011, 11:12:37 schrieb Daniel Kurtz:
> > > Could you please be more specific about what this patch breaks and
> > > perhaps give some guidance on how to fix it?
> >
> > It breaks nothing. It just continues a bug and I assumed it was not present.
> > Basically the work queue must do nothing after pre_reset() and post_reset()
> > ought to rerun the work in case some request came down during that time.
>
> So, is this an Ack for this patchset?
> Can we fix any existing races in later patches?
Very well. You are fixing a bad bug and not making matters worse.
Acked-by: Oliver Neukum <oneukum@suse.de>
Regards
Oliver
--
- - -
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstraße 5
90409 Nürnberg
Germany
- - -
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.de>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: jkosina@suse.cz, bleung@chromium.org, stern@rowland.harvard.edu,
olofj@chromium.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue
Date: Tue, 20 Dec 2011 11:18:24 +0100 [thread overview]
Message-ID: <201112201118.24342.oneukum@suse.de> (raw)
In-Reply-To: <CAGS+omCLU6FAxmT3+TgYf0b8YvgfbH9CL9M6WpZ0yNS01O5Hrw@mail.gmail.com>
Am Dienstag, 20. Dezember 2011, 11:12:37 schrieb Daniel Kurtz:
> > > Could you please be more specific about what this patch breaks and
> > > perhaps give some guidance on how to fix it?
> >
> > It breaks nothing. It just continues a bug and I assumed it was not present.
> > Basically the work queue must do nothing after pre_reset() and post_reset()
> > ought to rerun the work in case some request came down during that time.
>
> So, is this an Ack for this patchset?
> Can we fix any existing races in later patches?
Very well. You are fixing a bad bug and not making matters worse.
Acked-by: Oliver Neukum <oneukum@suse.de>
Regards
Oliver
--
- - -
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstraße 5
90409 Nürnberg
Germany
- - -
next prev parent reply other threads:[~2011-12-20 10:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 11:23 [PATCH 0/3 v2] usb/hid-core: drain URB queue when going to suspend Daniel Kurtz
2011-11-17 11:23 ` [PATCH 1/3] HID: usbhid: remove LED_ON Daniel Kurtz
2011-11-17 11:23 ` [PATCH 2/3] HID: usbhid: hid-core: submit queued urbs before suspend Daniel Kurtz
2011-12-14 7:55 ` Oliver Neukum
2011-12-14 8:00 ` Daniel Kurtz
2011-12-14 8:00 ` Daniel Kurtz
[not found] ` <CAGS+omDMipRTVOGV9fG0ciWpuwMRBL-eTY8uDwaiSOW==CkQ-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-14 9:14 ` Oliver Neukum
2011-12-14 9:14 ` Oliver Neukum
2011-12-14 9:41 ` Daniel Kurtz
2011-12-14 9:41 ` Daniel Kurtz
2011-12-14 11:36 ` Oliver Neukum
2011-11-17 11:23 ` [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue Daniel Kurtz
2011-12-14 8:01 ` Oliver Neukum
2011-12-14 8:19 ` Daniel Kurtz
2011-12-14 8:19 ` Daniel Kurtz
2011-12-14 9:25 ` Oliver Neukum
[not found] ` <201112140901.35203.oneukum-l3A5Bk7waGM@public.gmane.org>
2011-12-14 10:33 ` Daniel Kurtz
2011-12-14 10:33 ` Daniel Kurtz
2011-12-14 11:22 ` Oliver Neukum
2011-12-15 6:43 ` Daniel Kurtz
2011-12-15 6:43 ` Daniel Kurtz
2011-12-15 9:01 ` Oliver Neukum
[not found] ` <201112151001.52761.oneukum-l3A5Bk7waGM@public.gmane.org>
2011-12-20 10:12 ` Daniel Kurtz
2011-12-20 10:12 ` Daniel Kurtz
2011-12-20 10:18 ` Oliver Neukum [this message]
2011-12-20 10:18 ` Oliver Neukum
2011-12-21 10:19 ` Jiri Kosina
[not found] ` <1321529030-7845-1-git-send-email-djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-07 2:42 ` [PATCH 0/3 v2] usb/hid-core: drain URB queue when going to suspend Daniel Kurtz
2011-12-07 2:42 ` Daniel Kurtz
2011-12-07 9:27 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2011-11-01 9:25 [PATCH 0/3] " Daniel Kurtz
2011-11-01 9:25 ` [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue Daniel Kurtz
2011-11-07 14:48 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112201118.24342.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.