From: Tony Lindgren <tony@atomide.com>
To: Dave Martin <dave.martin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, patches@linaro.org,
Anton Vorontsov <avorontsov@mvista.com>,
Barry Song <baohua.song@csr.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Colin Cross <ccross@google.com>,
Haojian Zhuang <haojian.zhuang@marvell.com>,
John Linn <john.linn@xilinx.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-tegra@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Paul Mundt <lethal@linux-sh.org>, Pawel Moll <pawel.moll@arm.com>,
Rob Herring <rob.herring@calxeda.com>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support
Date: Wed, 14 Dec 2011 10:14:25 -0800 [thread overview]
Message-ID: <20111214181425.GB32251@atomide.com> (raw)
In-Reply-To: <1323862781-3465-4-git-send-email-dave.martin@linaro.org>
* Dave Martin <dave.martin@linaro.org> [111214 03:08]:
> If running in the Normal World on a TrustZone-enabled SoC, Linux
> does not have complete control over the L2 cache controller
> configuration. The kernel cannot work reliably on such platforms
> without the l2x0 cache support code built in.
There are HS and GP omaps (High Security and General Purpose).
GP omaps do have full control of the L2. Also HS omaps most likely
provide control over enabling and disabling L2 depending how the
secure code is implemented.
BTW, the real problem is that because the secure code is implemented
in various ways, we don't really have any handling for it in Linux.
The SMI instruction numbers don't seem to be standardized at all,
and can mean different things on different boards, even different
board versions :(
Sounds like devicetree is the only safe way to deal with the L2
control options.
Regards,
Tony
> This patch unconditionally enables l2x0 support for the OMAP4 SoCs.
>
> Thanks to Rob Herring for this suggestion. [1]
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074495.html
> ---
> arch/arm/mach-omap2/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index bb1b670..94e568a 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -41,11 +41,11 @@ config ARCH_OMAP4
> bool "TI OMAP4"
> default y
> depends on ARCH_OMAP2PLUS
> + select CACHE_L2X0
> select CPU_V7
> select ARM_GIC
> select HAVE_SMP
> select LOCAL_TIMERS if SMP
> - select MIGHT_HAVE_CACHE_L2X0
> select PL310_ERRATA_588369
> select PL310_ERRATA_727915
> select ARM_ERRATA_720789
> --
> 1.7.4.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2
Date: Wed, 14 Dec 2011 18:14:25 +0000 [thread overview]
Message-ID: <20111214181425.GB32251@atomide.com> (raw)
In-Reply-To: <1323862781-3465-4-git-send-email-dave.martin@linaro.org>
* Dave Martin <dave.martin@linaro.org> [111214 03:08]:
> If running in the Normal World on a TrustZone-enabled SoC, Linux
> does not have complete control over the L2 cache controller
> configuration. The kernel cannot work reliably on such platforms
> without the l2x0 cache support code built in.
There are HS and GP omaps (High Security and General Purpose).
GP omaps do have full control of the L2. Also HS omaps most likely
provide control over enabling and disabling L2 depending how the
secure code is implemented.
BTW, the real problem is that because the secure code is implemented
in various ways, we don't really have any handling for it in Linux.
The SMI instruction numbers don't seem to be standardized at all,
and can mean different things on different boards, even different
board versions :(
Sounds like devicetree is the only safe way to deal with the L2
control options.
Regards,
Tony
> This patch unconditionally enables l2x0 support for the OMAP4 SoCs.
>
> Thanks to Rob Herring for this suggestion. [1]
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074495.html
> ---
> arch/arm/mach-omap2/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index bb1b670..94e568a 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -41,11 +41,11 @@ config ARCH_OMAP4
> bool "TI OMAP4"
> default y
> depends on ARCH_OMAP2PLUS
> + select CACHE_L2X0
> select CPU_V7
> select ARM_GIC
> select HAVE_SMP
> select LOCAL_TIMERS if SMP
> - select MIGHT_HAVE_CACHE_L2X0
> select PL310_ERRATA_588369
> select PL310_ERRATA_727915
> select ARM_ERRATA_720789
> --
> 1.7.4.1
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support
Date: Wed, 14 Dec 2011 10:14:25 -0800 [thread overview]
Message-ID: <20111214181425.GB32251@atomide.com> (raw)
In-Reply-To: <1323862781-3465-4-git-send-email-dave.martin@linaro.org>
* Dave Martin <dave.martin@linaro.org> [111214 03:08]:
> If running in the Normal World on a TrustZone-enabled SoC, Linux
> does not have complete control over the L2 cache controller
> configuration. The kernel cannot work reliably on such platforms
> without the l2x0 cache support code built in.
There are HS and GP omaps (High Security and General Purpose).
GP omaps do have full control of the L2. Also HS omaps most likely
provide control over enabling and disabling L2 depending how the
secure code is implemented.
BTW, the real problem is that because the secure code is implemented
in various ways, we don't really have any handling for it in Linux.
The SMI instruction numbers don't seem to be standardized at all,
and can mean different things on different boards, even different
board versions :(
Sounds like devicetree is the only safe way to deal with the L2
control options.
Regards,
Tony
> This patch unconditionally enables l2x0 support for the OMAP4 SoCs.
>
> Thanks to Rob Herring for this suggestion. [1]
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074495.html
> ---
> arch/arm/mach-omap2/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index bb1b670..94e568a 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -41,11 +41,11 @@ config ARCH_OMAP4
> bool "TI OMAP4"
> default y
> depends on ARCH_OMAP2PLUS
> + select CACHE_L2X0
> select CPU_V7
> select ARM_GIC
> select HAVE_SMP
> select LOCAL_TIMERS if SMP
> - select MIGHT_HAVE_CACHE_L2X0
> select PL310_ERRATA_588369
> select PL310_ERRATA_727915
> select ARM_ERRATA_720789
> --
> 1.7.4.1
>
next prev parent reply other threads:[~2011-12-14 18:14 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 11:39 [PATCH v4 REPOST 0/5] Refactor common Kconfigs for easier maintenance Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 11:39 ` [PATCH v4 REPOST 1/5] ARM: l2x0/pl310: Refactor Kconfig to be more maintainable Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 12:03 ` Anton Vorontsov
2011-12-14 12:03 ` Anton Vorontsov
2011-12-14 12:03 ` [PATCH v4 REPOST 1/5] ARM: l2x0/pl310: Refactor Kconfig to be Anton Vorontsov
2011-12-14 18:15 ` [PATCH v4 REPOST 1/5] ARM: l2x0/pl310: Refactor Kconfig to be more maintainable Tony Lindgren
2011-12-14 18:15 ` Tony Lindgren
2011-12-14 18:15 ` [PATCH v4 REPOST 1/5] ARM: l2x0/pl310: Refactor Kconfig to be Tony Lindgren
2011-12-14 11:39 ` [PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more maintainable Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 11:39 ` Dave Martin
[not found] ` <1323862781-3465-3-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-12-14 18:16 ` Tony Lindgren
2011-12-14 18:16 ` Tony Lindgren
2011-12-14 18:16 ` [PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more Tony Lindgren
2011-12-15 18:14 ` [PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more maintainable David Brown
2011-12-15 18:14 ` David Brown
2011-12-15 18:14 ` [PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more David Brown
2011-12-16 0:31 ` [PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more maintainable David Brown
2011-12-16 0:31 ` David Brown
2011-12-16 0:31 ` [PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more David Brown
2011-12-14 11:39 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 18:14 ` Tony Lindgren [this message]
2011-12-14 18:14 ` Tony Lindgren
2011-12-14 18:14 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 Tony Lindgren
[not found] ` <20111214181425.GB32251-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2011-12-14 18:30 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support Dave Martin
2011-12-14 18:30 ` Dave Martin
2011-12-14 18:30 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 Dave Martin
2011-12-14 18:39 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support Tony Lindgren
2011-12-14 18:39 ` Tony Lindgren
2011-12-14 18:39 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 Tony Lindgren
[not found] ` <20111214183952.GG32251-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2011-12-14 21:01 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support Rob Herring
2011-12-14 21:01 ` Rob Herring
2011-12-14 21:01 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 Rob Herring
2011-12-14 21:48 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support Tony Lindgren
2011-12-14 21:48 ` Tony Lindgren
2011-12-14 21:48 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 Tony Lindgren
2011-12-14 11:39 ` [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 L2 cache controller support Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 13:37 ` Rob Herring
2011-12-14 13:37 ` Rob Herring
2011-12-14 13:37 ` [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 Rob Herring
2011-12-14 13:55 ` [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 L2 cache controller support Dave Martin
2011-12-14 13:55 ` Dave Martin
2011-12-14 13:55 ` [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 L2 Dave Martin
[not found] ` <1323862781-3465-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-12-14 11:39 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 11:39 ` Dave Martin
2011-12-14 13:26 ` Shawn Guo
2011-12-14 13:26 ` Shawn Guo
2011-12-14 13:26 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on Shawn Guo
2011-12-14 14:05 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Richard Zhao
2011-12-14 14:05 ` Richard Zhao
2011-12-14 14:05 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on Richard Zhao
2011-12-14 15:01 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Dave Martin
2011-12-14 15:01 ` Dave Martin
2011-12-14 15:01 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on Dave Martin
[not found] ` <20111214150119.GD2568-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-12-15 1:02 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Richard Zhao
2011-12-15 1:02 ` Richard Zhao
2011-12-15 1:02 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on Richard Zhao
2011-12-15 1:46 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Shawn Guo
2011-12-15 1:46 ` Shawn Guo
2011-12-15 1:46 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on Shawn Guo
2011-12-15 1:54 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Richard Zhao
2011-12-15 1:54 ` Richard Zhao
2011-12-15 1:54 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on Richard Zhao
[not found] ` <20111215015414.GQ28768-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
2011-12-15 15:14 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Dave Martin
2011-12-15 15:14 ` Dave Martin
2011-12-15 15:14 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214181425.GB32251@atomide.com \
--to=tony@atomide.com \
--cc=avorontsov@mvista.com \
--cc=baohua.song@csr.com \
--cc=catalin.marinas@arm.com \
--cc=ccross@google.com \
--cc=dave.martin@linaro.org \
--cc=haojian.zhuang@marvell.com \
--cc=john.linn@xilinx.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=patches@linaro.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.