From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tero Kristo <t-kristo@ti.com>,
Govindraj R <govindraj.raja@ti.com>
Subject: Re: [PATCH 1/9] ARM: OMAP2+: mux: add wakeup-capable hwmod mux entries to dynamic list
Date: Thu, 15 Dec 2011 13:41:09 -0800 [thread overview]
Message-ID: <20111215214109.GX32251@atomide.com> (raw)
In-Reply-To: <20111215213609.26632.43406.stgit@dusk>
* Paul Walmsley <paul@pwsan.com> [111215 13:05]:
> omap_hwmod_mux() currently only iterates through the dynamic pad list.
> This list currently only consists of pads with the
> OMAP_DEVICE_MUX_REMUX flag set.
>
> Subsequent patches in this series will cause hwmod mux entries with
> the OMAP_DEVICE_MUX_WAKEUP flag set to be changed dynamically, to
> control hwmod I/O ring wakeup. For this to work correctly, hwmod mux
> entries with the OMAP_DEVICE_MUX_WAKEUP flag set must also be added to
> the dynamic pad list. So this patch modifies omap_hwmod_mux_init() to
> do so.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Govindraj R <govindraj.raja@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/mux.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> index 655e948..a474c81 100644
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -306,7 +306,8 @@ omap_hwmod_mux_init(struct omap_device_pad *bpads, int nr_pads)
> pad->idle = bpad->idle;
> pad->off = bpad->off;
>
> - if (pad->flags & OMAP_DEVICE_PAD_REMUX)
> + if (pad->flags &
> + (OMAP_DEVICE_PAD_REMUX | OMAP_DEVICE_PAD_WAKEUP))
> nr_pads_dynamic++;
>
> pr_debug("%s: Initialized %s\n", __func__, pad->name);
> @@ -331,7 +332,8 @@ omap_hwmod_mux_init(struct omap_device_pad *bpads, int nr_pads)
> for (i = 0; i < hmux->nr_pads; i++) {
> struct omap_device_pad *pad = &hmux->pads[i];
>
> - if (pad->flags & OMAP_DEVICE_PAD_REMUX) {
> + if (pad->flags &
> + (OMAP_DEVICE_PAD_REMUX | OMAP_DEVICE_PAD_WAKEUP)) {
> pr_debug("%s: pad %s tagged dynamic\n",
> __func__, pad->name);
> hmux->pads_dynamic[nr_pads_dynamic] = pad;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] ARM: OMAP2+: mux: add wakeup-capable hwmod mux entries to dynamic list
Date: Thu, 15 Dec 2011 13:41:09 -0800 [thread overview]
Message-ID: <20111215214109.GX32251@atomide.com> (raw)
In-Reply-To: <20111215213609.26632.43406.stgit@dusk>
* Paul Walmsley <paul@pwsan.com> [111215 13:05]:
> omap_hwmod_mux() currently only iterates through the dynamic pad list.
> This list currently only consists of pads with the
> OMAP_DEVICE_MUX_REMUX flag set.
>
> Subsequent patches in this series will cause hwmod mux entries with
> the OMAP_DEVICE_MUX_WAKEUP flag set to be changed dynamically, to
> control hwmod I/O ring wakeup. For this to work correctly, hwmod mux
> entries with the OMAP_DEVICE_MUX_WAKEUP flag set must also be added to
> the dynamic pad list. So this patch modifies omap_hwmod_mux_init() to
> do so.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Govindraj R <govindraj.raja@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/mux.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> index 655e948..a474c81 100644
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -306,7 +306,8 @@ omap_hwmod_mux_init(struct omap_device_pad *bpads, int nr_pads)
> pad->idle = bpad->idle;
> pad->off = bpad->off;
>
> - if (pad->flags & OMAP_DEVICE_PAD_REMUX)
> + if (pad->flags &
> + (OMAP_DEVICE_PAD_REMUX | OMAP_DEVICE_PAD_WAKEUP))
> nr_pads_dynamic++;
>
> pr_debug("%s: Initialized %s\n", __func__, pad->name);
> @@ -331,7 +332,8 @@ omap_hwmod_mux_init(struct omap_device_pad *bpads, int nr_pads)
> for (i = 0; i < hmux->nr_pads; i++) {
> struct omap_device_pad *pad = &hmux->pads[i];
>
> - if (pad->flags & OMAP_DEVICE_PAD_REMUX) {
> + if (pad->flags &
> + (OMAP_DEVICE_PAD_REMUX | OMAP_DEVICE_PAD_WAKEUP)) {
> pr_debug("%s: pad %s tagged dynamic\n",
> __func__, pad->name);
> hmux->pads_dynamic[nr_pads_dynamic] = pad;
>
>
next prev parent reply other threads:[~2011-12-15 21:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 21:36 [PATCHv12 0/9] OMAP3+: PRCM chain handler Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:36 ` [PATCH 1/9] ARM: OMAP2+: mux: add wakeup-capable hwmod mux entries to dynamic list Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:41 ` Tony Lindgren [this message]
2011-12-15 21:41 ` Tony Lindgren
2011-12-15 21:36 ` [PATCH 2/9] ARM: OMAP2+: hwmod: Add API to enable IO ring wakeup Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:36 ` [PATCH 3/9] ARM: OMAP3/4: PRM: add functions to read pending IRQs, PRM barrier Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:36 ` [PATCH 4/9] ARM: OMAP: PRCM: add support for chain interrupt handler Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:36 ` [PATCH 5/9] ARM: OMAP: PRCM: add suspend prepare / finish support Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:36 ` [PATCH 6/9] ARM: OMAP2+: mux: add support for PAD wakeup interrupts Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:36 ` [PATCH 7/9] ARM: OMAP: hwmod: add support for selecting mpu_irq for each wakeup pad Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:36 ` [PATCH 8/9] ARM: OMAP3: pm: use prcm chain handler Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-15 21:36 ` [PATCH 9/9] ARM: OMAP4: PRM: use PRCM interrupt handler Paul Walmsley
2011-12-15 21:36 ` Paul Walmsley
2011-12-16 5:10 ` [PATCHv12 0/9] OMAP3+: PRCM chain handler Paul Walmsley
2011-12-16 5:10 ` Paul Walmsley
2011-12-16 12:57 ` Tero Kristo
2011-12-16 12:57 ` Tero Kristo
2012-01-09 5:31 ` Bedia, Vaibhav
2012-01-09 5:31 ` Bedia, Vaibhav
2012-01-10 1:19 ` Kevin Hilman
2012-01-10 1:19 ` Kevin Hilman
2012-01-10 11:41 ` Bedia, Vaibhav
2012-01-10 11:41 ` Bedia, Vaibhav
2012-01-10 15:13 ` Kevin Hilman
2012-01-10 15:13 ` Kevin Hilman
2012-01-11 13:49 ` Bedia, Vaibhav
2012-01-11 13:49 ` Bedia, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215214109.GX32251@atomide.com \
--to=tony@atomide.com \
--cc=govindraj.raja@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.