All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Mel Gorman <mgorman@suse.de>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH -mm] slub: document setting min order with debug_guardpage_minorder > 0
Date: Fri, 16 Dec 2011 14:21:56 +0100	[thread overview]
Message-ID: <20111216132155.GA14271@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1112131640240.32369@chino.kir.corp.google.com>

On Tue, Dec 13, 2011 at 04:41:34PM -0800, David Rientjes wrote:
> > > +		When debug_guardpage_minorder > 0 parameter is specified, the
> > > +		minimum possible order is used and cannot be changed.
> > 
> > Well, I'm not sure what you wanted to say, actually?  How does one change
> > debug_guardpage_minorder (or specify it), for example?  Is it a kernel
> > command-line switch?
> > 
> 
> Yeah, we'll need a reference to Documentation/kernel-parameters.txt.
> 
> > Also I'm not sure what "cannot be changed" is supposed to mean.  Does it
> > mean that /sys/cache/slab/cache/order has no effect in that case?
> > 
> 
> Good point, we should say that "this tunable" cannot be used to change the 
> order at runtime if debug_guardpage_minorder is used on the command line.
> 
> Stanislaw, one more revision?

Ehh, I silently hoped that someone else with better English skills could
fix it ;-)

As Andrew already applied my patch (and fix whitespace) I'll post the
incremental patch in the next e-mail.

Thanks
Stanislaw

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Mel Gorman <mgorman@suse.de>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH -mm] slub: document setting min order with debug_guardpage_minorder > 0
Date: Fri, 16 Dec 2011 14:21:56 +0100	[thread overview]
Message-ID: <20111216132155.GA14271@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1112131640240.32369@chino.kir.corp.google.com>

On Tue, Dec 13, 2011 at 04:41:34PM -0800, David Rientjes wrote:
> > > +		When debug_guardpage_minorder > 0 parameter is specified, the
> > > +		minimum possible order is used and cannot be changed.
> > 
> > Well, I'm not sure what you wanted to say, actually?  How does one change
> > debug_guardpage_minorder (or specify it), for example?  Is it a kernel
> > command-line switch?
> > 
> 
> Yeah, we'll need a reference to Documentation/kernel-parameters.txt.
> 
> > Also I'm not sure what "cannot be changed" is supposed to mean.  Does it
> > mean that /sys/cache/slab/cache/order has no effect in that case?
> > 
> 
> Good point, we should say that "this tunable" cannot be used to change the 
> order at runtime if debug_guardpage_minorder is used on the command line.
> 
> Stanislaw, one more revision?

Ehh, I silently hoped that someone else with better English skills could
fix it ;-)

As Andrew already applied my patch (and fix whitespace) I'll post the
incremental patch in the next e-mail.

Thanks
Stanislaw

  reply	other threads:[~2011-12-16 13:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 16:25 [PATCH v2 1/3] mm: more intensive memory corruption debug Stanislaw Gruszka
2011-11-18 16:25 ` Stanislaw Gruszka
2011-11-18 16:25 ` [PATCH v2 2/3] PM / Hibernate : do not count debug pages as savable Stanislaw Gruszka
2011-11-18 16:25   ` Stanislaw Gruszka
2011-11-18 16:25 ` [PATCH v3 3/3] slub: min order when debug_guardpage_minorder > 0 Stanislaw Gruszka
2011-11-18 16:25   ` Stanislaw Gruszka
2011-11-21 17:15   ` Christoph Lameter
2011-11-21 17:15     ` Christoph Lameter
2011-12-07 22:07   ` David Rientjes
2011-12-07 22:07     ` David Rientjes
2011-12-08  7:33     ` Stanislaw Gruszka
2011-12-08  7:33       ` Stanislaw Gruszka
2011-12-08 21:06       ` David Rientjes
2011-12-08 21:06         ` David Rientjes
2011-12-12 14:59         ` [PATCH -mm] slub: document setting min order with " Stanislaw Gruszka
2011-12-12 14:59           ` Stanislaw Gruszka
2011-12-12 23:21           ` Rafael J. Wysocki
2011-12-12 23:21             ` Rafael J. Wysocki
2011-12-14  0:41             ` David Rientjes
2011-12-14  0:41               ` David Rientjes
2011-12-16 13:21               ` Stanislaw Gruszka [this message]
2011-12-16 13:21                 ` Stanislaw Gruszka
2011-12-16 13:23                 ` [PATCH -mm] slub: debug_guardpage_minorder documentation tweak Stanislaw Gruszka
2011-12-16 13:23                   ` Stanislaw Gruszka
2011-12-16 21:16                   ` David Rientjes
2011-12-16 21:16                     ` David Rientjes
2012-01-06 17:52                     ` David Rientjes
2012-01-06 17:52                       ` David Rientjes
2011-11-22 21:56 ` [PATCH v2 1/3] mm: more intensive memory corruption debug Andrew Morton
2011-11-22 21:56   ` Andrew Morton
2011-11-23 13:25   ` Stanislaw Gruszka
2011-11-23 13:25     ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111216132155.GA14271@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=rientjes@google.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.