From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: b-cousson@ti.com, linux-omap@vger.kernel.org, rnayak@ti.com,
khilman@ti.com, govindraj.raja@ti.com,
linux-arm-kernel@lists.infradead.org,
linaro-dev@lists.linaro.org, robherring2@gmail.com
Subject: Re: [PATCH v4] ARM: OMAP2+: hwmod: Add a new flag to handle hwmods left enabled at init
Date: Fri, 16 Dec 2011 10:16:26 -0800 [thread overview]
Message-ID: <20111216181626.GC32251@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1112160544470.12660@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [111216 04:18]:
>
> From: Rajendra Nayak <rnayak@ti.com>
>
> An hwmod with a 'HWMOD_INIT_NO_IDLE' flag set, is left in
> enabled state by the hwmod framework post the initial setup.
> Once a real user of the device (a driver) tries to enable it
> at a later point, the hwmod framework throws a WARN() about
> the device being already in enabled state.
>
> Fix this by introducing a new internal flag '_HWMOD_SKIP_ENABLE' to
> identify such devices/hwmods. When the device/hwmod is requested to be
> enabled (the first time) by its driver/user, nothing except the
> mux-enable is needed. The mux data is board specific and is
> unavailable during initial enable() of the device, done by the
> framework as part of setup().
>
> A good example of a such a device is an UART used as debug console.
> The UART module needs to be kept enabled through the boot, until the
> UART driver takes control of it, for debug prints to appear on
> the console.
>
> Acked-by: Kevin Hilman <khilman@ti.com>
> Acked-by: Benoit Cousson <b-cousson@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> [paul@pwsan.com: use a flag rather than a state; updated commit message;
> edited some documentation]
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
Thanks I'll apply this into uart branch so I can pull Kevin's
changes on top of it.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: OMAP2+: hwmod: Add a new flag to handle hwmods left enabled at init
Date: Fri, 16 Dec 2011 10:16:26 -0800 [thread overview]
Message-ID: <20111216181626.GC32251@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1112160544470.12660@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [111216 04:18]:
>
> From: Rajendra Nayak <rnayak@ti.com>
>
> An hwmod with a 'HWMOD_INIT_NO_IDLE' flag set, is left in
> enabled state by the hwmod framework post the initial setup.
> Once a real user of the device (a driver) tries to enable it
> at a later point, the hwmod framework throws a WARN() about
> the device being already in enabled state.
>
> Fix this by introducing a new internal flag '_HWMOD_SKIP_ENABLE' to
> identify such devices/hwmods. When the device/hwmod is requested to be
> enabled (the first time) by its driver/user, nothing except the
> mux-enable is needed. The mux data is board specific and is
> unavailable during initial enable() of the device, done by the
> framework as part of setup().
>
> A good example of a such a device is an UART used as debug console.
> The UART module needs to be kept enabled through the boot, until the
> UART driver takes control of it, for debug prints to appear on
> the console.
>
> Acked-by: Kevin Hilman <khilman@ti.com>
> Acked-by: Benoit Cousson <b-cousson@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> [paul at pwsan.com: use a flag rather than a state; updated commit message;
> edited some documentation]
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
Thanks I'll apply this into uart branch so I can pull Kevin's
changes on top of it.
Regards,
Tony
next prev parent reply other threads:[~2011-12-16 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 12:50 [PATCH v4] ARM: OMAP2+: hwmod: Add a new flag to handle hwmods left enabled at init Paul Walmsley
2011-12-16 12:50 ` Paul Walmsley
2011-12-16 18:16 ` Tony Lindgren [this message]
2011-12-16 18:16 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216181626.GC32251@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=govindraj.raja@ti.com \
--cc=khilman@ti.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.