* [patch 2/2] NFC: use kfree_skb() for sk_buffs
@ 2011-12-16 20:26 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-12-16 20:26 UTC (permalink / raw)
To: Lauro Ramos Venancio
Cc: Aloisio Almeida Jr, Samuel Ortiz, John W. Linville,
linux-wireless, kernel-janitors
This is a struct sk_buff pointer and it should be freed with kfree_skb()
instead of kfree().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c
index f99d6b4..1d32680 100644
--- a/net/nfc/llcp/llcp.c
+++ b/net/nfc/llcp/llcp.c
@@ -954,7 +954,7 @@ void nfc_llcp_unregister_device(struct nfc_dev *dev)
skb_queue_purge(&local->tx_queue);
destroy_workqueue(local->tx_wq);
destroy_workqueue(local->rx_wq);
- kfree(local->rx_pending);
+ kfree_skb(local->rx_pending);
kfree(local);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch 2/2] NFC: use kfree_skb() for sk_buffs
@ 2011-12-16 20:26 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-12-16 20:26 UTC (permalink / raw)
To: Lauro Ramos Venancio
Cc: Aloisio Almeida Jr, Samuel Ortiz, John W. Linville,
linux-wireless, kernel-janitors
This is a struct sk_buff pointer and it should be freed with kfree_skb()
instead of kfree().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c
index f99d6b4..1d32680 100644
--- a/net/nfc/llcp/llcp.c
+++ b/net/nfc/llcp/llcp.c
@@ -954,7 +954,7 @@ void nfc_llcp_unregister_device(struct nfc_dev *dev)
skb_queue_purge(&local->tx_queue);
destroy_workqueue(local->tx_wq);
destroy_workqueue(local->rx_wq);
- kfree(local->rx_pending);
+ kfree_skb(local->rx_pending);
kfree(local);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch 2/2] NFC: use kfree_skb() for sk_buffs
2011-12-16 20:26 ` Dan Carpenter
@ 2011-12-18 20:43 ` Samuel Ortiz
-1 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2011-12-18 20:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lauro Ramos Venancio, Aloisio Almeida Jr, John W. Linville,
linux-wireless, kernel-janitors
Hi Dan,
On Fri, Dec 16, 2011 at 11:26:00PM +0300, Dan Carpenter wrote:
> This is a struct sk_buff pointer and it should be freed with kfree_skb()
> instead of kfree().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 2/2] NFC: use kfree_skb() for sk_buffs
@ 2011-12-18 20:43 ` Samuel Ortiz
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2011-12-18 20:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lauro Ramos Venancio, Aloisio Almeida Jr, John W. Linville,
linux-wireless, kernel-janitors
Hi Dan,
On Fri, Dec 16, 2011 at 11:26:00PM +0300, Dan Carpenter wrote:
> This is a struct sk_buff pointer and it should be freed with kfree_skb()
> instead of kfree().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-18 20:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-16 20:26 [patch 2/2] NFC: use kfree_skb() for sk_buffs Dan Carpenter
2011-12-16 20:26 ` Dan Carpenter
2011-12-18 20:43 ` Samuel Ortiz
2011-12-18 20:43 ` Samuel Ortiz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.