From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: Konrad Rzeszutek Wilk <konrad@darnok.org>, Xen-devel@lists.xensource.com
Subject: Re: [PATCH 1/6] xenbus: Support HVM backends
Date: Mon, 19 Dec 2011 14:23:54 -0500 [thread overview]
Message-ID: <20111219192354.GA5413@phenom.dumpdata.com> (raw)
In-Reply-To: <4EEF866F.1030002@tycho.nsa.gov>
> >>>Then these 'xenbus_map_ring_valloc' end up just using the
> >>>ring_ops->map call.
> >>
> >>Is the reason for doing this just to avoid overhead? The overhead from
> >>an indirect function call is much higher than from an integer comparison
> >>(which is what xen_pv_domain resolves to). In this case, the _pv and _hvm
> >>functions are both inlined into the dispatch function.
> >
> >Do we care about that? How often are these calls made?
>
> Not all that often - domain creation and destruction or device plug/unplug.
> So performance doesn't really matter. Is there a reason to prefer an _ops
> structure for this instead of direct calls?
Looks cleaner and fits the bill of where the rest of the Linux kernel is
going with using func structs for most everything.
next prev parent reply other threads:[~2011-12-19 19:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 20:12 [PATCH v3 0/6] xen/{net, blk}back support for running in HVM Daniel De Graaf
2011-12-14 20:12 ` [PATCH 1/6] xenbus: Support HVM backends Daniel De Graaf
2011-12-15 14:13 ` David Vrabel
2011-12-15 14:38 ` Daniel De Graaf
2011-12-16 19:56 ` Konrad Rzeszutek Wilk
2011-12-19 17:51 ` Daniel De Graaf
2011-12-19 17:54 ` [PATCH 1/6 v2] " Daniel De Graaf
2011-12-19 18:16 ` [PATCH 1/6] " Konrad Rzeszutek Wilk
2011-12-19 18:46 ` Daniel De Graaf
2011-12-19 19:23 ` Konrad Rzeszutek Wilk [this message]
2011-12-19 19:55 ` [PATCH 1/6 v3] " Daniel De Graaf
2011-12-14 20:12 ` [PATCH 2/6] xenbus: Use grant-table wrapper functions Daniel De Graaf
2011-12-16 20:09 ` Konrad Rzeszutek Wilk
2011-12-14 20:12 ` [PATCH 3/6] xen/grant-table: Support mappings required by blkback Daniel De Graaf
2011-12-14 20:12 ` [PATCH 4/6] xen/blkback: use grant-table.c hypercall wrappers Daniel De Graaf
2011-12-16 20:17 ` Konrad Rzeszutek Wilk
2011-12-20 15:58 ` Konrad Rzeszutek Wilk
2011-12-14 20:12 ` [PATCH 5/6] xen/netback: Enable netback on HVM guests Daniel De Graaf
2011-12-19 10:33 ` Ian Campbell
2011-12-14 20:12 ` [PATCH 6/6] xen/blkback: Enable blkback " Daniel De Graaf
2011-12-20 15:45 ` Konrad Rzeszutek Wilk
2011-12-16 20:20 ` [PATCH v3 0/6] xen/{net, blk}back support for running in HVM Konrad Rzeszutek Wilk
2011-12-20 15:55 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2011-10-18 20:26 [PATCH 0/5] " Daniel De Graaf
2011-10-20 15:35 ` [PATCH v2 0/6] " Daniel De Graaf
2011-10-20 15:35 ` [PATCH 1/6] xenbus: Support HVM backends Daniel De Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219192354.GA5413@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Xen-devel@lists.xensource.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=konrad@darnok.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.