All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Xen-devel@lists.xensource.com, konrad.wilk@oracle.com
Subject: Re: [PATCH 1/6] xenbus: Support HVM backends
Date: Thu, 15 Dec 2011 09:38:47 -0500	[thread overview]
Message-ID: <4EEA0677.5060100@tycho.nsa.gov> (raw)
In-Reply-To: <4EEA008E.5050002@citrix.com>

On 12/15/2011 09:13 AM, David Vrabel wrote:
> On 14/12/11 20:12, Daniel De Graaf wrote:
>> Add HVM implementations of xenbus_(map,unmap)_ring_v(alloc,free) so
>> that ring mappings can be done without using GNTMAP_contains_pte which
>> is not supported on HVM.
> 
> Perhaps rename the functions to xenbus_map_ring() and
> xenbus_unmap_ring()?  I wouldn't respin the series just for this though.
> 
> Is there merit in having the pv and hvm variants, instead of just the
> hvm variant?
> 
> David
> 

There are already functions called xenbus_{map,unmap}_ring - they do the
actual mapping in the HVM case, with the _valloc versions just adding in
memory alloc/free.

The PV versions are slightly faster because they won't require additional
page table updates. Otherwise, I believe that the HVM variant should work
on both PV&HVM.

-- 
Daniel De Graaf
National Security Agency

  reply	other threads:[~2011-12-15 14:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 20:12 [PATCH v3 0/6] xen/{net, blk}back support for running in HVM Daniel De Graaf
2011-12-14 20:12 ` [PATCH 1/6] xenbus: Support HVM backends Daniel De Graaf
2011-12-15 14:13   ` David Vrabel
2011-12-15 14:38     ` Daniel De Graaf [this message]
2011-12-16 19:56   ` Konrad Rzeszutek Wilk
2011-12-19 17:51     ` Daniel De Graaf
2011-12-19 17:54       ` [PATCH 1/6 v2] " Daniel De Graaf
2011-12-19 18:16       ` [PATCH 1/6] " Konrad Rzeszutek Wilk
2011-12-19 18:46         ` Daniel De Graaf
2011-12-19 19:23           ` Konrad Rzeszutek Wilk
2011-12-19 19:55             ` [PATCH 1/6 v3] " Daniel De Graaf
2011-12-14 20:12 ` [PATCH 2/6] xenbus: Use grant-table wrapper functions Daniel De Graaf
2011-12-16 20:09   ` Konrad Rzeszutek Wilk
2011-12-14 20:12 ` [PATCH 3/6] xen/grant-table: Support mappings required by blkback Daniel De Graaf
2011-12-14 20:12 ` [PATCH 4/6] xen/blkback: use grant-table.c hypercall wrappers Daniel De Graaf
2011-12-16 20:17   ` Konrad Rzeszutek Wilk
2011-12-20 15:58   ` Konrad Rzeszutek Wilk
2011-12-14 20:12 ` [PATCH 5/6] xen/netback: Enable netback on HVM guests Daniel De Graaf
2011-12-19 10:33   ` Ian Campbell
2011-12-14 20:12 ` [PATCH 6/6] xen/blkback: Enable blkback " Daniel De Graaf
2011-12-20 15:45   ` Konrad Rzeszutek Wilk
2011-12-16 20:20 ` [PATCH v3 0/6] xen/{net, blk}back support for running in HVM Konrad Rzeszutek Wilk
2011-12-20 15:55 ` Konrad Rzeszutek Wilk
  -- strict thread matches above, loose matches on Subject: below --
2011-10-18 20:26 [PATCH 0/5] " Daniel De Graaf
2011-10-20 15:35 ` [PATCH v2 0/6] " Daniel De Graaf
2011-10-20 15:35   ` [PATCH 1/6] xenbus: Support HVM backends Daniel De Graaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EEA0677.5060100@tycho.nsa.gov \
    --to=dgdegra@tycho.nsa.gov \
    --cc=Xen-devel@lists.xensource.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.