* [PATCH 0/3] Samsung S5P platform modification required for G2D driver
@ 2011-12-09 16:04 Kamil Debski
2011-12-09 16:04 ` [PATCH 1/3] s5p-g2d: add G2D to plat-s5p and mach-exynos4 Kamil Debski
` (3 more replies)
0 siblings, 4 replies; 16+ messages in thread
From: Kamil Debski @ 2011-12-09 16:04 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: m.szyprowski, kyungmin.park, k.debski, kgene.kim
Hi,
This series of patches contains necessary platform modification required by the
G2D driver. G2D is a 2D-graphics acceleration engine present in the S5PC110 and
Exynos4 Samsung SoCs.
The patches have been rebased to the newest kgene/for-next branch. The driver
is currently staging for 3.3 in Mauro's repository, so please include these
patches for the next release.
Best wishes,
Kamil Debski
Kamil Debski (3):
s5p-g2d: add G2D to plat-s5p and mach-exynos4
s5p-g2d: add G2D to mach-nuri
s5p-g2d: add G2D to mach-universal
arch/arm/mach-exynos/Kconfig | 2 ++
arch/arm/mach-exynos/include/mach/map.h | 3 +++
arch/arm/mach-exynos/mach-nuri.c | 1 +
arch/arm/mach-exynos/mach-universal_c210.c | 1 +
arch/arm/plat-s5p/Kconfig | 5 +++++
arch/arm/plat-samsung/devs.c | 28 ++++++++++++++++++++++++++++
arch/arm/plat-samsung/include/plat/devs.h | 1 +
7 files changed, 41 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 1/3] s5p-g2d: add G2D to plat-s5p and mach-exynos4 2011-12-09 16:04 [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kamil Debski @ 2011-12-09 16:04 ` Kamil Debski 2011-12-24 3:12 ` Kukjin Kim 2011-12-09 16:04 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski ` (2 subsequent siblings) 3 siblings, 1 reply; 16+ messages in thread From: Kamil Debski @ 2011-12-09 16:04 UTC (permalink / raw) To: linux-samsung-soc; +Cc: m.szyprowski, kyungmin.park, k.debski, kgene.kim Signed-off-by: Kamil Debski <k.debski@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-exynos/include/mach/map.h | 3 +++ arch/arm/plat-s5p/Kconfig | 5 +++++ arch/arm/plat-samsung/devs.c | 28 ++++++++++++++++++++++++++++ arch/arm/plat-samsung/include/plat/devs.h | 1 + 4 files changed, 37 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h index 03e2c99..e3321aa 100644 --- a/arch/arm/mach-exynos/include/mach/map.h +++ b/arch/arm/mach-exynos/include/mach/map.h @@ -31,6 +31,8 @@ #define EXYNOS4_PA_FIMC2 0x11820000 #define EXYNOS4_PA_FIMC3 0x11830000 +#define EXYNOS4_PA_G2D 0x12800000 + #define EXYNOS4_PA_I2S0 0x03830000 #define EXYNOS4_PA_I2S1 0xE3100000 #define EXYNOS4_PA_I2S2 0xE2A00000 @@ -156,6 +158,7 @@ #define S5P_PA_FIMC1 EXYNOS4_PA_FIMC1 #define S5P_PA_FIMC2 EXYNOS4_PA_FIMC2 #define S5P_PA_FIMC3 EXYNOS4_PA_FIMC3 +#define S5P_PA_G2D EXYNOS4_PA_G2D #define S5P_PA_FIMD0 EXYNOS4_PA_FIMD0 #define S5P_PA_HDMI EXYNOS4_PA_HDMI #define S5P_PA_IIC_HDMIPHY EXYNOS4_PA_IIC_HDMIPHY diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig index 9b9968f..5e6333c 100644 --- a/arch/arm/plat-s5p/Kconfig +++ b/arch/arm/plat-s5p/Kconfig @@ -79,6 +79,11 @@ config S5P_DEV_FIMC3 help Compile in platform device definitions for FIMC controller 3 +config S5P_DEV_G2D + bool + help + Compile in platform device definitions for G2D device + config S5P_DEV_FIMD0 bool help diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c index 4ca8b57..ec4848d 100644 --- a/arch/arm/plat-samsung/devs.c +++ b/arch/arm/plat-samsung/devs.c @@ -265,6 +265,34 @@ struct platform_device s5p_device_fimc3 = { }; #endif /* CONFIG_S5P_DEV_FIMC3 */ +/* G2D */ + +#ifdef CONFIG_S5P_DEV_G2D +static struct resource s5p_g2d_resource[] = { + [0] = { + .start = S5P_PA_G2D, + .end = S5P_PA_G2D + SZ_4K - 1, + .flags = IORESOURCE_MEM, + }, + [1] = { + .start = IRQ_2D, + .end = IRQ_2D, + .flags = IORESOURCE_IRQ, + }, +}; + +struct platform_device s5p_device_g2d = { + .name = "s5p-g2d", + .id = 0, + .num_resources = ARRAY_SIZE(s5p_g2d_resource), + .resource = s5p_g2d_resource, + .dev = { + .dma_mask = &samsung_device_dma_mask, + .coherent_dma_mask = DMA_BIT_MASK(32), + }, +}; +#endif /* CONFIG_S5P_DEV_G2D */ + /* FIMD0 */ #ifdef CONFIG_S5P_DEV_FIMD0 diff --git a/arch/arm/plat-samsung/include/plat/devs.h b/arch/arm/plat-samsung/include/plat/devs.h index ab633c9..d4e92e2 100644 --- a/arch/arm/plat-samsung/include/plat/devs.h +++ b/arch/arm/plat-samsung/include/plat/devs.h @@ -78,6 +78,7 @@ extern struct platform_device s5p_device_fimc1; extern struct platform_device s5p_device_fimc2; extern struct platform_device s5p_device_fimc3; extern struct platform_device s5p_device_fimc_md; +extern struct platform_device s5p_device_g2d; extern struct platform_device s5p_device_fimd0; extern struct platform_device s5p_device_hdmi; extern struct platform_device s5p_device_i2c_hdmiphy; -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* RE: [PATCH 1/3] s5p-g2d: add G2D to plat-s5p and mach-exynos4 2011-12-09 16:04 ` [PATCH 1/3] s5p-g2d: add G2D to plat-s5p and mach-exynos4 Kamil Debski @ 2011-12-24 3:12 ` Kukjin Kim 0 siblings, 0 replies; 16+ messages in thread From: Kukjin Kim @ 2011-12-24 3:12 UTC (permalink / raw) To: 'Kamil Debski', linux-samsung-soc; +Cc: m.szyprowski, kyungmin.park Kamil Debski wrote: > > Signed-off-by: Kamil Debski <k.debski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-exynos/include/mach/map.h | 3 +++ > arch/arm/plat-s5p/Kconfig | 5 +++++ > arch/arm/plat-samsung/devs.c | 28 ++++++++++++++++++++++++++++ > arch/arm/plat-samsung/include/plat/devs.h | 1 + > 4 files changed, 37 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach- > exynos/include/mach/map.h > index 03e2c99..e3321aa 100644 > --- a/arch/arm/mach-exynos/include/mach/map.h > +++ b/arch/arm/mach-exynos/include/mach/map.h > @@ -31,6 +31,8 @@ > #define EXYNOS4_PA_FIMC2 0x11820000 > #define EXYNOS4_PA_FIMC3 0x11830000 > > +#define EXYNOS4_PA_G2D 0x12800000 > + > #define EXYNOS4_PA_I2S0 0x03830000 > #define EXYNOS4_PA_I2S1 0xE3100000 > #define EXYNOS4_PA_I2S2 0xE2A00000 > @@ -156,6 +158,7 @@ > #define S5P_PA_FIMC1 EXYNOS4_PA_FIMC1 > #define S5P_PA_FIMC2 EXYNOS4_PA_FIMC2 > #define S5P_PA_FIMC3 EXYNOS4_PA_FIMC3 > +#define S5P_PA_G2D EXYNOS4_PA_G2D > #define S5P_PA_FIMD0 EXYNOS4_PA_FIMD0 > #define S5P_PA_HDMI EXYNOS4_PA_HDMI > #define S5P_PA_IIC_HDMIPHY EXYNOS4_PA_IIC_HDMIPHY > diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig > index 9b9968f..5e6333c 100644 > --- a/arch/arm/plat-s5p/Kconfig > +++ b/arch/arm/plat-s5p/Kconfig > @@ -79,6 +79,11 @@ config S5P_DEV_FIMC3 > help > Compile in platform device definitions for FIMC controller 3 > > +config S5P_DEV_G2D > + bool > + help > + Compile in platform device definitions for G2D device > + > config S5P_DEV_FIMD0 > bool > help > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c > index 4ca8b57..ec4848d 100644 > --- a/arch/arm/plat-samsung/devs.c > +++ b/arch/arm/plat-samsung/devs.c > @@ -265,6 +265,34 @@ struct platform_device s5p_device_fimc3 = { > }; > #endif /* CONFIG_S5P_DEV_FIMC3 */ > > +/* G2D */ > + > +#ifdef CONFIG_S5P_DEV_G2D > +static struct resource s5p_g2d_resource[] = { > + [0] = { > + .start = S5P_PA_G2D, > + .end = S5P_PA_G2D + SZ_4K - 1, > + .flags = IORESOURCE_MEM, > + }, > + [1] = { > + .start = IRQ_2D, > + .end = IRQ_2D, > + .flags = IORESOURCE_IRQ, > + }, > +}; > + > +struct platform_device s5p_device_g2d = { > + .name = "s5p-g2d", > + .id = 0, > + .num_resources = ARRAY_SIZE(s5p_g2d_resource), > + .resource = s5p_g2d_resource, > + .dev = { > + .dma_mask = &samsung_device_dma_mask, > + .coherent_dma_mask = DMA_BIT_MASK(32), > + }, > +}; > +#endif /* CONFIG_S5P_DEV_G2D */ > + > /* FIMD0 */ > > #ifdef CONFIG_S5P_DEV_FIMD0 > diff --git a/arch/arm/plat-samsung/include/plat/devs.h b/arch/arm/plat- > samsung/include/plat/devs.h > index ab633c9..d4e92e2 100644 > --- a/arch/arm/plat-samsung/include/plat/devs.h > +++ b/arch/arm/plat-samsung/include/plat/devs.h > @@ -78,6 +78,7 @@ extern struct platform_device s5p_device_fimc1; > extern struct platform_device s5p_device_fimc2; > extern struct platform_device s5p_device_fimc3; > extern struct platform_device s5p_device_fimc_md; > +extern struct platform_device s5p_device_g2d; > extern struct platform_device s5p_device_fimd0; > extern struct platform_device s5p_device_hdmi; > extern struct platform_device s5p_device_i2c_hdmiphy; > -- > 1.7.0.4 Hi Kamil, Please fix following with checkpatch. ERROR: trailing whitespace #47: FILE: arch/arm/plat-s5p/Kconfig:86: +^I $ ERROR: code indent should use tabs where possible #63: FILE: arch/arm/plat-samsung/devs.c:272: + [0] = {$ WARNING: please, no spaces at the start of a line #63: FILE: arch/arm/plat-samsung/devs.c:272: + [0] = {$ ERROR: code indent should use tabs where possible #64: FILE: arch/arm/plat-samsung/devs.c:273: + .start = S5P_PA_G2D,$ WARNING: please, no spaces at the start of a line #64: FILE: arch/arm/plat-samsung/devs.c:273: + .start = S5P_PA_G2D,$ ERROR: code indent should use tabs where possible #65: FILE: arch/arm/plat-samsung/devs.c:274: + .end = S5P_PA_G2D + SZ_4K - 1,$ WARNING: please, no spaces at the start of a line #65: FILE: arch/arm/plat-samsung/devs.c:274: + .end = S5P_PA_G2D + SZ_4K - 1,$ ERROR: code indent should use tabs where possible #66: FILE: arch/arm/plat-samsung/devs.c:275: + .flags = IORESOURCE_MEM,$ WARNING: please, no spaces at the start of a line #66: FILE: arch/arm/plat-samsung/devs.c:275: + .flags = IORESOURCE_MEM,$ ERROR: code indent should use tabs where possible #67: FILE: arch/arm/plat-samsung/devs.c:276: + },$ WARNING: please, no spaces at the start of a line #67: FILE: arch/arm/plat-samsung/devs.c:276: + },$ ERROR: code indent should use tabs where possible #68: FILE: arch/arm/plat-samsung/devs.c:277: + [1] = {$ WARNING: please, no spaces at the start of a line #68: FILE: arch/arm/plat-samsung/devs.c:277: + [1] = {$ ERROR: code indent should use tabs where possible #69: FILE: arch/arm/plat-samsung/devs.c:278: + .start = IRQ_2D,$ WARNING: please, no spaces at the start of a line #69: FILE: arch/arm/plat-samsung/devs.c:278: + .start = IRQ_2D,$ ERROR: code indent should use tabs where possible #70: FILE: arch/arm/plat-samsung/devs.c:279: + .end = IRQ_2D,$ WARNING: please, no spaces at the start of a line #70: FILE: arch/arm/plat-samsung/devs.c:279: + .end = IRQ_2D,$ ERROR: code indent should use tabs where possible #71: FILE: arch/arm/plat-samsung/devs.c:280: + .flags = IORESOURCE_IRQ,$ WARNING: please, no spaces at the start of a line #71: FILE: arch/arm/plat-samsung/devs.c:280: + .flags = IORESOURCE_IRQ,$ ERROR: code indent should use tabs where possible #72: FILE: arch/arm/plat-samsung/devs.c:281: + },$ WARNING: please, no spaces at the start of a line #72: FILE: arch/arm/plat-samsung/devs.c:281: + },$ ERROR: code indent should use tabs where possible #76: FILE: arch/arm/plat-samsung/devs.c:285: + .name = "s5p-g2d",$ WARNING: please, no spaces at the start of a line #76: FILE: arch/arm/plat-samsung/devs.c:285: + .name = "s5p-g2d",$ ERROR: code indent should use tabs where possible #77: FILE: arch/arm/plat-samsung/devs.c:286: + .id = 0,$ WARNING: please, no spaces at the start of a line #77: FILE: arch/arm/plat-samsung/devs.c:286: + .id = 0,$ ERROR: code indent should use tabs where possible #78: FILE: arch/arm/plat-samsung/devs.c:287: + .num_resources = ARRAY_SIZE(s5p_g2d_resource),$ WARNING: please, no spaces at the start of a line #78: FILE: arch/arm/plat-samsung/devs.c:287: + .num_resources = ARRAY_SIZE(s5p_g2d_resource),$ ERROR: code indent should use tabs where possible #79: FILE: arch/arm/plat-samsung/devs.c:288: + .resource = s5p_g2d_resource,$ WARNING: please, no spaces at the start of a line #79: FILE: arch/arm/plat-samsung/devs.c:288: + .resource = s5p_g2d_resource,$ ERROR: code indent should use tabs where possible #80: FILE: arch/arm/plat-samsung/devs.c:289: + .dev = {$ WARNING: please, no spaces at the start of a line #80: FILE: arch/arm/plat-samsung/devs.c:289: + .dev = {$ ERROR: code indent should use tabs where possible #81: FILE: arch/arm/plat-samsung/devs.c:290: + .dma_mask = &samsung_device_dma_mask,$ WARNING: please, no spaces at the start of a line #81: FILE: arch/arm/plat-samsung/devs.c:290: + .dma_mask = &samsung_device_dma_mask,$ ERROR: code indent should use tabs where possible #82: FILE: arch/arm/plat-samsung/devs.c:291: + .coherent_dma_mask = DMA_BIT_MASK(32),$ WARNING: please, no spaces at the start of a line #82: FILE: arch/arm/plat-samsung/devs.c:291: + .coherent_dma_mask = DMA_BIT_MASK(32),$ ERROR: code indent should use tabs where possible #83: FILE: arch/arm/plat-samsung/devs.c:292: + },$ WARNING: please, no spaces at the start of a line #83: FILE: arch/arm/plat-samsung/devs.c:292: + },$ total: 19 errors, 19 warnings, 67 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile PATCH 13 s5p-g2d add G2D to plat-s5p and mach-exynos4.txt has style problems, please review. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-09 16:04 [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kamil Debski 2011-12-09 16:04 ` [PATCH 1/3] s5p-g2d: add G2D to plat-s5p and mach-exynos4 Kamil Debski @ 2011-12-09 16:04 ` Kamil Debski 2011-12-12 5:27 ` Mark Brown 2011-12-26 3:59 ` Sachin Kamat 2011-12-09 16:04 ` [PATCH 3/3] s5p-g2d: add G2D to mach-universal Kamil Debski 2011-12-24 2:26 ` [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kukjin Kim 3 siblings, 2 replies; 16+ messages in thread From: Kamil Debski @ 2011-12-09 16:04 UTC (permalink / raw) To: linux-samsung-soc; +Cc: m.szyprowski, kyungmin.park, k.debski, kgene.kim Signed-off-by: Kamil Debski <k.debski@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-exynos/Kconfig | 1 + arch/arm/mach-exynos/mach-nuri.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 0afcc3b..176092c 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -171,6 +171,7 @@ config MACH_SMDKV310 select S5P_DEV_FIMC1 select S5P_DEV_FIMC2 select S5P_DEV_FIMC3 + select S5P_DEV_G2D select S5P_DEV_I2C_HDMIPHY select S5P_DEV_MFC select S5P_DEV_TV diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c index 236bbe1..5251e91 100644 --- a/arch/arm/mach-exynos/mach-nuri.c +++ b/arch/arm/mach-exynos/mach-nuri.c @@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[] __initdata = { &s3c_device_i2c3, &i2c9_gpio, &s3c_device_adc, + &s5p_device_g2d, &s3c_device_rtc, &s5p_device_mfc, &s5p_device_mfc_l, -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-09 16:04 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski @ 2011-12-12 5:27 ` Mark Brown 2011-12-12 9:27 ` Kyungmin Park 2011-12-26 3:59 ` Sachin Kamat 1 sibling, 1 reply; 16+ messages in thread From: Mark Brown @ 2011-12-12 5:27 UTC (permalink / raw) To: Kamil Debski; +Cc: linux-samsung-soc, m.szyprowski, kyungmin.park, kgene.kim On Fri, Dec 09, 2011 at 05:04:41PM +0100, Kamil Debski wrote: > index 236bbe1..5251e91 100644 > --- a/arch/arm/mach-exynos/mach-nuri.c > +++ b/arch/arm/mach-exynos/mach-nuri.c > @@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[] __initdata = { > &s3c_device_i2c3, > &i2c9_gpio, > &s3c_device_adc, > + &s5p_device_g2d, For devices like g2d which are always part of the SoC and which don't require any external wiring on the board I was thinking we should just have the core code for the SoC register the device rather than including it in each board individually. It'd save effort and ensure that people automatically get to use the feature. The crypto accelerators are another example of this - it's not really board specific if they're useful. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-12 5:27 ` Mark Brown @ 2011-12-12 9:27 ` Kyungmin Park 2011-12-12 10:03 ` Mark Brown 0 siblings, 1 reply; 16+ messages in thread From: Kyungmin Park @ 2011-12-12 9:27 UTC (permalink / raw) To: Mark Brown; +Cc: Kamil Debski, linux-samsung-soc, m.szyprowski, kgene.kim On 12/12/11, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Fri, Dec 09, 2011 at 05:04:41PM +0100, Kamil Debski wrote: > >> index 236bbe1..5251e91 100644 >> --- a/arch/arm/mach-exynos/mach-nuri.c >> +++ b/arch/arm/mach-exynos/mach-nuri.c >> @@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[] >> __initdata = { >> &s3c_device_i2c3, >> &i2c9_gpio, >> &s3c_device_adc, >> + &s5p_device_g2d, > > For devices like g2d which are always part of the SoC and which don't > require any external wiring on the board I was thinking we should just > have the core code for the SoC register the device rather than including > it in each board individually. It'd save effort and ensure that people > automatically get to use the feature. I'm welcome to use these scheme. make a common.c and register it automatically. but I'm not sure we're ready to use this scheme. and I hope to start these work at smdk board instead of this patch. Thank you, Kyungmin Park > > The crypto accelerators are another example of this - it's not really > board specific if they're useful. > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-12 9:27 ` Kyungmin Park @ 2011-12-12 10:03 ` Mark Brown 2011-12-12 14:32 ` Kyungmin Park 0 siblings, 1 reply; 16+ messages in thread From: Mark Brown @ 2011-12-12 10:03 UTC (permalink / raw) To: Kyungmin Park; +Cc: Kamil Debski, linux-samsung-soc, m.szyprowski, kgene.kim On Mon, Dec 12, 2011 at 06:27:30PM +0900, Kyungmin Park wrote: > On 12/12/11, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > >> + &s5p_device_g2d, > > For devices like g2d which are always part of the SoC and which don't > > require any external wiring on the board I was thinking we should just > > have the core code for the SoC register the device rather than including > > it in each board individually. It'd save effort and ensure that people > > automatically get to use the feature. > I'm welcome to use these scheme. make a common.c and register it automatically. > but I'm not sure we're ready to use this scheme. and I hope to start > these work at smdk board instead of this patch. I'm not sure I understand why we would not be ready to do things like this? I'd also expect that doing things in a board specific fashion might create issues with things being set up twice. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-12 10:03 ` Mark Brown @ 2011-12-12 14:32 ` Kyungmin Park 2011-12-20 1:13 ` Mark Brown 0 siblings, 1 reply; 16+ messages in thread From: Kyungmin Park @ 2011-12-12 14:32 UTC (permalink / raw) To: Mark Brown; +Cc: Kamil Debski, linux-samsung-soc, m.szyprowski, kgene.kim On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Mon, Dec 12, 2011 at 06:27:30PM +0900, Kyungmin Park wrote: >> On 12/12/11, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > >> >> + &s5p_device_g2d, > >> > For devices like g2d which are always part of the SoC and which don't >> > require any external wiring on the board I was thinking we should just >> > have the core code for the SoC register the device rather than including >> > it in each board individually. It'd save effort and ensure that people >> > automatically get to use the feature. > >> I'm welcome to use these scheme. make a common.c and register it automatically. >> but I'm not sure we're ready to use this scheme. and I hope to start >> these work at smdk board instead of this patch. > > I'm not sure I understand why we would not be ready to do things like > this? I'd also expect that doing things in a board specific fashion > might create issues with things being set up twice. Please see the below, https://lkml.org/lkml/2011/11/15/16 Even though I can't agree with his opinions. There are other voice like this. I also want to common registration and select at each board. Thank you, Kyungmin Park > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-12 14:32 ` Kyungmin Park @ 2011-12-20 1:13 ` Mark Brown 2011-12-20 1:27 ` Kyungmin Park 0 siblings, 1 reply; 16+ messages in thread From: Mark Brown @ 2011-12-20 1:13 UTC (permalink / raw) To: Kyungmin Park; +Cc: Kamil Debski, linux-samsung-soc, m.szyprowski, kgene.kim On Mon, Dec 12, 2011 at 11:32:28PM +0900, Kyungmin Park wrote: > On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown > > I'm not sure I understand why we would not be ready to do things like > > this? I'd also expect that doing things in a board specific fashion > > might create issues with things being set up twice. > Please see the below, > https://lkml.org/lkml/2011/11/15/16 > Even though I can't agree with his opinions. There are other voice like this. > I also want to common registration and select at each board. So, I looked at the discussion there and I'm not sure I'm buying what's being said; it seems to be as much a fear of change and a lack of awareness of modern infrastructure as anything else. It seems to me that this is a case where we should just be turning round and saying that the default position ought to be the other way around, if things need to be done per board there should be a strong reason for it. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-20 1:13 ` Mark Brown @ 2011-12-20 1:27 ` Kyungmin Park 2011-12-24 2:22 ` Kukjin Kim 0 siblings, 1 reply; 16+ messages in thread From: Kyungmin Park @ 2011-12-20 1:27 UTC (permalink / raw) To: Mark Brown; +Cc: Kamil Debski, linux-samsung-soc, m.szyprowski, kgene.kim On 12/20/11, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Mon, Dec 12, 2011 at 11:32:28PM +0900, Kyungmin Park wrote: >> On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown > >> > I'm not sure I understand why we would not be ready to do things like >> > this? I'd also expect that doing things in a board specific fashion >> > might create issues with things being set up twice. > >> Please see the below, >> https://lkml.org/lkml/2011/11/15/16 > >> Even though I can't agree with his opinions. There are other voice like >> this. > >> I also want to common registration and select at each board. > > So, I looked at the discussion there and I'm not sure I'm buying what's > being said; it seems to be as much a fear of change and a lack of > awareness of modern infrastructure as anything else. It seems to me > that this is a case where we should just be turning round and saying > that the default position ought to be the other way around, if things > need to be done per board there should be a strong reason for it. Please ask the Mr. Kim. Now he's working on common file so include these functionality. then other boards can follow up. Thank you, Kyungmin Park ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-20 1:27 ` Kyungmin Park @ 2011-12-24 2:22 ` Kukjin Kim 0 siblings, 0 replies; 16+ messages in thread From: Kukjin Kim @ 2011-12-24 2:22 UTC (permalink / raw) To: 'Kyungmin Park', 'Mark Brown' Cc: 'Kamil Debski', linux-samsung-soc, m.szyprowski Kyungmin Park wrote: > > On 12/20/11, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > > On Mon, Dec 12, 2011 at 11:32:28PM +0900, Kyungmin Park wrote: > >> On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown > > > >> > I'm not sure I understand why we would not be ready to do things like > >> > this? I'd also expect that doing things in a board specific fashion > >> > might create issues with things being set up twice. > > > >> Please see the below, > >> https://lkml.org/lkml/2011/11/15/16 > > > >> Even though I can't agree with his opinions. There are other voice like > >> this. > > > >> I also want to common registration and select at each board. > > > > So, I looked at the discussion there and I'm not sure I'm buying what's > > being said; it seems to be as much a fear of change and a lack of > > awareness of modern infrastructure as anything else. It seems to me > > that this is a case where we should just be turning round and saying > > that the default position ought to be the other way around, if things > > need to be done per board there should be a strong reason for it. > > Please ask the Mr. Kim. Now he's working on common file so include > these functionality. > then other boards can follow up. > Hi, I'm not sure it can be included on common.c now, anyway let me check it soon. Merry Christmas. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-09 16:04 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski 2011-12-12 5:27 ` Mark Brown @ 2011-12-26 3:59 ` Sachin Kamat 1 sibling, 0 replies; 16+ messages in thread From: Sachin Kamat @ 2011-12-26 3:59 UTC (permalink / raw) To: Kamil Debski; +Cc: linux-samsung-soc, m.szyprowski, kyungmin.park, kgene.kim Hi Kamil, On 9 December 2011 21:34, Kamil Debski <k.debski@samsung.com> wrote: > Signed-off-by: Kamil Debski <k.debski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-exynos/Kconfig | 1 + > arch/arm/mach-exynos/mach-nuri.c | 1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 0afcc3b..176092c 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -171,6 +171,7 @@ config MACH_SMDKV310 > select S5P_DEV_FIMC1 > select S5P_DEV_FIMC2 > select S5P_DEV_FIMC3 > + select S5P_DEV_G2D Shouldn't this entry be under "config MACH_NURI" instead of MACH_SMDKV310 ? > select S5P_DEV_I2C_HDMIPHY > select S5P_DEV_MFC > select S5P_DEV_TV > diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c > index 236bbe1..5251e91 100644 > --- a/arch/arm/mach-exynos/mach-nuri.c > +++ b/arch/arm/mach-exynos/mach-nuri.c > @@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[] __initdata = { > &s3c_device_i2c3, > &i2c9_gpio, > &s3c_device_adc, > + &s5p_device_g2d, > &s3c_device_rtc, > &s5p_device_mfc, > &s5p_device_mfc_l, > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- With warm regards, Sachin ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 3/3] s5p-g2d: add G2D to mach-universal 2011-12-09 16:04 [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kamil Debski 2011-12-09 16:04 ` [PATCH 1/3] s5p-g2d: add G2D to plat-s5p and mach-exynos4 Kamil Debski 2011-12-09 16:04 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski @ 2011-12-09 16:04 ` Kamil Debski 2011-12-24 2:26 ` [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kukjin Kim 3 siblings, 0 replies; 16+ messages in thread From: Kamil Debski @ 2011-12-09 16:04 UTC (permalink / raw) To: linux-samsung-soc; +Cc: m.szyprowski, kyungmin.park, k.debski, kgene.kim Signed-off-by: Kamil Debski <k.debski@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-exynos/Kconfig | 1 + arch/arm/mach-exynos/mach-universal_c210.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 176092c..618396a 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -218,6 +218,7 @@ config MACH_UNIVERSAL_C210 select S5P_DEV_FIMC1 select S5P_DEV_FIMC2 select S5P_DEV_FIMC3 + select S5P_DEV_G2D select S5P_DEV_CSIS0 select S5P_DEV_FIMD0 select S3C_DEV_HSMMC diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c index a2a177f..eecc201 100644 --- a/arch/arm/mach-exynos/mach-universal_c210.c +++ b/arch/arm/mach-exynos/mach-universal_c210.c @@ -960,6 +960,7 @@ static struct platform_device *universal_devices[] __initdata = { &s5p_device_fimc1, &s5p_device_fimc2, &s5p_device_fimc3, + &s5p_device_g2d, &mmc0_fixed_voltage, &s3c_device_hsmmc0, &s3c_device_hsmmc2, -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* RE: [PATCH 0/3] Samsung S5P platform modification required for G2D driver 2011-12-09 16:04 [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kamil Debski ` (2 preceding siblings ...) 2011-12-09 16:04 ` [PATCH 3/3] s5p-g2d: add G2D to mach-universal Kamil Debski @ 2011-12-24 2:26 ` Kukjin Kim 3 siblings, 0 replies; 16+ messages in thread From: Kukjin Kim @ 2011-12-24 2:26 UTC (permalink / raw) To: 'Kamil Debski', linux-samsung-soc; +Cc: m.szyprowski, kyungmin.park Kamil Debski wrote: > > Hi, > > This series of patches contains necessary platform modification required > by the > G2D driver. G2D is a 2D-graphics acceleration engine present in the > S5PC110 and > Exynos4 Samsung SoCs. > > The patches have been rebased to the newest kgene/for-next branch. The > driver > is currently staging for 3.3 in Mauro's repository, so please include > these > patches for the next release. > > Best wishes, > Kamil Debski > > Kamil Debski (3): > s5p-g2d: add G2D to plat-s5p and mach-exynos4 > s5p-g2d: add G2D to mach-nuri > s5p-g2d: add G2D to mach-universal > > arch/arm/mach-exynos/Kconfig | 2 ++ > arch/arm/mach-exynos/include/mach/map.h | 3 +++ > arch/arm/mach-exynos/mach-nuri.c | 1 + > arch/arm/mach-exynos/mach-universal_c210.c | 1 + > arch/arm/plat-s5p/Kconfig | 5 +++++ > arch/arm/plat-samsung/devs.c | 28 > ++++++++++++++++++++++++++++ > arch/arm/plat-samsung/include/plat/devs.h | 1 + > 7 files changed, 41 insertions(+), 0 deletions(-) Hi Kamil, Looks ok to me with small discussion about including some stuff in common or board file on 2/3 patch. Anyway, will apply. And if any problem, let you know. Merry Christmas. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/3] Samsung S5P platform modification required for G2D driver @ 2011-12-27 13:21 Kamil Debski 2011-12-27 13:21 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski 0 siblings, 1 reply; 16+ messages in thread From: Kamil Debski @ 2011-12-27 13:21 UTC (permalink / raw) To: linux-samsung-soc Cc: m.szyprowski, kyungmin.park, k.debski, jaeryul.oh, jtp.park, kgene.kim, sachin.kamat Hi, This series of patches contains necessary platform modification required by the G2D driver. G2D is a 2D-graphics acceleration engine present in the S5PC110 and Exynos4 Samsung SoCs. I have fixed the errors pointed out by Kukjin Kim an Sachin Kamat. (Thanks!) Also the patches have been rebased to the newest kgene/for-next branch. Best wishes, Kamil Debski Kamil Debski (3): s5p-g2d: add G2D to plat-s5p and mach-exynos4 s5p-g2d: add G2D to mach-nuri s5p-g2d: add G2D to mach-universal arch/arm/mach-exynos/Kconfig | 2 ++ arch/arm/mach-exynos/include/mach/map.h | 3 +++ arch/arm/mach-exynos/mach-nuri.c | 1 + arch/arm/mach-exynos/mach-universal_c210.c | 1 + arch/arm/plat-s5p/Kconfig | 5 +++++ arch/arm/plat-samsung/devs.c | 28 ++++++++++++++++++++++++++++ arch/arm/plat-samsung/include/plat/devs.h | 1 + 7 files changed, 41 insertions(+), 0 deletions(-) ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-12-27 13:21 Kamil Debski @ 2011-12-27 13:21 ` Kamil Debski 0 siblings, 0 replies; 16+ messages in thread From: Kamil Debski @ 2011-12-27 13:21 UTC (permalink / raw) To: linux-samsung-soc Cc: m.szyprowski, kyungmin.park, k.debski, jaeryul.oh, jtp.park, kgene.kim, sachin.kamat G2D is a 2D graphics accelerator engine present in the s5p family of Samsung SoCs. It is capable of bitblt and raster operations on images having dimensions of up to 8000x8000. Signed-off-by: Kamil Debski <k.debski@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-exynos/Kconfig | 1 + arch/arm/mach-exynos/mach-nuri.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 4e36e8f..3bd0eec 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -271,6 +271,7 @@ config MACH_NURI select S5P_DEV_FIMC1 select S5P_DEV_FIMC2 select S5P_DEV_FIMC3 + select S5P_DEV_G2D select S5P_DEV_MFC select S5P_DEV_USB_EHCI select S5P_SETUP_MIPIPHY diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c index 4df7d3e..3df8bf4 100644 --- a/arch/arm/mach-exynos/mach-nuri.c +++ b/arch/arm/mach-exynos/mach-nuri.c @@ -1261,6 +1261,7 @@ static struct platform_device *nuri_devices[] __initdata = { &s3c_device_i2c3, &i2c9_gpio, &s3c_device_adc, + &s5p_device_g2d, &s3c_device_rtc, &s5p_device_mfc, &s5p_device_mfc_l, -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 0/3] Samsung S5P platform modification required for G2D driver @ 2011-08-08 17:16 Kamil Debski 2011-08-08 17:16 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski 0 siblings, 1 reply; 16+ messages in thread From: Kamil Debski @ 2011-08-08 17:16 UTC (permalink / raw) To: linux-samsung-soc; +Cc: m.szyprowski, kyungmin.park, k.debski Hi, This series of patches contains necessary platform modification required by the G2D driver. G2D is a 2D-graphics acceleration engine present in the S5PC110 and Exynos4 Samsung SoCs. Best wishes, Kamil Debski Kamil Debski (3): s5p-g2d: add G2D to plat-s5p and mach-exynos4 s5p-g2d: add G2D to mach-nuri s5p-g2d: add G2D to mach-universal arch/arm/mach-exynos4/Kconfig | 2 + arch/arm/mach-exynos4/include/mach/map.h | 3 ++ arch/arm/mach-exynos4/mach-nuri.c | 1 + arch/arm/mach-exynos4/mach-universal_c210.c | 1 + arch/arm/plat-s5p/Kconfig | 5 +++ arch/arm/plat-s5p/Makefile | 1 + arch/arm/plat-s5p/dev-g2d.c | 43 +++++++++++++++++++++++++++ arch/arm/plat-samsung/include/plat/devs.h | 2 +- 8 files changed, 57 insertions(+), 1 deletions(-) create mode 100644 arch/arm/plat-s5p/dev-g2d.c ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/3] s5p-g2d: add G2D to mach-nuri 2011-08-08 17:16 [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kamil Debski @ 2011-08-08 17:16 ` Kamil Debski 0 siblings, 0 replies; 16+ messages in thread From: Kamil Debski @ 2011-08-08 17:16 UTC (permalink / raw) To: linux-samsung-soc; +Cc: m.szyprowski, kyungmin.park, k.debski G2D is a 2D graphics accelerator engine present in the s5p family of Samsung SoCs. It is capable of bitblt and raster operations on images having dimensions of up to 8000x8000. Signed-off-by: Kamil Debski <k.debski@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-exynos4/Kconfig | 1 + arch/arm/mach-exynos4/mach-nuri.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig index 876e216..374d1fc 100644 --- a/arch/arm/mach-exynos4/Kconfig +++ b/arch/arm/mach-exynos4/Kconfig @@ -218,6 +218,7 @@ config MACH_NURI select S5P_DEV_MFC select S3C_DEV_RTC select S5P_DEV_USB_EHCI + select S5P_DEV_G2D select S3C_DEV_USB_HSOTG select EXYNOS4_DEV_PD select EXYNOS4_SETUP_FIMD0 diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c index 120731d..0cc44c5 100644 --- a/arch/arm/mach-exynos4/mach-nuri.c +++ b/arch/arm/mach-exynos4/mach-nuri.c @@ -1134,6 +1134,7 @@ static struct platform_device *nuri_devices[] __initdata = { &i2c9_gpio, &s3c_device_usb_hsotg, &s3c_device_adc, + &s5p_device_g2d, &s3c_device_rtc, &s5p_device_mfc, &s5p_device_mfc_l, -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 16+ messages in thread
end of thread, other threads:[~2011-12-27 13:21 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-12-09 16:04 [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kamil Debski 2011-12-09 16:04 ` [PATCH 1/3] s5p-g2d: add G2D to plat-s5p and mach-exynos4 Kamil Debski 2011-12-24 3:12 ` Kukjin Kim 2011-12-09 16:04 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski 2011-12-12 5:27 ` Mark Brown 2011-12-12 9:27 ` Kyungmin Park 2011-12-12 10:03 ` Mark Brown 2011-12-12 14:32 ` Kyungmin Park 2011-12-20 1:13 ` Mark Brown 2011-12-20 1:27 ` Kyungmin Park 2011-12-24 2:22 ` Kukjin Kim 2011-12-26 3:59 ` Sachin Kamat 2011-12-09 16:04 ` [PATCH 3/3] s5p-g2d: add G2D to mach-universal Kamil Debski 2011-12-24 2:26 ` [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kukjin Kim -- strict thread matches above, loose matches on Subject: below -- 2011-12-27 13:21 Kamil Debski 2011-12-27 13:21 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski 2011-08-08 17:16 [PATCH 0/3] Samsung S5P platform modification required for G2D driver Kamil Debski 2011-08-08 17:16 ` [PATCH 2/3] s5p-g2d: add G2D to mach-nuri Kamil Debski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.