From: Stephen Hemminger <shemminger@vyatta.com>
To: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH] bridge: push blocking slaves to forwarding when turning stp off
Date: Tue, 20 Dec 2011 10:11:17 -0800 [thread overview]
Message-ID: <20111220101117.2a3eb12f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <201112201259.12086.vitas@nppfactor.kiev.ua>
On Tue, 20 Dec 2011 12:59:11 +0200
Vitalii Demianets <vitas@nppfactor.kiev.ua> wrote:
> Hello, Stephen!
> I can not understand your silence.
> There are issues fixed by the patch in question. For example, if the interface
> is left in blocking state after stp was turned off, that state is not
> stable - it can flip to forwarding state in unpredictable times, e.g. when
> _any other_ slave of the bridge goes up or down. Do you think user wants
> exactly that unpredictable state change?
> Also, the code in question in function br_stp_stop(), namely
> br_port_state_selection(br) call, does exactly nothing except wasting cpu
> cycles. Isn't it worth fixing?
>
I had to go do real work last week.
Let me test and look at it more detail.
There is no urgency, the problem has existed for many years.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Michael Tremer <michael.tremer@ipfire.org>
Subject: Re: [PATCH] bridge: push blocking slaves to forwarding when turning stp off
Date: Tue, 20 Dec 2011 10:11:17 -0800 [thread overview]
Message-ID: <20111220101117.2a3eb12f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <201112201259.12086.vitas@nppfactor.kiev.ua>
On Tue, 20 Dec 2011 12:59:11 +0200
Vitalii Demianets <vitas@nppfactor.kiev.ua> wrote:
> Hello, Stephen!
> I can not understand your silence.
> There are issues fixed by the patch in question. For example, if the interface
> is left in blocking state after stp was turned off, that state is not
> stable - it can flip to forwarding state in unpredictable times, e.g. when
> _any other_ slave of the bridge goes up or down. Do you think user wants
> exactly that unpredictable state change?
> Also, the code in question in function br_stp_stop(), namely
> br_port_state_selection(br) call, does exactly nothing except wasting cpu
> cycles. Isn't it worth fixing?
>
I had to go do real work last week.
Let me test and look at it more detail.
There is no urgency, the problem has existed for many years.
next prev parent reply other threads:[~2011-12-20 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 9:36 [Bridge] [PATCH] bridge: push blocking slaves to forwarding when turning stp off Vitalii Demianets
2011-12-13 9:36 ` Vitalii Demianets
2011-12-14 0:16 ` [Bridge] " Stephen Hemminger
2011-12-14 0:16 ` Stephen Hemminger
2011-12-14 9:32 ` [Bridge] " Vitalii Demianets
2011-12-14 9:32 ` Vitalii Demianets
2011-12-20 10:59 ` [Bridge] " Vitalii Demianets
2011-12-20 10:59 ` Vitalii Demianets
2011-12-20 18:11 ` Stephen Hemminger [this message]
2011-12-20 18:11 ` Stephen Hemminger
2011-12-20 18:27 ` [Bridge] " Vitalii Demianets
2011-12-20 18:27 ` Vitalii Demianets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220101117.2a3eb12f@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=vitas@nppfactor.kiev.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.