All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: David Henningsson <david.henningsson@canonical.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board
Date: Wed, 21 Dec 2011 16:24:17 +0800	[thread overview]
Message-ID: <20111221082416.GA20153@localhost> (raw)
In-Reply-To: <4EF19440.10801@canonical.com>

On Wed, Dec 21, 2011 at 04:09:36PM +0800, David Henningsson wrote:
> On 12/21/2011 08:23 AM, Wu Fengguang wrote:
> > On Wed, Dec 21, 2011 at 02:46:32PM +0800, Takashi Iwai wrote:
> >> I'm in the process removing all these model quirks.
> >
> > Doesn't that risk introducing many regressions? What would be the
> > problem if we switch to the generic HDA driver for *new* boards and
> > leave the old working quicks/models untouched?
> 
> For me, it's the other way around. Whenever we try to improve the 
> generic behaviour of the codec driver, e g by adding configurable 
> auto-mute, jack detection notification etc, these old models get left 
> behind because the new stuff depends on information we get out of the 
> autoparser(s).
> 
> By removing the model quirks, these machines can benefit from the new 
> functionality as well.

Yeah that's a good point of view! I cannot agree it any more.

Thanks,
Fengguang

  reply	other threads:[~2011-12-21  8:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21  2:20 [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board Wu Fengguang
2011-12-21  6:46 ` Takashi Iwai
2011-12-21  7:23   ` Wu Fengguang
2011-12-21  7:34     ` Takashi Iwai
2011-12-21  8:09     ` David Henningsson
2011-12-21  8:24       ` Wu Fengguang [this message]
2011-12-21  7:38   ` Wu Fengguang
2011-12-21  7:42     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111221082416.GA20153@localhost \
    --to=fengguang.wu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.